From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: dandan.bi@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Sun, 22 Sep 2019 18:29:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Sep 2019 18:29:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,538,1559545200"; d="scan'208";a="272121389" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 22 Sep 2019 18:29:03 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Sep 2019 18:29:02 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Sep 2019 18:29:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.235]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 09:28:59 +0800 From: "Dandan Bi" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures Thread-Index: AQHVbxNMJ7BLrw5lqEG3PBmP5c5Z/qc4fi3Q Date: Mon, 23 Sep 2019 01:28:59 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40C5E6F9@SHSMSX104.ccr.corp.intel.com> References: <20190919175419.23204-1-michael.a.kubacki@intel.com> In-Reply-To: <20190919175419.23204-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Friday, September 20, 2019 1:54 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Chaganty, Rangasai V > ; Gao, Liming > Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] > AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2204 >=20 > These build failures can be reproduced simply by building the > AdvancedFeaturePkg.dsc file in GCC5 for X64 architecture. To build the w= hole > package DSC (not pull individual features into other packages), set the > WORKSPACE variable to the edk2 directory in the workspace as is done by > executing edksetup.sh then create the PACKAGES_PATH variable and add > the Platform/Intel and Silicon/Intel directories to the variable value. = Then > start the build of AdvancedFeaturePkg.dsc: > 'build -p AdvancedFeaturePkg/AdvancedFeaturePkg.dsc -a X64' >=20 > This change adds EFIAPI to the following function declarations so they a= re > consistent with the declaration for module entry points. > * BmcElog.c - InitializeBmcElogLayer () > * FrbPei.c - InitializeFrbPei () > * IpmiFru.c - InitializeFru () >=20 > All future contributions to AdvancedFeaturePkg must successfully build i= n > GCC after this change. >=20 > Cc: Dandan Bi > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Michael Kubacki > --- > Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c | 3 ++- > Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c | 3 ++- > Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c | 3 ++- > 3 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c > b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c > index e214f1a18b..a6d075b19c 100644 > --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c > +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c > @@ -1,7 +1,7 @@ > /** @file > BMC Event Log functions. >=20 > -Copyright (c) 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -171,6 +171,7 @@ Returns: > } >=20 > EFI_STATUS > +EFIAPI > InitializeBmcElogLayer ( > IN EFI_HANDLE ImageHandle, > IN EFI_SYSTEM_TABLE *SystemTable > diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c > b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c > index 962cd7cc9b..5d33df0103 100644 > --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c > +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c > @@ -1,7 +1,7 @@ > /** @file > IPMI FRB PEIM. >=20 > -Copyright (c) 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -51,6 +51,7 @@ SetWatchDogTimer ( > } >=20 > EFI_STATUS > +EFIAPI > InitializeFrbPei ( > IN EFI_PEI_FILE_HANDLE FileHandle, > IN CONST EFI_PEI_SERVICES **PeiServices > diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c > b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c > index 663983fd68..58e1fb4d7e 100644 > --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c > +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c > @@ -1,7 +1,7 @@ > /** @file > IPMI FRU Driver. >=20 > -Copyright (c) 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -15,6 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > >=20 > EFI_STATUS > +EFIAPI > InitializeFru ( > IN EFI_HANDLE ImageHandle, > IN EFI_SYSTEM_TABLE *SystemTable > -- > 2.16.2.windows.1 >=20 >=20 >=20