From: "Dandan Bi" <dandan.bi@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v2 3/3] MdeModulePkg/Mem: Initialize the variable MapMemory
Date: Fri, 1 Nov 2019 01:59:31 +0000 [thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40C942FD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191030140830.31156-4-shenglei.zhang@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, October 30, 2019 10:09 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v2 3/3] MdeModulePkg/Mem: Initialize the variable
> MapMemory
>
> MapMemory is not initialized by FindGuardedMemoryMap or
> CoreInternalAllocatePages which calls MapMemory.
> So we give a 0 to it.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c
> b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c
> index 9477b94044ba..b4cb48843fb7 100644
> --- a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c
> +++ b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c
> @@ -225,6 +225,8 @@ FindGuardedMemoryMap (
> UINTN BitsToUnitEnd;
> EFI_STATUS Status;
>
> + MapMemory = 0;
> +
> //
> // Adjust current map table depth according to the address to access
> //
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2019-11-01 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 14:08 [PATCH v2 0/3] MdeModulePkg: Initialize variables Zhang, Shenglei
2019-10-30 14:08 ` [PATCH v2 1/3] MdeModulePkg/EhciPei: Initialize the variable Map Zhang, Shenglei
2019-10-31 1:59 ` Wu, Hao A
2019-10-30 14:08 ` [PATCH v2 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap Zhang, Shenglei
2019-10-31 1:58 ` Wu, Hao A
2019-10-30 14:08 ` [PATCH v2 3/3] MdeModulePkg/Mem: Initialize the variable MapMemory Zhang, Shenglei
2019-11-01 1:59 ` Dandan Bi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB40C942FD@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox