From: "Dandan Bi" <dandan.bi@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private->Attribute >> 4'
Date: Fri, 1 Nov 2019 02:10:51 +0000 [thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40C94329@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191030134532.31248-1-shenglei.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, October 30, 2019 9:46 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private-
> >Attribute >> 4'
>
> The size of mHiiEfiColors is 16.
> mHiiEfiColors[Private->Attribute >> 4] may be out of boundary.
> So add a check for that.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: Instead of returing value, we add ASSERT to ensure
> "Private->Attribute >> 4" is not out of boundary.
>
> MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> index ca63df168c94..1eee5ec76bb0 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> @@ -999,6 +999,7 @@ GetSystemFont (
> }
>
> Info->ForegroundColor = mHiiEfiColors[Private->Attribute & 0x0f];
> + ASSERT ((Private->Attribute >> 4) < 16);
Hi Shenglei,
1) I think we can add ASSERT ((Private->Attribute >> 4) < 8); here directly, the reason can refer my comments in V1 patch.
2) And please also update the subject and commit message accordingly.
With above comments addressed, Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
> Info->BackgroundColor = mHiiEfiColors[Private->Attribute >> 4];
> Info->FontInfoMask = EFI_FONT_INFO_SYS_FONT |
> EFI_FONT_INFO_SYS_SIZE | EFI_FONT_INFO_SYS_STYLE;
> Info->FontInfo.FontStyle = 0;
> --
> 2.18.0.windows.1
prev parent reply other threads:[~2019-11-01 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 13:45 [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private->Attribute >> 4' Zhang, Shenglei
2019-11-01 2:10 ` Dandan Bi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB40C94329@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox