Re: [edk2-devel] [PATCH] Edk2\MdeModulePkg: Adding Perf macros to reduce the gaps in Perf logs

["Dandan Bi" <dandan.bi@intel.com>]

Hi,

Some minor comments for the subject and commit message which should describe what you have done in the patch precisely.
1. Could you update the Subject to  MdeModulePkg/DxeIpl: Record performance of ExtractGuidedSectionDecode?
2. Could you update the commit message to something like this: Add Perf macros to record the execution performance data of function ExtractGuidedSectionDecode.
3.  Please remove this line in commit message: Change-Id: I84cc5ec34fbd1e52cec983a86aa7f12b73f67625 .

And please run PatchCheck.py tool in edk2\BaseTools\Scripts to check the coding style issue for the patch.
Commit message format: https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format


Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Deshpande
> Sent: Friday, November 22, 2019 9:21 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] Edk2\MdeModulePkg: Adding Perf macros to
> reduce the gaps in Perf logs
> 
> Updated Edk2\MdeModulePkg\Core\DxeIplPeim\DxeLoad.c file to add perf
> macros.
> 
> Change-Id: I84cc5ec34fbd1e52cec983a86aa7f12b73f67625
> Signed-off-by: Deshpande <madhura.deshpande@intel.com>
> ---
>  MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> index d48028cea0..a679c68515 100644
> --- a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> +++ b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> @@ -622,12 +622,17 @@ CustomGuidedSectionExtract (
>      DEBUG ((DEBUG_INFO, "Customized Guided section Memory Size
> required is 0x%x and address is 0x%p\n", OutputBufferSize, *OutputBuffer));
>    }
> 
> +  PERF_INMODULE_BEGIN ("ExtractGuidedSectionDecode");
> +
>    Status = ExtractGuidedSectionDecode (
>               InputSection,
>               OutputBuffer,
>               ScratchBuffer,
>               AuthenticationStatus
>               );
> +
> +  PERF_INMODULE_END ("ExtractGuidedSectionDecode");
> +
>    if (EFI_ERROR (Status)) {
>      //
>      // Decode failed
> --
> 2.16.2.windows.1
> 
> 
>