From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mx.groups.io with SMTP id smtpd.web10.9117.1574758051943876013
 for <devel@edk2.groups.io>;
 Tue, 26 Nov 2019 00:47:32 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: dandan.bi@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 00:47:31 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,245,1571727600"; 
   d="scan'208";a="359106820"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by orsmga004.jf.intel.com with ESMTP; 26 Nov 2019 00:47:31 -0800
Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 26 Nov 2019 00:47:30 -0800
Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by
 fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 26 Nov 2019 00:47:30 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by
 SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000;
 Tue, 26 Nov 2019 16:47:28 +0800
From: "Dandan Bi" <dandan.bi@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Deshpande, Madhura"
	<madhura.deshpande@intel.com>
Subject: Re: [edk2-devel] [PATCH] Edk2\MdeModulePkg: Adding Perf macros to reduce the gaps in Perf logs
Thread-Topic: [edk2-devel] [PATCH] Edk2\MdeModulePkg: Adding Perf macros to
 reduce the gaps in Perf logs
Thread-Index: AQHVoNPLMrX++RYHBUWmiipDD2zCw6edJiXg
Date: Tue, 26 Nov 2019 08:47:27 +0000
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40CA80B0@SHSMSX104.ccr.corp.intel.com>
References: <20191122012105.14028-1-madhura.deshpande@intel.com>
In-Reply-To: <20191122012105.14028-1-madhura.deshpande@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: dandan.bi@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi,

Some minor comments for the subject and commit message which should descri=
be what you have done in the patch precisely.
1. Could you update the Subject to  MdeModulePkg/DxeIpl: Record performanc=
e of ExtractGuidedSectionDecode?
2. Could you update the commit message to something like this: Add Perf ma=
cros to record the execution performance data of function ExtractGuidedSect=
ionDecode.
3.  Please remove this line in commit message: Change-Id: I84cc5ec34fbd1e5=
2cec983a86aa7f12b73f67625 .

And please run PatchCheck.py tool in edk2\BaseTools\Scripts to check the c=
oding style issue for the patch.
Commit message format: https://github.com/tianocore/tianocore.github.io/wi=
ki/Commit-Message-Format


Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Deshpande
> Sent: Friday, November 22, 2019 9:21 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] Edk2\MdeModulePkg: Adding Perf macros to
> reduce the gaps in Perf logs
>=20
> Updated Edk2\MdeModulePkg\Core\DxeIplPeim\DxeLoad.c file to add perf
> macros.
>=20
> Change-Id: I84cc5ec34fbd1e52cec983a86aa7f12b73f67625
> Signed-off-by: Deshpande <madhura.deshpande@intel.com>
> ---
>  MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> index d48028cea0..a679c68515 100644
> --- a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> +++ b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> @@ -622,12 +622,17 @@ CustomGuidedSectionExtract (
>      DEBUG ((DEBUG_INFO, "Customized Guided section Memory Size
> required is 0x%x and address is 0x%p\n", OutputBufferSize, *OutputBuffer=
));
>    }
>=20
> +  PERF_INMODULE_BEGIN ("ExtractGuidedSectionDecode");
> +
>    Status =3D ExtractGuidedSectionDecode (
>               InputSection,
>               OutputBuffer,
>               ScratchBuffer,
>               AuthenticationStatus
>               );
> +
> +  PERF_INMODULE_END ("ExtractGuidedSectionDecode");
> +
>    if (EFI_ERROR (Status)) {
>      //
>      // Decode failed
> --
> 2.16.2.windows.1
>=20
>=20
>=20