reg: Remove Framework HII "class\subclass" in all VFR

reg: Remove Framework HII "class\subclass" in all VFR

[Sivaraman Nainar]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hello Jiaxin:

Edk2 older branch removed the "class\subclass" in all VFR in the Network Stack modules. (IP4, IP6 and ISCSI) Refer below commit.

https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b1fa2c2ed8bd8#diff-3d9f695b702160a70a74145d12121272

But when we upload the Initial IP4Dxe the changes are reverted. But IP6Config and ISCSI modules are not having those.

https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a0209674601a90#diff-6788a5f6871902342bd0ea72eb123df4

Do we have any specific reason behind that.

-Siva

[-- Attachment #2: Type: text/html, Size: 2974 bytes --]

Re: reg: Remove Framework HII "class\subclass" in all VFR

[Wu, Jiaxin]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

According to below comments:

class/subclass is the obseleted key word in VFR file. It is designed in framework HII. After convert to UEFI HII, it is not used any longer. Now remove them from VFR Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17493 6f19259b-4bc3-4df7-8a09-765794883524
It looks like the bug in edk2 network. Loop in HII expert(Bi Dandan) to confirm that. If yes, please report Bugzilla for that.

Thanks,
Jiaxin


From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sivaraman Nainar
Sent: Tuesday, December 24, 2019 5:45 PM
To: Fu, Siyuan <siyuan.fu@intel.com>; devel@edk2.groups.io; Wu, Jiaxin <jiaxin.wu@intel.com>
Cc: Ramesh R. <rameshr@ami.com>
Subject: [edk2-devel] reg: Remove Framework HII "class\subclass" in all VFR

Hello Jiaxin:

Edk2 older branch removed the "class\subclass" in all VFR in the Network Stack modules. (IP4, IP6 and ISCSI) Refer below commit.

https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b1fa2c2ed8bd8#diff-3d9f695b702160a70a74145d12121272

But when we upload the Initial IP4Dxe the changes are reverted. But IP6Config and ISCSI modules are not having those.

https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a0209674601a90#diff-6788a5f6871902342bd0ea72eb123df4

Do we have any specific reason behind that.

-Siva


[-- Attachment #2: Type: text/html, Size: 6016 bytes --]

Re: reg: Remove Framework HII "class\subclass" in all VFR

[Dandan Bi]

[-- Attachment #1: Type: text/plain, Size: 2147 bytes --]

Class\subclass are not used any more, can be deleted from VFR files.


Thanks,
Dandan

From: Wu, Jiaxin
Sent: Friday, December 27, 2019 4:21 PM
To: devel@edk2.groups.io; sivaramann@amiindia.co.in; Fu, Siyuan <siyuan.fu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Rabeda, Maciej <maciej.rabeda@intel.com>
Cc: Ramesh R. <rameshr@ami.com>
Subject: RE: reg: Remove Framework HII "class\subclass" in all VFR

According to below comments:

class/subclass is the obseleted key word in VFR file. It is designed in framework HII. After convert to UEFI HII, it is not used any longer. Now remove them from VFR Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>
Reviewed-by: Eric Dong <eric.dong@intel.com<mailto:eric.dong@intel.com>>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17493 6f19259b-4bc3-4df7-8a09-765794883524

It looks like the bug in edk2 network. Loop in HII expert(Bi Dandan) to confirm that. If yes, please report Bugzilla for that.

Thanks,
Jiaxin


From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Sivaraman Nainar
Sent: Tuesday, December 24, 2019 5:45 PM
To: Fu, Siyuan <siyuan.fu@intel.com<mailto:siyuan.fu@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Wu, Jiaxin <jiaxin.wu@intel.com<mailto:jiaxin.wu@intel.com>>
Cc: Ramesh R. <rameshr@ami.com<mailto:rameshr@ami.com>>
Subject: [edk2-devel] reg: Remove Framework HII "class\subclass" in all VFR

Hello Jiaxin:

Edk2 older branch removed the "class\subclass" in all VFR in the Network Stack modules. (IP4, IP6 and ISCSI) Refer below commit.

https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b1fa2c2ed8bd8#diff-3d9f695b702160a70a74145d12121272

But when we upload the Initial IP4Dxe the changes are reverted. But IP6Config and ISCSI modules are not having those.

https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a0209674601a90#diff-6788a5f6871902342bd0ea72eb123df4

Do we have any specific reason behind that.

-Siva


[-- Attachment #2: Type: text/html, Size: 7865 bytes --]