From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.29253.1577436473590286217 for ; Fri, 27 Dec 2019 00:47:53 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: dandan.bi@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Dec 2019 00:47:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,362,1571727600"; d="scan'208,217";a="300600615" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 27 Dec 2019 00:47:52 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Dec 2019 00:47:52 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Dec 2019 00:47:51 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.71]) with mapi id 14.03.0439.000; Fri, 27 Dec 2019 16:47:49 +0800 From: "Dandan Bi" To: "Wu, Jiaxin" , "devel@edk2.groups.io" , "sivaramann@amiindia.co.in" , "Fu, Siyuan" , "Rabeda, Maciej" CC: Ramesh R. Subject: Re: reg: Remove Framework HII "class\subclass" in all VFR Thread-Topic: reg: Remove Framework HII "class\subclass" in all VFR Thread-Index: AdW6Pm+7Y6LeLsuHTOCpjI7iCCTxzACT6w1QAAD/EJA= Date: Fri, 27 Dec 2019 08:47:49 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40CD45F2@SHSMSX104.ccr.corp.intel.com> References: <895558F6EA4E3B41AC93A00D163B727416FC8621@SHSMSX107.ccr.corp.intel.com> In-Reply-To: <895558F6EA4E3B41AC93A00D163B727416FC8621@SHSMSX107.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_3C0D5C461C9E904E8F62152F6274C0BB40CD45F2SHSMSX104ccrcor_" --_000_3C0D5C461C9E904E8F62152F6274C0BB40CD45F2SHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Class\subclass are not used any more, can be deleted from VFR files. Thanks, Dandan From: Wu, Jiaxin Sent: Friday, December 27, 2019 4:21 PM To: devel@edk2.groups.io; sivaramann@amiindia.co.in; Fu, Siyuan ; Bi, Dandan ; Rabeda, Maciej Cc: Ramesh R. Subject: RE: reg: Remove Framework HII "class\subclass" in all VFR According to below comments: class/subclass is the obseleted key word in VFR file. It is designed in fr= amework HII. After convert to UEFI HII, it is not used any longer. Now remo= ve them from VFR Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi > Reviewed-by: Eric Dong > git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17493 6f19259b-= 4bc3-4df7-8a09-765794883524 It looks like the bug in edk2 network. Loop in HII expert(Bi Dandan) to co= nfirm that. If yes, please report Bugzilla for that. Thanks, Jiaxin From: devel@edk2.groups.io > On Behalf Of Sivaraman Nainar Sent: Tuesday, December 24, 2019 5:45 PM To: Fu, Siyuan >; devel@ed= k2.groups.io; Wu, Jiaxin > Cc: Ramesh R. > Subject: [edk2-devel] reg: Remove Framework HII "class\subclass" in all VF= R Hello Jiaxin: Edk2 older branch removed the "class\subclass" in all VFR in the Network S= tack modules. (IP4, IP6 and ISCSI) Refer below commit. https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b1fa2c= 2ed8bd8#diff-3d9f695b702160a70a74145d12121272 But when we upload the Initial IP4Dxe the changes are reverted. But IP6Con= fig and ISCSI modules are not having those. https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a020967= 4601a90#diff-6788a5f6871902342bd0ea72eb123df4 Do we have any specific reason behind that. -Siva --_000_3C0D5C461C9E904E8F62152F6274C0BB40CD45F2SHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Class\subclass are no= t used any more, can be deleted from VFR files.

 

 

Thanks,

Dandan

 

From: Wu, Jiaxin
Sent: Friday, December 27, 2019 4:21 PM
To: devel@edk2.groups.io; sivaramann@amiindia.co.in; Fu, Siyuan <= ;siyuan.fu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Rabeda, M= aciej <maciej.rabeda@intel.com>
Cc: Ramesh R. <rameshr@ami.com>
Subject: RE: reg: Remove Framework HII "class\subclass" i= n all VFR

 

According to below comments:

 

class/subclass is the obseleted key word in VFR file. It i= s designed in framework HII. After convert to UEFI HII, it is not used any = longer. Now remove them from VFR Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Dandan Bi <dandan.bi@intel.com>

Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17493= 6f19259b-4bc3-4df7-8a09-765794883524

 

It looks like the bug in edk2 network. Loop in HII = expert(Bi Dandan) to confirm that. If yes, please report Bugzilla for that.=

 

Thanks,

Jiaxin

 

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Sivaraman Nainar
Sent: Tuesday, December 24, 2019 5:45 PM
To: Fu, Siyuan <siyuan.fu= @intel.com>; devel@edk2.groups.io; Wu, Jiax= in <jiaxin.wu@intel.com> Cc: Ramesh R. <rameshr@ami.co= m>
Subject: [edk2-devel] reg: Remove Framework HII "class\subclas= s" in all VFR

 

Hello Jiaxin:

 

Edk2 older branch removed the "class\subclass&= quot; in all VFR in the Network Stack modules. (IP4, IP6 and ISCSI) Refer b= elow commit.

 

https://github.com/tianocore/edk2/commit/b965bd99c533b24bec56647a8c9b= 1fa2c2ed8bd8#diff-3d9f695b702160a70a74145d12121272

 

But when we upload the Initial IP4Dxe the changes a= re reverted. But IP6Config and ISCSI modules are not having those.

 

https://github.com/tianocore/edk2/commit/1f6729ffe98095107ce82e67a4a0= 209674601a90#diff-6788a5f6871902342bd0ea72eb123df4

 

Do we have any specific reason behind that.

 

-Siva

--_000_3C0D5C461C9E904E8F62152F6274C0BB40CD45F2SHSMSX104ccrcor_--