From: "Dandan Bi" <dandan.bi@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"nickle.wang@hpe.com" <nickle.wang@hpe.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.
Date: Thu, 20 Feb 2020 08:24:04 +0000 [thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200219142240.10448-1-nickle.wang@hpe.com>
Thanks Nickle for the fix.
One minor comment is that please pay attention to the format of commit message.
Refer to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format, Line length of commit message should be less than 76 characters when possible.
Please address it when submit the patch.
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Nickle Wang
> Sent: Wednesday, February 19, 2020 10:23 PM
> To: devel@edk2.groups.io; nickle.wang@hpe.com
> Cc: Bi, Dandan <dandan.bi@intel.com>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix
> IsZeroGuid() ASSERT.
>
> From the function description of GetIfrBinaryData(), FormSetGuid can be
> NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes
> exception when FormSetGuid is NULL.
>
> Signed-off-by: Nickle Wang <nickle.wang@hpe.com>
> ---
> MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> index 288f1c3197..82067b541c 100644
> --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> @@ -2,6 +2,7 @@
> Entry and initialization module for the browser.
>
> Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -5844,7 +5845,7 @@ GetIfrBinaryData (
> //
> // Try to compare against formset GUID
> //
> - if (IsZeroGuid (FormSetGuid) ||
> + if (IsZeroGuid (ComparingGuid) ||
> CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData + sizeof
> (EFI_IFR_OP_HEADER)))) {
> break;
> }
> --
> 2.20.1.windows.1
>
>
>
next prev parent reply other threads:[~2020-02-20 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 14:22 [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT nickle.wang
2020-02-20 8:24 ` Dandan Bi [this message]
2020-02-20 14:20 ` [edk2-devel] " Liming Gao
2020-02-21 2:21 ` Nickle Wang
2020-02-21 2:23 ` Liming Gao
2020-02-21 2:25 ` Nickle Wang
2020-02-21 2:17 ` Nickle Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox