From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by mx.groups.io with SMTP id smtpd.web12.3471.1585271849830063236
 for <devel@edk2.groups.io>;
 Thu, 26 Mar 2020 18:17:29 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: dandan.bi@intel.com)
IronPort-SDR: TOmf5VDcNMCtG+O06t3R6678VmnGuFpMysfmsrcpianUT/WnRUFfsSks9EwUyaj/EHwW/+qCzp
 de8rRMxDTnjg==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
  by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 18:17:29 -0700
IronPort-SDR: ydm+S7gvETbjEoZ9rTJNHAFgBV3NTB2aj6mit6iAn87WW0IS9pimCeVFQlnmVp615cgwDLEJRs
 BREYIOZnBDcA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.72,310,1580803200"; 
   d="scan'208";a="358341515"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2020 18:17:29 -0700
Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 26 Mar 2020 18:17:29 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 26 Mar 2020 18:17:29 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.155]) with mapi id 14.03.0439.000;
 Fri, 27 Mar 2020 09:17:26 +0800
From: "Dandan Bi" <dandan.bi@intel.com>
To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Gao, Liming" <liming.gao@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
	Leif Lindholm <leif@nuviainc.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms
Thread-Topic: [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions
 default for Arm64 platforms
Thread-Index: AQHWAGQeYa6yDc9Bn0isMWwlNH9pEqhbqYqA
Date: Fri, 27 Mar 2020 01:17:26 +0000
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40D8A026@SHSMSX104.ccr.corp.intel.com>
References: <20200322160816.18426-1-samer@elhajmahmoud.com>
In-Reply-To: <20200322160816.18426-1-samer@elhajmahmoud.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: dandan.bi@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Dandan Bi <dandan.bi@intel.com>


Thanks,
Dandan
> -----Original Message-----
> From: Samer El-Haj-Mahmoud [mailto:samer@elhajmahmoud.com]
> Sent: Monday, March 23, 2020 12:08 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Wu, Hao A <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard
> Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions
> default for Arm64 platforms
>=20
> Set the default value of PcdAcpiExposedTableVersions for Aarch64 platform=
s
> to 0x20. Previously, the default was set to 0x3E for all platforms. The n=
ew
> value removes ACPI 1.0b compatability, which forces the use of XSDT 64-bi=
t
> pointer, as required by Arm SBBR specification.
> This also resolves an error reported by acpiview command, as seen on the
> RPi (see https://github.com/pftf/RPi4/issues/25).
>=20
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>=20
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..027f444903ef
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1549,6 +1549,9 @@ [PcdsPatchableInModule, PcdsDynamic,
> PcdsDynamicEx]
>    # @Prompt Console Output Row of Text Setup
>=20
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
> 00000e
>=20
> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
> +
> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|
> UINT32|
> +0x0001004c
> +
>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>    ## UART clock frequency is for the baud rate configuration.
>    # @Prompt Serial Port Clock Rate.
> --
> 2.17.1