public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dandan Bi" <dandan.bi@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
	Leif Lindholm <leif@nuviainc.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
Date: Fri, 3 Apr 2020 02:22:05 +0000	[thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40DA5896@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200326102443.748-1-ard.biesheuvel@linaro.org>

For the functionality, it is the same with before for platforms which set PcdPropertiesTableEnable to false by default.
Reviewed-by: Dandan Bi <dandan.bi@intel.com> for patch [PATCH 2/4] [PATCH 3/4] [PATCH 4/4].


If anyone still has the use case of enabling PcdPropertiesTableEnable, please comment.


Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, March 26, 2020 6:25 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
> 
> The EFI properties table is broken by design, deprecated, and seems to be
> causing confusion as it is unclear to some how it differs from the memory
> attributes table (which supersedes it). So let's get rid of the code that
> generates it entirely, along with the GUID definitions, PCDs etc.
> 
> Due to how the two implementations are intertwined, patch #2 makes the
> minimal changes required to stop producing the table (and to allow patch
> #3 to remove the associated definitions from MdePkg). Patch #4 is optional
> and merges the code together.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> 
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633
> 
> Ard Biesheuvel (4):
>   OvmfPkg: remove handling of properties table
>   MdeModulePkg: disable properties table generation but retain the code
>   MdePkg: remove PropertiesTable GUID
>   MdeModulePkg/DxeCore: merge properties table routines into MAT
>     handling
> 
>  MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
>  MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
>  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
>  .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
>  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
>  MdeModulePkg/MdeModulePkg.dec                 |   24 -
>  MdeModulePkg/MdeModulePkg.uni                 |   21 -
>  MdePkg/Include/Guid/PropertiesTable.h         |   31 -
>  MdePkg/MdePkg.dec                             |    3 -
>  OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
>  OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
>  OvmfPkg/OvmfPkgX64.dsc                        |    1 -
>  OvmfPkg/OvmfXen.dsc                           |    1 -
>  OvmfPkg/PlatformPei/Platform.c                |    1 -
>  OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
>  16 files changed, 1222 insertions(+), 1476 deletions(-)  delete mode 100644
> MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
>  delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h
> 
> --
> 2.17.1
> 
> 
> 


  parent reply	other threads:[~2020-04-03  2:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 10:24 [PATCH 0/4] remove generation of EFI properties table Ard Biesheuvel
2020-03-26 10:24 ` [PATCH 1/4] OvmfPkg: remove handling of " Ard Biesheuvel
2020-03-27 14:01   ` [edk2-devel] " Laszlo Ersek
2020-03-26 10:24 ` [PATCH 2/4] MdeModulePkg: disable properties table generation but retain the code Ard Biesheuvel
2020-03-26 10:24 ` [PATCH 3/4] MdePkg: remove PropertiesTable GUID Ard Biesheuvel
2020-03-27  1:02   ` [EXTERNAL] " Bret Barkelew
2020-03-27  9:16     ` Ard Biesheuvel
2020-03-26 10:24 ` [PATCH 4/4] MdeModulePkg/DxeCore: merge properties table routines into MAT handling Ard Biesheuvel
2020-03-27  5:00 ` [PATCH 0/4] remove generation of EFI properties table Yao, Jiewen
2020-03-30 13:42   ` [edk2-devel] " Liming Gao
2020-03-30 17:57     ` Ard Biesheuvel
2020-04-01 17:17       ` Ard Biesheuvel
2020-04-03  2:22 ` Dandan Bi [this message]
2020-04-06 11:42   ` Ard Biesheuvel
2020-04-07  7:27     ` Wang, Jian J
2020-04-07  8:22       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB40DA5896@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox