From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.3425.1585880529771717145 for ; Thu, 02 Apr 2020 19:22:10 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: dandan.bi@intel.com) IronPort-SDR: KfStr/3uPFEHO1Ctl8XS49MqLQ8wvoK/XE56imUzHErd6kvSspneqaV02CKQrduQbp6mIz6r45 LmC6l3cPhvxA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2020 19:22:09 -0700 IronPort-SDR: SJHM0w7NjaKEG5IGzMJUQvOew2FYOxc3MjFuPQtSPzVYpGnNR4ccNIetVD0EhR3j7QuEKrYwfr DiQjHO8l+uew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,337,1580803200"; d="scan'208";a="253217933" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 02 Apr 2020 19:22:08 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Apr 2020 19:22:08 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 2 Apr 2020 19:22:08 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 2 Apr 2020 19:22:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by shsmsx102.ccr.corp.intel.com ([169.254.2.138]) with mapi id 14.03.0439.000; Fri, 3 Apr 2020 10:22:05 +0800 From: "Dandan Bi" To: "devel@edk2.groups.io" , "ard.biesheuvel@linaro.org" CC: Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Ni, Ray" , "Yao, Jiewen" , Bret Barkelew Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table Thread-Topic: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table Thread-Index: AQHWA1jLFD2Mav1AEkKRxol14ZGuuahms6zQ Date: Fri, 3 Apr 2020 02:22:05 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40DA5896@SHSMSX104.ccr.corp.intel.com> References: <20200326102443.748-1-ard.biesheuvel@linaro.org> In-Reply-To: <20200326102443.748-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the functionality, it is the same with before for platforms which set P= cdPropertiesTableEnable to false by default. Reviewed-by: Dandan Bi for patch [PATCH 2/4] [PATCH = 3/4] [PATCH 4/4]. If anyone still has the use case of enabling PcdPropertiesTableEnable, ple= ase comment. Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Thursday, March 26, 2020 6:25 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Leif Lindholm ; Kinney, Michael > D ; Ni, Ray ; Yao, Jiewen > ; Bret Barkelew > Subject: [edk2-devel] [PATCH 0/4] remove generation of EFI properties ta= ble >=20 > The EFI properties table is broken by design, deprecated, and seems to b= e > causing confusion as it is unclear to some how it differs from the memor= y > attributes table (which supersedes it). So let's get rid of the code tha= t > generates it entirely, along with the GUID definitions, PCDs etc. >=20 > Due to how the two implementations are intertwined, patch #2 makes the > minimal changes required to stop producing the table (and to allow patch > #3 to remove the associated definitions from MdePkg). Patch #4 is option= al > and merges the code together. >=20 > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ray Ni > Cc: Jiewen Yao > Cc: Bret Barkelew >=20 > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2633 >=20 > Ard Biesheuvel (4): > OvmfPkg: remove handling of properties table > MdeModulePkg: disable properties table generation but retain the code > MdePkg: remove PropertiesTable GUID > MdeModulePkg/DxeCore: merge properties table routines into MAT > handling >=20 > MdeModulePkg/Core/Dxe/DxeMain.h | 9 - > MdeModulePkg/Core/Dxe/DxeMain.inf | 3 - > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 1 - > .../Core/Dxe/Misc/MemoryAttributesTable.c | 1226 ++++++++++++++- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 1 - > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1373 ----------------- > MdeModulePkg/MdeModulePkg.dec | 24 - > MdeModulePkg/MdeModulePkg.uni | 21 - > MdePkg/Include/Guid/PropertiesTable.h | 31 - > MdePkg/MdePkg.dec | 3 - > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/OvmfXen.dsc | 1 - > OvmfPkg/PlatformPei/Platform.c | 1 - > OvmfPkg/PlatformPei/PlatformPei.inf | 1 - > 16 files changed, 1222 insertions(+), 1476 deletions(-) delete mode 10= 0644 > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c > delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h >=20 > -- > 2.17.1 >=20 >=20 >=20