[edk2][PATCH v2 0/2] ACPI table defailt for Aarch64

[edk2][PATCH v2 0/2] ACPI table defailt for Aarch64

[Samer El-Haj-Mahmoud]

Set the default value of PcdAcpiExposedTableVersions for Aarch64
platforms to 0x20 to indicate ACPI 5.0.

Samer El-Haj-Mahmoud (2):
  MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms
  Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher"

 MdeModulePkg/MdeModulePkg.dec | 3 +++
 ArmVirtPkg/ArmVirtQemu.dsc    | 4 ----
 2 files changed, 3 insertions(+), 4 deletions(-)

-- 
2.17.1

[edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Samer El-Haj-Mahmoud]

Set the default value of PcdAcpiExposedTableVersions for Aarch64
platforms to 0x20. Previously, the default was set to 0x3E for all
platforms. The new value removes ACPI 1.0b compatability, which forces
the use of XSDT 64-bit pointer, as required by Arm SBBR specification.
This also resolves an error reported by acpiview command, as seen on
the RPi (see https://github.com/pftf/RPi4/issues/25).

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/MdeModulePkg.dec | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 497574cb0870..fac16f262cf8 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1548,6 +1548,9 @@
   # @Prompt Console Output Row of Text Setup
   gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e
 
+[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
+  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT32|0x0001004c
+
 [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
   ## UART clock frequency is for the baud rate configuration.
   # @Prompt Serial Port Clock Rate.
-- 
2.17.1

[edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher"

[Samer El-Haj-Mahmoud]

This reverts commit e0692789058ee2c0099f88852503c16dbb0bae4e.

The default value for PcdAcpiExposedTableVersions is now set to 0x20
for Aarch64 systems. Setting this PCD in ArmVirtPkg/ArmVirtQemu.dsc
is no longer necessary.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 ArmVirtPkg/ArmVirtQemu.dsc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index 5a210a0bac72..1233f1ece484 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -209,10 +209,6 @@
   # point only, for entry point versions >= 3.0.
   gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2
 
-  # ACPI predates the AARCH64 architecture by 5 versions, so
-  # we only target OSes that support ACPI v5.0 or later
-  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
-
 [PcdsDynamicDefault.common]
   gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
 
-- 
2.17.1

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 78 bytes --]

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 100 bytes --]

Re: [edk2-devel] [edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher"

[Laszlo Ersek]

On 04/10/20 17:29, Samer El-Haj-Mahmoud wrote:
> This reverts commit e0692789058ee2c0099f88852503c16dbb0bae4e.
> 
> The default value for PcdAcpiExposedTableVersions is now set to 0x20
> for Aarch64 systems. Setting this PCD in ArmVirtPkg/ArmVirtQemu.dsc
> is no longer necessary.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/ArmVirtQemu.dsc | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 5a210a0bac72..1233f1ece484 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -209,10 +209,6 @@
>    # point only, for entry point versions >= 3.0.
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2
>  
> -  # ACPI predates the AARCH64 architecture by 5 versions, so
> -  # we only target OSes that support ACPI v5.0 or later
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
> -
>  [PcdsDynamicDefault.common]
>    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Samer El-Haj-Mahmoud]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Thanks Sami for the review

Jian,

Can we get this patch pushed please? It has been reviewed by Sami, Ard, and Dandan.

Thanks,
--Samer

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami Mujawar via groups.io
Sent: Tuesday, April 14, 2020 5:45 AM
To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>

Regards,

Sami Mujawar


[-- Attachment #2: Type: text/html, Size: 3090 bytes --]

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Samer El-Haj-Mahmoud]

Jian, Hao,

Can you please push this simple patch? It has been reviewed a while ago and ready to be committed.

Thanks,
--Samer

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-
> Haj-Mahmoud via groups.io
> Sent: Friday, April 10, 2020 11:29 AM
> To: devel@edk2.groups.io
> Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao <liming.gao@intel.com>;
> Jian J Wang <jian.j.wang@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif
> Lindholm <leif@nuviainc.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>
> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
> PcdAcpiExposedTableVersions default for Arm64 platforms
> 
> Set the default value of PcdAcpiExposedTableVersions for Aarch64 platforms to
> 0x20. Previously, the default was set to 0x3E for all platforms. The new value
> removes ACPI 1.0b compatability, which forces the use of XSDT 64-bit pointer,
> as required by Arm SBBR specification.
> This also resolves an error reported by acpiview command, as seen on the RPi
> (see https://github.com/pftf/RPi4/issues/25).
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 497574cb0870..fac16f262cf8
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1548,6 +1548,9 @@
>    # @Prompt Console Output Row of Text Setup
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40000
> 00e
> 
> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
> +
> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT
> 32|
> +0x0001004c
> +
>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>    ## UART clock frequency is for the baud rate configuration.
>    # @Prompt Serial Port Clock Rate.
> --
> 2.17.1
> 
> 
> 

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Laszlo Ersek]

Dandan,

On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote:
> Jian, Hao,
> 
> Can you please push this simple patch? It has been reviewed a while ago and ready to be committed.

should we consider your R-b on the first patch sufficient for pushing?

You are marked as "R" for "MdeModulePkg: ACPI modules", but technically
speaking, "MdeModulePkg.dec" needs an ACK from either Jian or Hao.

Content-wise, your approval looks sufficient, but I don't want to
assume. Please confirm.

Thank
Laszlo

>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-
>> Haj-Mahmoud via groups.io
>> Sent: Friday, April 10, 2020 11:29 AM
>> To: devel@edk2.groups.io
>> Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao <liming.gao@intel.com>;
>> Jian J Wang <jian.j.wang@intel.com>; Hao A Wu <hao.a.wu@intel.com>; Leif
>> Lindholm <leif@nuviainc.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>
>> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
>> PcdAcpiExposedTableVersions default for Arm64 platforms
>>
>> Set the default value of PcdAcpiExposedTableVersions for Aarch64 platforms to
>> 0x20. Previously, the default was set to 0x3E for all platforms. The new value
>> removes ACPI 1.0b compatability, which forces the use of XSDT 64-bit pointer,
>> as required by Arm SBBR specification.
>> This also resolves an error reported by acpiview command, as seen on the RPi
>> (see https://github.com/pftf/RPi4/issues/25).
>>
>> Cc: Dandan Bi <dandan.bi@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>
>> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>> ---
>>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/MdeModulePkg/MdeModulePkg.dec
>> b/MdeModulePkg/MdeModulePkg.dec index 497574cb0870..fac16f262cf8
>> 100644
>> --- a/MdeModulePkg/MdeModulePkg.dec
>> +++ b/MdeModulePkg/MdeModulePkg.dec
>> @@ -1548,6 +1548,9 @@
>>    # @Prompt Console Output Row of Text Setup
>>
>> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40000
>> 00e
>>
>> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
>> +
>> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT
>> 32|
>> +0x0001004c
>> +
>>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>>    ## UART clock frequency is for the baud rate configuration.
>>    # @Prompt Serial Port Clock Rate.
>> --
>> 2.17.1
>>
>>
>>
> 
> 
> 
> 

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Dandan Bi]

Hi Laszlo,

I think it should be Ok.
But if can get ACK/R-B from the maintainer of MdeModulePkg, that would be better, which follows process more.


Thanks,
Dandan
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, April 20, 2020 8:15 PM
> To: Bi, Dandan <dandan.bi@intel.com>
> Cc: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
> <Ard.Biesheuvel@arm.com>; nd <nd@arm.com>;
> samer@elhajmahmoud.com
> Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
> PcdAcpiExposedTableVersions default for Arm64 platforms
> 
> Dandan,
> 
> On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote:
> > Jian, Hao,
> >
> > Can you please push this simple patch? It has been reviewed a while ago
> and ready to be committed.
> 
> should we consider your R-b on the first patch sufficient for pushing?
> 
> You are marked as "R" for "MdeModulePkg: ACPI modules", but technically
> speaking, "MdeModulePkg.dec" needs an ACK from either Jian or Hao.
> 
> Content-wise, your approval looks sufficient, but I don't want to assume.
> Please confirm.
> 
> Thank
> Laszlo
> 
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Samer
> >> El- Haj-Mahmoud via groups.io
> >> Sent: Friday, April 10, 2020 11:29 AM
> >> To: devel@edk2.groups.io
> >> Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao
> >> <liming.gao@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A Wu
> >> <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard
> >> Biesheuvel <Ard.Biesheuvel@arm.com>
> >> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
> >> PcdAcpiExposedTableVersions default for Arm64 platforms
> >>
> >> Set the default value of PcdAcpiExposedTableVersions for Aarch64
> >> platforms to 0x20. Previously, the default was set to 0x3E for all
> >> platforms. The new value removes ACPI 1.0b compatability, which
> >> forces the use of XSDT 64-bit pointer, as required by Arm SBBR
> specification.
> >> This also resolves an error reported by acpiview command, as seen on
> >> the RPi (see https://github.com/pftf/RPi4/issues/25).
> >>
> >> Cc: Dandan Bi <dandan.bi@intel.com>
> >> Cc: Liming Gao <liming.gao@intel.com>
> >> Cc: Jian J Wang <jian.j.wang@intel.com>
> >> Cc: Hao A Wu <hao.a.wu@intel.com>
> >> Cc: Leif Lindholm <leif@nuviainc.com>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >>
> >> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> >> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
> >> ---
> >>  MdeModulePkg/MdeModulePkg.dec | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/MdeModulePkg/MdeModulePkg.dec
> >> b/MdeModulePkg/MdeModulePkg.dec index
> 497574cb0870..fac16f262cf8
> >> 100644
> >> --- a/MdeModulePkg/MdeModulePkg.dec
> >> +++ b/MdeModulePkg/MdeModulePkg.dec
> >> @@ -1548,6 +1548,9 @@
> >>    # @Prompt Console Output Row of Text Setup
> >>
> >>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
> 000
> >> 00e
> >>
> >> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
> >> +
> >>
> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|
> UINT
> >> 32|
> >> +0x0001004c
> >> +
> >>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
> PcdsDynamicEx]
> >>    ## UART clock frequency is for the baud rate configuration.
> >>    # @Prompt Serial Port Clock Rate.
> >> --
> >> 2.17.1
> >>
> >>
> >>
> >
> >
> > 
> >

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Laszlo Ersek]

On 04/21/20 06:56, Bi, Dandan wrote:
> Hi Laszlo,
> 
> I think it should be Ok.
> But if can get ACK/R-B from the maintainer of MdeModulePkg, that would be better, which follows process more.

Yes, I agree, but Jian and Hao are not responding. Could you poke them
internally at Intel, please?

Thanks
Laszlo

> 
> 
> Thanks,
> Dandan
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Monday, April 20, 2020 8:15 PM
>> To: Bi, Dandan <dandan.bi@intel.com>
>> Cc: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com; Wang, Jian J
>> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming
>> <liming.gao@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
>> <Ard.Biesheuvel@arm.com>; nd <nd@arm.com>;
>> samer@elhajmahmoud.com
>> Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
>> PcdAcpiExposedTableVersions default for Arm64 platforms
>>
>> Dandan,
>>
>> On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote:
>>> Jian, Hao,
>>>
>>> Can you please push this simple patch? It has been reviewed a while ago
>> and ready to be committed.
>>
>> should we consider your R-b on the first patch sufficient for pushing?
>>
>> You are marked as "R" for "MdeModulePkg: ACPI modules", but technically
>> speaking, "MdeModulePkg.dec" needs an ACK from either Jian or Hao.
>>
>> Content-wise, your approval looks sufficient, but I don't want to assume.
>> Please confirm.
>>
>> Thank
>> Laszlo
>>
>>>> -----Original Message-----
>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>> Samer
>>>> El- Haj-Mahmoud via groups.io
>>>> Sent: Friday, April 10, 2020 11:29 AM
>>>> To: devel@edk2.groups.io
>>>> Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao
>>>> <liming.gao@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A Wu
>>>> <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard
>>>> Biesheuvel <Ard.Biesheuvel@arm.com>
>>>> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
>>>> PcdAcpiExposedTableVersions default for Arm64 platforms
>>>>
>>>> Set the default value of PcdAcpiExposedTableVersions for Aarch64
>>>> platforms to 0x20. Previously, the default was set to 0x3E for all
>>>> platforms. The new value removes ACPI 1.0b compatability, which
>>>> forces the use of XSDT 64-bit pointer, as required by Arm SBBR
>> specification.
>>>> This also resolves an error reported by acpiview command, as seen on
>>>> the RPi (see https://github.com/pftf/RPi4/issues/25).
>>>>
>>>> Cc: Dandan Bi <dandan.bi@intel.com>
>>>> Cc: Liming Gao <liming.gao@intel.com>
>>>> Cc: Jian J Wang <jian.j.wang@intel.com>
>>>> Cc: Hao A Wu <hao.a.wu@intel.com>
>>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>>>
>>>> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
>>>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>>>> ---
>>>>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/MdeModulePkg/MdeModulePkg.dec
>>>> b/MdeModulePkg/MdeModulePkg.dec index
>> 497574cb0870..fac16f262cf8
>>>> 100644
>>>> --- a/MdeModulePkg/MdeModulePkg.dec
>>>> +++ b/MdeModulePkg/MdeModulePkg.dec
>>>> @@ -1548,6 +1548,9 @@
>>>>    # @Prompt Console Output Row of Text Setup
>>>>
>>>>
>> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
>> 000
>>>> 00e
>>>>
>>>> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
>>>> +
>>>>
>> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|
>> UINT
>>>> 32|
>>>> +0x0001004c
>>>> +
>>>>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
>> PcdsDynamicEx]
>>>>    ## UART clock frequency is for the baud rate configuration.
>>>>    # @Prompt Serial Port Clock Rate.
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>>>
>>>
>>>
>>> 
>>>
> 

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Liming Gao]

Laszlo:
  I understand Module reviewer R-B is enough for the patch.

  R: Package Reviewer: Cc address for patches and questions. Reviewers help
     maintainers review code, but don't have push access. A designated Package
     Reviewer is reasonably familiar with the Package (or some modules
     thereof), and/or provides testing or regression testing for the Package
     (or some modules thereof), in certain platforms and environments.

Thanks
Liming
-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com> 
Sent: 2020年4月21日 16:42
To: Bi, Dandan <dandan.bi@intel.com>
Cc: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; nd <nd@arm.com>; samer@elhajmahmoud.com
Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

On 04/21/20 06:56, Bi, Dandan wrote:
> Hi Laszlo,
> 
> I think it should be Ok.
> But if can get ACK/R-B from the maintainer of MdeModulePkg, that would be better, which follows process more.

Yes, I agree, but Jian and Hao are not responding. Could you poke them internally at Intel, please?

Thanks
Laszlo

> 
> 
> Thanks,
> Dandan
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Monday, April 20, 2020 8:15 PM
>> To: Bi, Dandan <dandan.bi@intel.com>
>> Cc: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com; Wang, Jian J 
>> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming 
>> <liming.gao@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard 
>> Biesheuvel <Ard.Biesheuvel@arm.com>; nd <nd@arm.com>; 
>> samer@elhajmahmoud.com
>> Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
>> PcdAcpiExposedTableVersions default for Arm64 platforms
>>
>> Dandan,
>>
>> On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote:
>>> Jian, Hao,
>>>
>>> Can you please push this simple patch? It has been reviewed a while 
>>> ago
>> and ready to be committed.
>>
>> should we consider your R-b on the first patch sufficient for pushing?
>>
>> You are marked as "R" for "MdeModulePkg: ACPI modules", but 
>> technically speaking, "MdeModulePkg.dec" needs an ACK from either Jian or Hao.
>>
>> Content-wise, your approval looks sufficient, but I don't want to assume.
>> Please confirm.
>>
>> Thank
>> Laszlo
>>
>>>> -----Original Message-----
>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>> Samer
>>>> El- Haj-Mahmoud via groups.io
>>>> Sent: Friday, April 10, 2020 11:29 AM
>>>> To: devel@edk2.groups.io
>>>> Cc: Dandan Bi <dandan.bi@intel.com>; Liming Gao 
>>>> <liming.gao@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Hao A 
>>>> Wu <hao.a.wu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard 
>>>> Biesheuvel <Ard.Biesheuvel@arm.com>
>>>> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg:
>>>> PcdAcpiExposedTableVersions default for Arm64 platforms
>>>>
>>>> Set the default value of PcdAcpiExposedTableVersions for Aarch64 
>>>> platforms to 0x20. Previously, the default was set to 0x3E for all 
>>>> platforms. The new value removes ACPI 1.0b compatability, which 
>>>> forces the use of XSDT 64-bit pointer, as required by Arm SBBR
>> specification.
>>>> This also resolves an error reported by acpiview command, as seen 
>>>> on the RPi (see https://github.com/pftf/RPi4/issues/25).
>>>>
>>>> Cc: Dandan Bi <dandan.bi@intel.com>
>>>> Cc: Liming Gao <liming.gao@intel.com>
>>>> Cc: Jian J Wang <jian.j.wang@intel.com>
>>>> Cc: Hao A Wu <hao.a.wu@intel.com>
>>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>>>
>>>> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
>>>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>>>> ---
>>>>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/MdeModulePkg/MdeModulePkg.dec 
>>>> b/MdeModulePkg/MdeModulePkg.dec index
>> 497574cb0870..fac16f262cf8
>>>> 100644
>>>> --- a/MdeModulePkg/MdeModulePkg.dec
>>>> +++ b/MdeModulePkg/MdeModulePkg.dec
>>>> @@ -1548,6 +1548,9 @@
>>>>    # @Prompt Console Output Row of Text Setup
>>>>
>>>>
>> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
>> 000
>>>> 00e
>>>>
>>>> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
>>>> +
>>>>
>> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|
>> UINT
>>>> 32|
>>>> +0x0001004c
>>>> +
>>>>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
>> PcdsDynamicEx]
>>>>    ## UART clock frequency is for the baud rate configuration.
>>>>    # @Prompt Serial Port Clock Rate.
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>>>
>>>
>>>
>>> 
>>>
> 

Re: [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Wu, Hao A]

> -----Original Message-----
> From: Samer El-Haj-Mahmoud [mailto:samer@elhajmahmoud.com]
> Sent: Friday, April 10, 2020 11:29 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Gao, Liming; Wang, Jian J; Wu, Hao A; Leif Lindholm; Ard
> Biesheuvel
> Subject: [edk2][PATCH v2 1/2] MdeModulePkg:
> PcdAcpiExposedTableVersions default for Arm64 platforms
> 
> Set the default value of PcdAcpiExposedTableVersions for Aarch64
> platforms to 0x20. Previously, the default was set to 0x3E for all
> platforms. The new value removes ACPI 1.0b compatability, which forces
> the use of XSDT 64-bit pointer, as required by Arm SBBR specification.
> This also resolves an error reported by acpiview command, as seen on
> the RPi (see https://github.com/pftf/RPi4/issues/25).
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 497574cb0870..fac16f262cf8 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1548,6 +1548,9 @@
>    # @Prompt Console Output Row of Text Setup
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
> 00000e
> 
> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UI
> NT32|0x0001004c
> +


Sorry for the slow response.
Acked-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>  [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>    ## UART clock frequency is for the baud rate configuration.
>    # @Prompt Serial Port Clock Rate.
> --
> 2.17.1

Re: [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

[Ard Biesheuvel]

On 4/21/20 10:54 AM, Wu, Hao A wrote:
>> -----Original Message-----
>> From: Samer El-Haj-Mahmoud [mailto:samer@elhajmahmoud.com]
>> Sent: Friday, April 10, 2020 11:29 PM
>> To: devel@edk2.groups.io
>> Cc: Bi, Dandan; Gao, Liming; Wang, Jian J; Wu, Hao A; Leif Lindholm; Ard
>> Biesheuvel
>> Subject: [edk2][PATCH v2 1/2] MdeModulePkg:
>> PcdAcpiExposedTableVersions default for Arm64 platforms
>>
>> Set the default value of PcdAcpiExposedTableVersions for Aarch64
>> platforms to 0x20. Previously, the default was set to 0x3E for all
>> platforms. The new value removes ACPI 1.0b compatability, which forces
>> the use of XSDT 64-bit pointer, as required by Arm SBBR specification.
>> This also resolves an error reported by acpiview command, as seen on
>> the RPi (see https://github.com/pftf/RPi4/issues/25).
>>
>> Cc: Dandan Bi <dandan.bi@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>
>> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>> ---
>>   MdeModulePkg/MdeModulePkg.dec | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/MdeModulePkg/MdeModulePkg.dec
>> b/MdeModulePkg/MdeModulePkg.dec
>> index 497574cb0870..fac16f262cf8 100644
>> --- a/MdeModulePkg/MdeModulePkg.dec
>> +++ b/MdeModulePkg/MdeModulePkg.dec
>> @@ -1548,6 +1548,9 @@
>>     # @Prompt Console Output Row of Text Setup
>>
>> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
>> 00000e
>>
>> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
>> +
>> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UI
>> NT32|0x0001004c
>> +
> 
> 
> Sorry for the slow response.
> Acked-by: Hao A Wu <hao.a.wu@intel.com>
> 

Series pushed and merged as #535

Thanks all