From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.3211.1587444986734430873 for ; Mon, 20 Apr 2020 21:56:26 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: dandan.bi@intel.com) IronPort-SDR: oGXUSqu9DcBJmWol3p4cCPFsnnrL76qvxbGo0GIrTao1TgpOIxk2A8euIeiT8fXxAfOhlvJAbf jVE5nOgltKrw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 21:56:25 -0700 IronPort-SDR: ixTuRYjAxV5khOrwBvCUGlYF/Zl+rWS+A3IasHY2iTskA5DtcEdVA4MGbQzYbktswjYXL6SEu+ K7zNbGkAMlrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,409,1580803200"; d="scan'208";a="334155797" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 20 Apr 2020 21:56:25 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 21:56:25 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Apr 2020 21:56:24 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.89]) with mapi id 14.03.0439.000; Tue, 21 Apr 2020 12:56:22 +0800 From: "Dandan Bi" To: Laszlo Ersek CC: "devel@edk2.groups.io" , "samer.el-haj-mahmoud@arm.com" , "Wang, Jian J" , "Wu, Hao A" , "Gao, Liming" , Leif Lindholm , Ard Biesheuvel , nd , "samer@elhajmahmoud.com" Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Thread-Topic: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Thread-Index: AQHWD0zXbzecrjJsY0WRwJ+cjD9UX6h+g06AgALyqgCAAZz6QA== Date: Tue, 21 Apr 2020 04:56:21 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40DC74D1@SHSMSX104.ccr.corp.intel.com> References: <20200410152925.6119-1-samer@elhajmahmoud.com> <20200410152925.6119-2-samer@elhajmahmoud.com> <08951bf6-9efc-dc7c-ab2c-2c1ccda756a2@redhat.com> In-Reply-To: <08951bf6-9efc-dc7c-ab2c-2c1ccda756a2@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, I think it should be Ok. But if can get ACK/R-B from the maintainer of MdeModulePkg, that would be = better, which follows process more. Thanks, Dandan > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Monday, April 20, 2020 8:15 PM > To: Bi, Dandan > Cc: devel@edk2.groups.io; samer.el-haj-mahmoud@arm.com; Wang, Jian J > ; Wu, Hao A ; Gao, Liming > ; Leif Lindholm ; Ard Biesheuve= l > ; nd ; > samer@elhajmahmoud.com > Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: > PcdAcpiExposedTableVersions default for Arm64 platforms >=20 > Dandan, >=20 > On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote: > > Jian, Hao, > > > > Can you please push this simple patch? It has been reviewed a while ag= o > and ready to be committed. >=20 > should we consider your R-b on the first patch sufficient for pushing? >=20 > You are marked as "R" for "MdeModulePkg: ACPI modules", but technically > speaking, "MdeModulePkg.dec" needs an ACK from either Jian or Hao. >=20 > Content-wise, your approval looks sufficient, but I don't want to assume= . > Please confirm. >=20 > Thank > Laszlo >=20 > >> -----Original Message----- > >> From: devel@edk2.groups.io On Behalf Of > Samer > >> El- Haj-Mahmoud via groups.io > >> Sent: Friday, April 10, 2020 11:29 AM > >> To: devel@edk2.groups.io > >> Cc: Dandan Bi ; Liming Gao > >> ; Jian J Wang ; Hao A Wu > >> ; Leif Lindholm ; Ard > >> Biesheuvel > >> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: > >> PcdAcpiExposedTableVersions default for Arm64 platforms > >> > >> Set the default value of PcdAcpiExposedTableVersions for Aarch64 > >> platforms to 0x20. Previously, the default was set to 0x3E for all > >> platforms. The new value removes ACPI 1.0b compatability, which > >> forces the use of XSDT 64-bit pointer, as required by Arm SBBR > specification. > >> This also resolves an error reported by acpiview command, as seen on > >> the RPi (see https://github.com/pftf/RPi4/issues/25). > >> > >> Cc: Dandan Bi > >> Cc: Liming Gao > >> Cc: Jian J Wang > >> Cc: Hao A Wu > >> Cc: Leif Lindholm > >> Cc: Ard Biesheuvel > >> > >> Signed-off-by: Samer El-Haj-Mahmoud > >> Reviewed-by: Ard Biesheuvel > >> Reviewed-by: Dandan Bi > >> --- > >> MdeModulePkg/MdeModulePkg.dec | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/MdeModulePkg/MdeModulePkg.dec > >> b/MdeModulePkg/MdeModulePkg.dec index > 497574cb0870..fac16f262cf8 > >> 100644 > >> --- a/MdeModulePkg/MdeModulePkg.dec > >> +++ b/MdeModulePkg/MdeModulePkg.dec > >> @@ -1548,6 +1548,9 @@ > >> # @Prompt Console Output Row of Text Setup > >> > >> > gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40 > 000 > >> 00e > >> > >> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] > >> + > >> > +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20| > UINT > >> 32| > >> +0x0001004c > >> + > >> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, > PcdsDynamicEx] > >> ## UART clock frequency is for the baud rate configuration. > >> # @Prompt Serial Port Clock Rate. > >> -- > >> 2.17.1 > >> > >> > >> > > > > > >=20 > >