From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=chasel.chiu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D53C226C7C55 for ; Sun, 8 Apr 2018 18:37:28 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2018 18:37:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,426,1517904000"; d="scan'208";a="49115592" Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106]) by orsmga002.jf.intel.com with ESMTP; 08 Apr 2018 18:37:27 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.233]) by KMSMSX155.gar.corp.intel.com ([169.254.15.13]) with mapi id 14.03.0319.002; Mon, 9 Apr 2018 09:37:17 +0800 From: "Chiu, Chasel" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Chan, Amy" , "Chaganty, Rangasai V" Thread-Topic: [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO Thread-Index: AQHTy/Bphup11FMzC0mk6g0+jhvhOqP3rjMw Date: Mon, 9 Apr 2018 01:37:16 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC4FFF57AC@PGSMSX111.gar.corp.intel.com> References: <1522831140-77944-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1522831140-77944-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTNhNzkyZDItY2JhYS00NDgyLTg1OGUtYjAzYmU1YTJhZjAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIwZ3JsWEVYZzJuSHk5THhNYVV4aDg1cGRMcnI5WWhpejNZeXFrRUlvUUZUaHBNTXFMOGs2akhKNnpyc1l3MzJhIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Subject: Re: [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level to DEBUG_INFO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 01:37:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks! Reviewed-by: Chasel Chiu -----Original Message----- From: Zeng, Star=20 Sent: Wednesday, April 4, 2018 4:39 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Yao, Jiewen ; C= hiu, Chasel ; Chan, Amy ; Chagan= ty, Rangasai V Subject: [PATCH] SignedCapsulePkg SystemCapsuleLib: Change some dbg level t= o DEBUG_INFO This debug message should be info instead of error. This patch is to change= the debug level to DEBUG_INFO. DEBUG((DEBUG_ERROR, "checking FV....0x%08x - 0x%x\n", FvHeader, FvHeader->FvLength)); // "Mark" This comment is inaccurate. This patch is to remove it. // // Check section // This debug message should be removed as FvHeader may have been out of range= FdStart and FdSize, and the loop will go to "Mark" above again if FvHeader= is not out of range FdStart and FdSize, and then that debug message will b= e shown. This patch is to remove this debug message. DEBUG((DEBUG_ERROR, "Next FV....0x%08x - 0x%x\n", FvHeader, FvHeader->FvLength)); Cc: Jiewen Yao Cc: Chasel Chiu Cc: Amy Chan Cc: Rangasai V Chaganty Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- .../Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c | 8 ++--= ---- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCaps= uleLib.c b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsul= eLib.c index 876d2257b365..5cb97bf93118 100644 --- a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.= c +++ b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleL +++ ib.c @@ -6,7 +6,7 @@ CapsuleAuthenticateSystemFirmware(), ExtractAuthenticatedImage() will re= ceive untrusted input and do basic validation. =20 - Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2016 - 2018, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -188,7 +188,7 @@ GetFfsByName ( FvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)((UINTN)FvHeader + SIZE_4= KB); continue; } - DEBUG((DEBUG_ERROR, "checking FV....0x%08x - 0x%x\n", FvHeader, FvHead= er->FvLength)); + DEBUG((DEBUG_INFO, "checking FV....0x%08x - 0x%x\n", FvHeader,=20 + FvHeader->FvLength)); FvFound =3D TRUE; if (FvHeader->FvLength > FvSize) { DEBUG((DEBUG_ERROR, "GetFfsByName - FvSize: 0x%08x, MaxSize - 0x%08x= \n", (UINTN)FvHeader->FvLength, (UINTN)FvSize)); @@ -225,9 +225,6 @@ GetFfs= ByName ( =20 if (CompareGuid(FileName, &FfsHeader->Name) && ((Type =3D=3D EFI_FV_FILETYPE_ALL) || (FfsHeader->Type =3D=3D Ty= pe))) { - // - // Check section - // *OutFfsBuffer =3D FfsHeader; *OutFfsBufferSize =3D FfsSize; return TRUE; @@ -248,7 +245,6 @@ GetFfsByName ( // Next FV // FvHeader =3D (VOID *)(UINTN)((UINTN)FvHeader + FvHeader->FvLength); - DEBUG((DEBUG_ERROR, "Next FV....0x%08x - 0x%x\n", FvHeader, FvHeader->= FvLength)); } =20 if (!FvFound) { -- 2.7.0.windows.1