From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=chasel.chiu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D1A7B210F30B2 for ; Wed, 15 Aug 2018 23:33:01 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2018 23:33:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,246,1531810800"; d="scan'208";a="65589607" Received: from kmsmsx156.gar.corp.intel.com ([172.21.138.133]) by orsmga008.jf.intel.com with ESMTP; 15 Aug 2018 23:32:52 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.229]) by KMSMSX156.gar.corp.intel.com ([169.254.1.252]) with mapi id 14.03.0319.002; Thu, 16 Aug 2018 14:32:51 +0800 From: "Chiu, Chasel" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" Thread-Topic: [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs Thread-Index: AQHUNSKPUgcOmI2VI0KobPwF0wA39qTB61hA Date: Thu, 16 Aug 2018 06:32:50 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5014ADF0@PGSMSX111.gar.corp.intel.com> References: <20180816053225.22356-1-shenglei.zhang@intel.com> <20180816053225.22356-3-shenglei.zhang@intel.com> In-Reply-To: <20180816053225.22356-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjQ3ZDM2ZTItMWFiYS00YTQ1LWExMjUtNWQ3NTY0MzE1ZjdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUNySWRoOFc2NUNyYVNCcFF1NXZObkY1NDhJdzV4eGZxRlU1bjdidGRTVWFhQVpEbmlOZ09cL2VrNng5bHBMMWYifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Subject: Re: [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 06:33:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu -----Original Message----- From: Zhang, Shenglei=20 Sent: Thursday, August 16, 2018 1:32 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chiu, Chasel Subject: [PATCH 2/5] IntelFsp2Pkg: Remove unused PCDs The PCDs below are unused, so they have been removed from inf. gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize Cc: Jiewen Yao Cc: Chasel Chiu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 6 ------ IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 11 ----------- IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf | 5 ----- .../Library/BaseFspCommonLib/BaseFspCommonLib.inf | 5 ----- .../Library/BaseFspPlatformLib/BaseFspPlatformLib.inf | 9 --------- .../BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf | 4 ---- .../FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf | 1 - .../BaseFspWrapperPlatformLibSample.inf | 3 --- 8 files changed, 44 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf b/IntelFsp2Pkg/FspSecC= ore/FspSecCoreM.inf index 0500a197f8..c657862deb 100644 --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf @@ -58,17 +58,11 @@ FspSecPlatformLib =20 [Pcd] - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress ## UNDEFINED - gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## CONSUMES gIntelFsp2PkgTokenSpaceGuid.PcdFspHeapSizePercentage ## CONSUMES =20 -[FixedPcd] - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES - [Ppis] gEfiTemporaryRamSupportPpiGuid ## PRODUCES =20 diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf b/IntelFsp2Pkg/FspSecC= ore/FspSecCoreS.inf index a3563dd8cf..dd3f8e56a0 100644 --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf @@ -52,17 +52,6 @@ FspCommonLib FspSecPlatformLib =20 -[Pcd] - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress ## UNDEFINED - gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## CONSUMES - -[FixedPcd] - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES - [Ppis] gEfiTemporaryRamSupportPpiGuid ## PRODUCES =20 diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf b/IntelFsp2Pkg/FspSecC= ore/FspSecCoreT.inf index cf6a1918a3..aff4b23f88 100644 --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf @@ -53,14 +53,9 @@ FspSecPlatformLib =20 [Pcd] - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress ## UNDEFINED gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES gIntelFsp2PkgTokenSpaceGuid.PcdFspReservedBufferSize ## CONSUMES =20 -[FixedPcd] - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES - [Ppis] gEfiTemporaryRamSupportPpiGuid ## PRODUCES diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf b/I= ntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf index c9d98357e2..ff82f8040b 100644 --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/BaseFspCommonLib.inf @@ -33,8 +33,3 @@ [Pcd] gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES =20 -[FixedPcd] - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES diff --git a/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf= b/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf index 907482daed..b9e8a61809 100644 --- a/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf +++ b/IntelFsp2Pkg/Library/BaseFspPlatformLib/BaseFspPlatformLib.inf @@ -35,12 +35,6 @@ PerformanceLib ReportStatusCodeLib =20 -[Pcd] - gIntelFsp2PkgTokenSpaceGuid.PcdGlobalDataPointerAddress ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## CONSUMES - [Guids] gFspPerformanceDataGuid ## CONSUMES ##= GUID gFspEventEndOfFirmwareGuid ## PRODUCES ##= GUID @@ -49,6 +43,3 @@ [Protocols] gEfiPciEnumerationCompleteProtocolGuid ## CONSUMES =20 -[FixedPcd] - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES diff --git a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackL= ib.inf b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.i= nf index b3c673a0ac..97cf3caa6a 100644 --- a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf +++ b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/BaseFspSwitchStackLib.inf @@ -34,9 +34,5 @@ BaseLib IoLib =20 -[FixedPcd] - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPatchEntry ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdFspMaxPerfEntry ## CONSUMES - =20 =20 diff --git a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.in= f b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf index ce3bfa0c75..011cf89d3f 100644 --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf @@ -61,7 +61,6 @@ gFspHobGuid ## CONSUMES ## HOB =20 [Pcd] - gIntelFsp2WrapperTokenSpaceGuid.PcdFspsBaseAddress ## CONSUMES gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi ## CONSUMES =20 [Depex] diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/Ba= seFspWrapperPlatformLibSample.inf b/IntelFsp2WrapperPkg/Library/BaseFspWrap= perPlatformLibSample/BaseFspWrapperPlatformLibSample.inf index f9581e8456..3bc024459f 100644 --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWr= apperPlatformLibSample.inf +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWr= apperPlatformLibSample.inf @@ -55,6 +55,3 @@ =20 [LibraryClasses] =20 -[Pcd] - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase ## CONSUMES - gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize ## CONSUMES --=20 2.18.0.windows.1