public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs
Date: Tue, 28 Aug 2018 05:30:25 +0000	[thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5015ED7C@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <20180828034257.19060-7-shenglei.zhang@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

-----Original Message-----
From: Zhang, Shenglei 
Sent: Tuesday, August 28, 2018 11:43 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs

The PCDs below are unused, so they have been removed from inf.
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase
gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
 .../BaseFspWrapperPlatformLibSample.inf                        | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
index f9581e8456..3bc024459f 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformLibSample/BaseFspWrapperPlatformLibSample.inf
@@ -55,6 +55,3 @@
 
 [LibraryClasses]
 
-[Pcd]
-  gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamBase  ## CONSUMES
-  gIntelFsp2PkgTokenSpaceGuid.PcdTemporaryRamSize  ## CONSUMES
-- 
2.18.0.windows.1



  reply	other threads:[~2018-08-28  5:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28  3:42 [PATCH v3 00/16] Removed unused PCDs shenglei
2018-08-28  3:42 ` [PATCH v3 01/16] IntelFsp2Pkg/FspSecCore: Remove " shenglei
2018-08-28  3:42 ` [PATCH v3 02/16] IntelFsp2Pkg/BaseFspCommonLib: " shenglei
2018-08-28  3:42 ` [PATCH v3 03/16] IntelFsp2Pkg/BaseFspPlatformLib: " shenglei
2018-08-28  3:42 ` [PATCH v3 04/16] IntelFsp2Pkg/BaseFspSwitchStackLib: " shenglei
2018-08-28  3:42 ` [PATCH v3 05/16] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD shenglei
2018-08-28  5:28   ` Chiu, Chasel
2018-08-28  3:42 ` [PATCH v3 06/16] IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs shenglei
2018-08-28  5:30   ` Chiu, Chasel [this message]
2018-08-28  3:42 ` [PATCH v3 07/16] SecurityPkg/Tcg2ConfigPei: Remove an unused PCD shenglei
2018-08-28  3:42 ` [PATCH v3 08/16] SecurityPkg/Tcg2Dxe: Remove unused PCDs shenglei
2018-08-29 13:41   ` Laszlo Ersek
2018-08-28  3:42 ` [PATCH v3 09/16] UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD shenglei
2018-08-28  3:42 ` [PATCH v3 10/16] MdePkg/BaseLib: " shenglei
2018-08-28  3:42 ` [PATCH v3 11/16] MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs shenglei
2018-08-28  4:53   ` Zeng, Star
2018-08-28  3:42 ` [PATCH v3 12/16] MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD shenglei
2018-08-28  3:42 ` [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs shenglei
2018-08-29  1:36   ` Ni, Ruiyu
2018-08-29 13:43   ` Laszlo Ersek
2018-08-28  3:42 ` [PATCH v3 14/16] ShellPkg/DpDynamicCommand: " shenglei
2018-08-29  1:36   ` Ni, Ruiyu
2018-08-28  3:42 ` [PATCH v3 15/16] ShellPkg/UefiHandleParsingLib: Remove an unused PCD shenglei
2018-08-29 13:49   ` Laszlo Ersek
2018-08-28  3:42 ` [PATCH v3 16/16] ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs shenglei
2018-08-29  1:37   ` Ni, Ruiyu
2018-08-29 13:50   ` Laszlo Ersek
2018-08-28 14:56 ` [PATCH v3 00/16] Removed " Carsey, Jaben
2018-10-02 10:13 ` Laszlo Ersek
2018-10-08  2:14   ` Zhang, Shenglei
2018-10-08  3:07   ` Ni, Ruiyu
2018-10-08 12:12     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3EFB470A303B4AB093197B6777CCEC5015ED7C@PGSMSX111.gar.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox