public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] IntelFsp2Pkg: Support FSP API mode indicator
Date: Thu, 11 Oct 2018 13:56:45 +0000	[thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5019D9F4@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503ADDFD0B@shsmsx102.ccr.corp.intel.com>


Hi Jiewen,

This one just adding a new field in FspGlobalData structure which never been consumed in current code base.
I'm checking if we should combine DISPATCH mode support code together instead of just header change.

Thanks!
Chasel


-----Original Message-----
From: Yao, Jiewen 
Sent: Thursday, October 11, 2018 9:41 PM
To: Chiu, Chasel <chasel.chiu@intel.com>; edk2-devel@lists.01.org
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: RE: [PATCH] IntelFsp2Pkg: Support FSP API mode indicator

Thanks Chasel.
I suggest we test the real function besides just pass build.

Please make sure your test below combination:
1) FSP wrapper with this change + FSP binary with this change.
2) FSP wrapper with this change + FSP binary without this change.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, October 11, 2018 9:35 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Desimone, Nathaniel L 
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] IntelFsp2Pkg: Support FSP API mode indicator
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1241
> 
> FSP will support both API and DISPATCH mode and require one field from 
> Global Data Structure to tell which mode is selected by boot loader.
> Use one reserved byte for FSP API mode indicator - FspApiModeEnabled 
> and maintain backward compatibility:
> 1. If platform FSP supports DISPATCH mode, it must
>    initialize this new field.
> 2. If platform FSP does not support DISPATCH mode,
>    this new field has no effect/not used.
> 
> Test: Verified compiling without issue.
> 
> Cc: Jiewen Yao <Jiewen.yao@intel.com>
> Cc: Desimone Nathaniel L <nathaniel.l.desimone@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  IntelFsp2Pkg/Include/FspGlobalData.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/IntelFsp2Pkg/Include/FspGlobalData.h
> b/IntelFsp2Pkg/Include/FspGlobalData.h
> index 7de26606a7..ccc9ecd78a 100644
> --- a/IntelFsp2Pkg/Include/FspGlobalData.h
> +++ b/IntelFsp2Pkg/Include/FspGlobalData.h
> @@ -1,6 +1,6 @@
>  /** @file
> 
> -  Copyright (c) 2014 - 2016, Intel Corporation. All rights 
> reserved.<BR>
> +  Copyright (c) 2014 - 2018, Intel Corporation. All rights 
> + reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of 
> the BSD License
>    which accompanies this distribution.  The full text of the license 
> may be found at @@ -54,7 +54,8 @@ typedef struct  {
>     VOID               *MemoryInitUpdPtr;
>     VOID               *SiliconInitUpdPtr;
>     UINT8              ApiIdx;
> -   UINT8              Reserved3[31];
> +   UINT8              FspApiModeEnabled; // 1: API mode; 0:
> DISPATCH mode
> +   UINT8              Reserved3[30];
>     UINT32             PerfSig;
>     UINT16             PerfLen;
>     UINT16             Reserved4;
> --
> 2.13.3.windows.1



      reply	other threads:[~2018-10-11 13:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 13:35 [PATCH] IntelFsp2Pkg: Support FSP API mode indicator Chasel, Chiu
2018-10-11 13:41 ` Yao, Jiewen
2018-10-11 13:56   ` Chiu, Chasel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3EFB470A303B4AB093197B6777CCEC5019D9F4@PGSMSX111.gar.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox