From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=chasel.chiu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4996021959CB2 for ; Tue, 18 Dec 2018 19:21:58 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2018 19:21:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,371,1539673200"; d="scan'208";a="119434164" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by orsmga002.jf.intel.com with ESMTP; 18 Dec 2018 19:21:57 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.232]) by PGSMSX106.gar.corp.intel.com ([169.254.9.56]) with mapi id 14.03.0415.000; Wed, 19 Dec 2018 11:21:55 +0800 From: "Chiu, Chasel" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Wu, Hao A" , "Gao, Liming" , "Ni, Ruiyu" , "Kinney, Michael D" , "Desimone, Nathaniel L" Thread-Topic: [PATCH V2 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs Thread-Index: AQHUlpgiHzbbG2/Kek2OMdypAh4XEaWFZsTw Date: Wed, 19 Dec 2018 03:21:55 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC501F6539@PGSMSX111.gar.corp.intel.com> References: <1545113286-49760-1-git-send-email-star.zeng@intel.com> <1545113286-49760-8-git-send-email-star.zeng@intel.com> In-Reply-To: <1545113286-49760-8-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmVmMzdkNGUtZGE3NS00YWRjLWIxM2MtM2E0NDE1NWJjYjUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVkw4VUl2RFZtakJcL0ZvUFR5WCtJSGlGVWZHUzhQWlE2aUZnbHk1RDBWUmxmTHhMZ3Rld2FYY0VvcFNsYzFtUnoifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Subject: Re: [PATCH V2 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 03:21:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu -----Original Message----- From: Zeng, Star=20 Sent: Tuesday, December 18, 2018 2:08 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Wang, Jian J ;= Wu, Hao A ; Gao, Liming ; Ni, Ru= iyu ; Kinney, Michael D ; D= esimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH V2 7/7] MdeModulePkg: Remove PcdPeiCoreMaxXXX PCDs REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1405 The codes have been updated to not use PcdPeiCoreMaxFvSupported, PcdPeiCore= MaxPeimPerFv and PcdPeiCoreMaxPpiSupported. The patch removes them in MdeModulePkg.dec. Cc: Jian J Wang Cc: Hao Wu Cc: Liming Gao Cc: Ruiyu Ni Cc: Michael D Kinney Cc: Nate DeSimone Cc: Chasel Chiu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Chasel Chiu --- MdeModulePkg/MdeModulePkg.dec | 13 ------------- MdeModulePkg/MdeModulePk= g.uni | 12 ------------ 2 files changed, 25 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec = index 0abacc1a901f..5585ce603596 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1053,23 +1053,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] # @Prompt VPD base address. gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0|UINT32|0x00010010 =20 - ## Maximum number of FV is supported by PeiCore's dispatching. - # @Prompt Maximum number of FV supported by PeiCore. - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxFvSupported|6|UINT32|0x00010= 030 - - ## Maximum File count in every FV is supported by PeiCore's dispatching. - # PeiCore supported File type includes PEIM, Combined PEIM and FV. - # @Prompt Maximum File count per FV supported by PeiCore. - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32|UINT32|0x000100= 31 - ## Maximum stack size for PeiCore. # @Prompt Maximum stack size for PeiCore. gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeiStackSize|0x20000|UINT32|= 0x00010032 =20 - ## Maximum PPI count is supported by PeiCore's PPI database. - # @Prompt Maximum PPI count supported by PeiCore. - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPpiSupported|64|UINT32|0x000= 10033 - ## The maximum size of a single non-HwErr type variable. # @Prompt Maximum variable size. gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x400|UINT32|0x3000000= 3 diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni = index 038e8485054b..fbea62dac8da 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -69,22 +69,10 @@ =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_HELP #langua= ge en-US "VPD type PCD allows a developer to point to an absolute physical = address PCDVPDBASEADDRESS to store PCD value." =20 -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxFvSupported_PROMPT= #language en-US "Maximum number of FV supported by PeiCore" - -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxFvSupported_HELP = #language en-US "Maximum number of FV is supported by PeiCore's dispatching= ." - -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxPeimPerFv_PROMPT = #language en-US "Maximum File count per FV supported by PeiCore" - -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxPeimPerFv_HELP #l= anguage en-US "Maximum File count in every FV is supported by PeiCore's dis= patching. PeiCore supported File type includes PEIM, Combined PEIM and FV." - #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxPeiStackSize_PROMP= T #language en-US "Maximum stack size for PeiCore" =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxPeiStackSize_HELP = #language en-US "Maximum stack size for PeiCore." =20 -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxPpiSupported_PROMP= T #language en-US "Maximum PPI count supported by PeiCore" - -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPeiCoreMaxPpiSupported_HELP = #language en-US "Maximum PPI count is supported by PeiCore's PPI database.= " - #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaxVariableSize_PROMPT #lan= guage en-US "Maximum variable size" =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaxVariableSize_HELP #langu= age en-US "The maximum size of a single non-HwErr type variable." -- 2.7.0.windows.1