From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=chasel.chiu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C19A5211D35C2 for ; Fri, 15 Mar 2019 00:32:14 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 00:32:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="307457103" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga005.jf.intel.com with ESMTP; 15 Mar 2019 00:32:12 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.237]) by PGSMSX107.gar.corp.intel.com ([169.254.7.60]) with mapi id 14.03.0415.000; Fri, 15 Mar 2019 15:32:11 +0800 From: "Chiu, Chasel" To: "Gao, Zhichao" , "edk2-devel@lists.01.org" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew Thread-Topic: [PATCH V2 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add a new api DebugVPrint Thread-Index: AQHU2u6KajQ0mfx5j02khpYFZ46nVaYMTIBg Date: Fri, 15 Mar 2019 07:32:10 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5028C47F@PGSMSX111.gar.corp.intel.com> References: <20190315051749.6564-1-zhichao.gao@intel.com> <20190315051749.6564-12-zhichao.gao@intel.com> In-Reply-To: <20190315051749.6564-12-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTg5MjhmYTMtZjQyNS00YWFlLWE4MTEtODA0NmE2YjhlYjcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiamRwYzFFQ1BXZitkNXN4bXN5T2pkSGFBVzZYdXBxaEpqUUR6VWsxcXlvemdBQzJKNGFtSEk2ZERyZTdcL2xFYlIifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Subject: Re: [PATCH V2 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add a new api DebugVPrint X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 07:32:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, March 15, 2019 1:18 PM > To: edk2-devel@lists.01.org > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: [PATCH V2 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add a ne= w > api DebugVPrint >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1395 >=20 > Add a new api DebugVPrint implementation in the DebugLib instance. This a= pi > would expose a print routine with VaList parameter. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > .../Library/BaseFspDebugLibSerialPort/DebugLib.c | 42 > +++++++++++++++++++--- > 1 file changed, 37 insertions(+), 5 deletions(-) >=20 > diff --git a/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > b/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > index 73bb08e357..57b6020a58 100644 > --- a/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > +++ b/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2019, Intel Corporation. All rights > + reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be found > at @@ -62,9 +62,38 @@ DebugPrint ( > IN CONST CHAR8 *Format, > ... > ) > +{ > + VA_LIST Marker; > + > + VA_START (Marker, Format); > + DebugVPrint (ErrorLevel, Format, Marker); > + VA_END (Marker); > +} > + > + > +/** > + Prints a debug message to the debug output device if the specified err= or level > is enabled. > + > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib > + function GetDebugPrintErrorLevel (), then print the message specified > + by Format and the associated variable argument list to the debug outpu= t > device. > + > + If Format is NULL, then ASSERT(). > + > + @param ErrorLevel The error level of the debug message. > + @param Format Format string for the debug message to print. > + @param VaListMarker VA_LIST marker for the variable argument list. > + > +**/ > +VOID > +EFIAPI > +DebugVPrint ( > + IN UINTN ErrorLevel, > + IN CONST CHAR8 *Format, > + IN VA_LIST VaListMarker > + ) > { > CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; > - VA_LIST Marker; >=20 > // > // If Format is NULL, then ASSERT(). > @@ -88,9 +117,7 @@ DebugPrint ( > // > // Convert the DEBUG() message to an ASCII String > // > - VA_START (Marker, Format); > - AsciiVSPrint (Buffer, sizeof (Buffer), Format, Marker); > - VA_END (Marker); > + AsciiVSPrint (Buffer, sizeof (Buffer), Format, VaListMarker); >=20 > // > // Send the print string to a Serial Port @@ -98,6 +125,7 @@ DebugPrin= t ( > SerialPortWrite ((UINT8 *)Buffer, AsciiStrLen (Buffer)); } >=20 > + > /** > Convert an UINT32 value into HEX string sepcified by Buffer. >=20 > @@ -118,6 +146,7 @@ FillHex ( > } > } >=20 > + > /** > Prints an assert message containing a filename, line number, and descr= iption. > This may be followed by a breakpoint or a dead loop. > @@ -172,6 +201,7 @@ DebugAssertInternal ( > CpuDeadLoop (); > } >=20 > + > /** > Prints an assert message containing a filename, line number, and descr= iption. > This may be followed by a breakpoint or a dead loop. > @@ -270,6 +300,7 @@ DebugPrintEnabled ( > return (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED) !=3D 0); } >=20 > + > /** > Returns TRUE if DEBUG_CODE() macros are enabled. >=20 > @@ -309,6 +340,7 @@ DebugClearMemoryEnabled ( > return (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED) !=3D 0); } >=20 > + > /** > Returns TRUE if any one of the bit is set both in ErrorLevel and > PcdFixedDebugPrintErrorLevel. >=20 > -- > 2.16.2.windows.1