From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=chasel.chiu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D5EBD211DBDE8 for ; Thu, 28 Mar 2019 01:44:30 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 01:44:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="126569182" Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106]) by orsmga007.jf.intel.com with ESMTP; 28 Mar 2019 01:44:28 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.237]) by KMSMSX155.gar.corp.intel.com ([169.254.15.89]) with mapi id 14.03.0415.000; Thu, 28 Mar 2019 16:44:27 +0800 From: "Chiu, Chasel" To: "Gao, Zhichao" , "edk2-devel@lists.01.org" CC: Bret Barkelew , "Desimone, Nathaniel L" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Thread-Topic: [PATCH V5 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs Thread-Index: AQHU5T3IZOga2JEZI0yg2JKNL1Vc1aYgujdw Date: Thu, 28 Mar 2019 08:44:27 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5029E569@PGSMSX111.gar.corp.intel.com> References: <20190328081016.14564-1-zhichao.gao@intel.com> <20190328081016.14564-12-zhichao.gao@intel.com> In-Reply-To: <20190328081016.14564-12-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTdkZTc1NzYtY2Y5Yy00MGM3LWI5YTgtNmRmYzI3ZDdmZjgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWlpkU0FabDFIK2pkcmhcL1U4cHRYYVl4VjBNdHp5WFRWZXpCeTN6WXVkQ2hpTHZxZGwyYmtZQWxDMFcwbXBvU00ifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Subject: Re: [PATCH V5 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 08:44:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable No change from V4. Reviewed-by: Chasel Chiu > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, March 28, 2019 4:10 PM > To: edk2-devel@lists.01.org > Cc: Bret Barkelew ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Gao, > Liming ; Sean Brogan ; > Michael Turner > Subject: [PATCH V5 11/17] IntelFspPkg/BaseFspDebugLibSerialPort: Add new > APIs >=20 > From: Bret Barkelew >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1395 >=20 > Add new APIs' implementation (DebugVPrint, DebugBPrint) in the DebugLib > instance. These APIs would expose print routines with VaList parameter an= d > BaseList parameter. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Reviewed-by: Chasel Chiu > --- > .../BaseFspDebugLibSerialPort/DebugLib.c | 103 +++++++++++++++++- > 1 file changed, 98 insertions(+), 5 deletions(-) >=20 > diff --git a/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > b/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > index 73bb08e357..8b322c038e 100644 > --- a/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > +++ b/IntelFspPkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2019, Intel Corporation. All rights > + reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be found > at @@ -28,6 +28,12 @@ >=20 > CONST CHAR8 *mHexTable =3D "0123456789ABCDEF"; >=20 > +// > +// VA_LIST can not initialize to NULL for all compiler, so we use this > +to // indicate a null VA_LIST // > +VA_LIST mVaListNull; > + > /** > Get stack frame pointer of function call. >=20 > @@ -62,9 +68,40 @@ DebugPrint ( > IN CONST CHAR8 *Format, > ... > ) > +{ > + VA_LIST Marker; > + > + VA_START (Marker, Format); > + DebugVPrint (ErrorLevel, Format, Marker); > + VA_END (Marker); > +} > + > +/** > + Prints a debug message to the debug output device if the specified > + error level is enabled base on Null-terminated format string and a > + VA_LIST argument list or a BASE_LIST argument list. > + > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib > + function GetDebugPrintErrorLevel (), then print the message specified > + by Format and the associated variable argument list to the debug outpu= t > device. > + > + If Format is NULL, then ASSERT(). > + > + @param ErrorLevel The error level of the debug message. > + @param Format Format string for the debug message to print. > + @param VaListMarker VA_LIST marker for the variable argument list. > + @param BaseListMarker BASE_LIST marker for the variable argument lis= t. > + > +**/ > +VOID > +DebugPrintMarker ( > + IN UINTN ErrorLevel, > + IN CONST CHAR8 *Format, > + IN VA_LIST VaListMarker, > + IN BASE_LIST BaseListMarker > + ) > { > CHAR8 Buffer[MAX_DEBUG_MESSAGE_LENGTH]; > - VA_LIST Marker; >=20 > // > // If Format is NULL, then ASSERT(). > @@ -88,9 +125,11 @@ DebugPrint ( > // > // Convert the DEBUG() message to an ASCII String > // > - VA_START (Marker, Format); > - AsciiVSPrint (Buffer, sizeof (Buffer), Format, Marker); > - VA_END (Marker); > + if (BaseListMarker =3D=3D NULL) { > + AsciiVSPrint (Buffer, sizeof (Buffer), Format, VaListMarker); } > + else { > + AsciiBSPrint (Buffer, sizeof (Buffer), Format, BaseListMarker); } >=20 > // > // Send the print string to a Serial Port @@ -98,6 +137,60 @@ DebugPri= nt ( > SerialPortWrite ((UINT8 *)Buffer, AsciiStrLen (Buffer)); } >=20 > +/** > + Prints a debug message to the debug output device if the specified > + error level is enabled. > + > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib > + function GetDebugPrintErrorLevel (), then print the message specified > + by Format and the associated variable argument list to the debug outpu= t > device. > + > + If Format is NULL, then ASSERT(). > + > + @param ErrorLevel The error level of the debug message. > + @param Format Format string for the debug message to print. > + @param VaListMarker VA_LIST marker for the variable argument list. > + > +**/ > +VOID > +EFIAPI > +DebugVPrint ( > + IN UINTN ErrorLevel, > + IN CONST CHAR8 *Format, > + IN VA_LIST VaListMarker > + ) > +{ > + DebugPrintMarker (ErrorLevel, Format, VaListMarker, NULL); } > + > +/** > + Prints a debug message to the debug output device if the specified > + error level is enabled. > + This function use BASE_LIST which would provide a more compatible > + service than VA_LIST. > + > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib > + function GetDebugPrintErrorLevel (), then print the message specified > + by Format and the associated variable argument list to the debug outpu= t > device. > + > + If Format is NULL, then ASSERT(). > + > + @param ErrorLevel The error level of the debug message. > + @param Format Format string for the debug message to print. > + @param BaseListMarker BASE_LIST marker for the variable argument lis= t. > + > +**/ > +VOID > +EFIAPI > +DebugBPrint ( > + IN UINTN ErrorLevel, > + IN CONST CHAR8 *Format, > + IN BASE_LIST BaseListMarker > + ) > +{ > + DebugPrintMarker (ErrorLevel, Format, mVaListNull, BaseListMarker); } > + > /** > Convert an UINT32 value into HEX string sepcified by Buffer. >=20 > -- > 2.21.0.windows.1