Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[chasel.chiu@intel.com]

I'm ok with the changes in below packages.

Thanks!
Chasel

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
For 
IntelFspPkg
IntelFspWrapperPkg
IntelFsp2Pkg
IntelFsp2WrapperPkg


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Liming Gao
> Sent: Monday, April 8, 2019 1:10 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> Mike:
>   I also review QuarkPlatformPkg, QuarkSocPkg. The changes look good to me.
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> Thanks
> Liming
> >-----Original Message-----
> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >Michael D Kinney
> >Sent: Thursday, April 04, 2019 7:42 AM
> >To: devel@edk2.groups.io; Kinney, Michael D
> ><michael.d.kinney@intel.com>
> >Subject: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> >License
> >
> >Hello,
> >
> >New in V3
> >=========
> >* Update the base of the patch series from edk2-stable201903 to
> >  7ed72121b7 that is after the file add/remove freeze:
> >
> >  https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html
> >
> >* Replace copyright line in License.txt in root with a single copyright
> >  for "TianoCore and contributors".
> >* Clarify commit message for changes to License.txt to state the text
> >  differences are larger than expected due to differences in line breaks.
> >* There is one less patch in the series than V2 due to the retirement
> >  of the EdkCompatibilityPkg.
> >* The git feature "git range-diff" can be used to compare the V2 and
> >  V3 branches even though they have different bases.  If you have both
> >  the V2 and V3 branches in your local repo, you can use the following
> >  command to see the changes.  Most are due to the removal of .S files
> >  in March.  If you pipe through grep looking for "diff --git" you will
> >  see the list of files with differences.
> >
> >  git range-diff edk2-stable201903..Bug_1373_BsdPatentLicense_V2
> >7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> >New in V2
> >=========
> >* Remove Cc lines from commit messages
> >* Remove branch reference from commit messages
> >* Change license in 2 files missed in OvmfPkg
> >* Update OvmfPkg/License.txt to BSD+Patent as the default license
> >* Move the portions of Contributions.txt in the root of edk2 to
> >  Readme.md in the root of edk2 that describe how to contribute
> >  along with the commit message format.
> >* Add to Readme.md in the root of edk2 that Signed-off-by means that
> >  the contributor certifies compliance to the Developer's Certificate
> >  of Origin 1.1.  https://developercertificate.org =========
> >
> >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> >This change is based on the following emails:
> >  https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
> >  https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
> >
> >RFCs with detailed process for the license change:
> >  V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
> >  V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
> >  V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
> >
> >I have posted the patch series for review on the following branch using
> >7ed72121b7 as the base for the patch series.
> >
> >  https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense_V3
> >
> >The commits in patch series can be viewed here:
> >
> >
> >https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense_V
> >3
> >
> >The patch series has one patch per package along with a few patches to
> >update the license information in the root of the edk2 repository as
> >described in the RFC V3.
> >
> >Due to the size of the patch series, I prefer to not send the patch
> >emails.  Instead, please perform code reviews using content from the
> >branch.
> >
> >All EDK II package maintainers and package reviewers should provide
> >review feedback for their packages.  The critical part of the review
> >is:
> >1) Any changes that cause build breaks or logic changes.  These code
> >   changes are intended to only modify license contents in comment
> >   blocks.
> >2) Any file that has been changed to BSD+Patent, but should remain
> >   with the current license.
> >3) Any file that that has not changed to BSD+Patent, but should be
> >   changed to BSD+Patent.
> >
> >Feedback and Reviewed-by emails should identify the patch the feedback
> >applies using the patch summary listed below.  The goal is to complete
> >all reviews to support the commit of these patches on April 9, 2019.
> >
> >eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
> >224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent
> >f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with
> >BSD+Patent License
> >845b945044 StdLib: Replace BSD License with BSD+Patent License
> >e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
> >a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with BSD+Patent
> >License 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with
> >BSD+Patent License
> >a67328cbb4 UefiCpuPkg: Replace BSD License with BSD+Patent License
> >248d91c908 StandaloneMmPkg: Replace BSD License with BSD+Patent License
> >415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent
> >License 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> >BSD+Patent License
> >9ffa4947d3 ShellPkg: Replace BSD License with BSD+Patent License
> >fdb6510955 ShellBinPkg: Replace BSD License with BSD+Patent License
> >dc5f8d93d9 SecurityPkg: Replace BSD License with BSD+Patent License
> >841d42a913 QuarkSocPkg: Replace BSD License with BSD+Patent License
> >75c3756e18 QuarkPlatformPkg: Replace BSD License with BSD+Patent
> >License
> >657491e5a3 PcAtChipsetPkg: Replace BSD License with BSD+Patent License
> >4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
> >521b8139c7 OptionRomPkg: Replace BSD License with BSD+Patent License
> >ec339f8320 Omap35xxPkg: Replace BSD License with BSD+Patent License
> >ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License
> >aa99b9adeb NetworkPkg: Replace BSD License with BSD+Patent License
> >88bdc989d7 MdePkg: Replace BSD License with BSD+Patent License
> >5628b5e5c7 MdeModulePkg: Replace BSD License with BSD+Patent License
> >505e36838d IntelSiliconPkg: Replace BSD License with BSD+Patent License
> >e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with BSD+Patent
> >License
> >d7347d7ef0 IntelFspPkg: Replace BSD License with BSD+Patent License
> >487741dd60 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent
> >License 0e8d264faf IntelFsp2Pkg: Replace BSD License with BSD+Patent
> >License
> >f4835e9508 IntelFrameworkPkg: Replace BSD License with BSD+Patent
> >License d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License with
> >BSD+Patent License
> >5a3c8a14ce FmpDevicePkg: Replace BSD License with BSD+Patent License
> >87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent License
> >f336d7d7de EmulatorPkg: Replace BSD License with BSD+Patent License
> >5ea93a6088 EmbeddedPkg: Replace BSD License with BSD+Patent License
> >2afa7c0820 DynamicTablesPkg: Replace BSD License with BSD+Patent
> >License
> >4768af6404 CryptoPkg: Replace BSD License with BSD+Patent License
> >9aecbee0a3 CorebootPayloadPkg: Replace BSD License with BSD+Patent
> >License
> >e7716450b8 CorebootModulePkg: Replace BSD License with BSD+Patent
> >License 04fb04e0aa BeagleBoardPkg: Replace BSD License with BSD+Patent
> >License
> >c910bd4e91 ArmVirtPkg: Replace BSD License with BSD+Patent License
> >6f98d2f305 ArmPlatformPkg: Replace BSD License with BSD+Patent License
> >1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent License
> >0fb7bd552b BaseTools: Replace BSD License with BSD+Patent License
> >bc61733285 edk2: Replace BSD License with BSD+Patent License 8ee83c5dcd
> >edk2: Change License.txt from 2-Clause BSD to BSD+Patent
> >17a33094a9 edk2: Add License-History.txt
> >
> >Best regards,
> >
> >Mike
> >
> >
> >
> 
> 
>