Re: [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

["Chiu, Chasel" <chasel.chiu@intel.com>]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 3/6]
> KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
> 
> For KabylakeRvp3, it is using the HPET timer unconditionally. The PCD
> 'PcdUseHpetTimer' is not being used.
> 
> This commit will remove the usage of the above PCD in package DSC files.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> 
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.d
> sc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig
> .dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig
> .dsc
> index bb06ff5a2a..f3d082ce41 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig
> .dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfi
> +++ g.dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Platform configuration file.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -111,7 +111,6 @@ [PcdsFeatureFlag]
>    gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE
>    gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE
>    gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE
> -  gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE                       # TRUE -
> HPET / FALSE - 8254 timer is used.
>    gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE
>    gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE
> 
> --
> 2.12.0.windows.1