From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: chasel.chiu@intel.com)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by groups.io with SMTP; Sun, 07 Apr 2019 22:34:53 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 22:34:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,324,1549958400"; 
   d="scan'208";a="313969849"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
  by orsmga005.jf.intel.com with ESMTP; 07 Apr 2019 22:34:51 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by
 PGSMSX101.gar.corp.intel.com ([169.254.1.108]) with mapi id 14.03.0415.000;
 Mon, 8 Apr 2019 13:34:49 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD
Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH v1 4/6]
  KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD
Thread-Index: AQHU6qtdIQ2fWLz79kqLmqqt4TVWCKYxxC3A
Date: Mon, 8 Apr 2019 05:34:49 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502B7C48@PGSMSX111.gar.corp.intel.com>
References: <20190404055728.9368-1-hao.a.wu@intel.com>
 <20190404055728.9368-5-hao.a.wu@intel.com>
In-Reply-To: <20190404055728.9368-5-hao.a.wu@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDU3ODg3NmYtNGMxMS00YzE0LTgyMGYtYmQxYzJiYTZiMGZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ2h1OFBpdU9BWTB2OGZseDlmMWtwbzBZalYyWThzd2ZpeTFQK2ZFbEZ6Vko3R0tTaHBtd3d3aHpyaFJiaklhciJ9
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.205]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 4/6]
> KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD
>=20
> For KabylakeRvp3, none of its consumed modules is using the PCD:
> gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask
>=20
> Thus, this commit will remove the PCD consumption in the DSC file.
>=20
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
> | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c
> index 35f383ecef..51d4e2ea46 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d
> +++ sc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Platform description.
>  #
> -# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made avai=
lable
> under  # the terms and conditions of the BSD License which accompanies th=
is
> distribution.
> @@ -194,9 +194,6 @@ [PcdsFixedAtBuild.IA32]
>    gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x3800000
>=20
>  [PcdsFixedAtBuild.X64]
> -  gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask|0x0eB8
> -
> -
>    # Default platform supported RFC 4646 languages: (American) English
>=20
> gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-U
> S"
>=20
> --
> 2.12.0.windows.1