From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID
Date: Mon, 8 Apr 2019 05:35:01 +0000 [thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502B7C58@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <20190404055728.9368-7-hao.a.wu@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 6/6]
> KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID
>
> For modules consumed by platforms within KabylakeOpenBoardPkg &
> ClevoOpenBoardPkg, none of them has the dependency on the Legacy8259
> protocol. Thus, this commit will remove the duplicated Legacy8259 protocol
> GUID within file SiPkg.dec.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> index cca1a2e60d..078d10c520 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> @@ -268,7 +268,6 @@ [Protocols]
> ##
> gEfiLegacyBiosProtocolGuid = {0xdb9a1e3d, 0x45cb, 0x4abb, {0x85, 0x3b,
> 0xe5, 0x38, 0x7f, 0xdb, 0x2e, 0x2d}} gEfiLegacyInterruptProtocolGuid =
> {0x31ce593d, 0x108a, 0x485d, {0xad, 0xb2, 0x78, 0xf2, 0x1f, 0x29, 0x66, 0xbe}}
> -gEfiLegacy8259ProtocolGuid = {0x38321dba, 0x4fe0, 0x4e17, {0x8a, 0xec,
> 0x41, 0x30, 0x55, 0xea, 0xed, 0xc1}} gEfiDataHubProtocolGuid = {0xae80d021,
> 0x618e, 0x11d4, {0xbc, 0xd7, 0x00, 0x80, 0xc7, 0x3c, 0x88, 0x81}} ## ##
> MdeModulePkg
> --
> 2.12.0.windows.1
next prev parent reply other threads:[~2019-04-08 5:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 5:57 [edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg Wu, Hao A
2019-04-04 5:57 ` [edk2-platforms/devel-MinPlatform][PATCH v1 1/6] ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer' Wu, Hao A
2019-04-04 5:57 ` [edk2-platforms/devel-MinPlatform][PATCH v1 2/6] ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD Wu, Hao A
2019-04-08 4:01 ` [edk2-devel] " chasel.chiu
2019-04-04 5:57 ` [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer' Wu, Hao A
2019-04-08 3:56 ` [edk2-devel] " chasel.chiu
2019-04-08 5:34 ` Chiu, Chasel
2019-04-04 5:57 ` [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD Wu, Hao A
2019-04-08 4:01 ` [edk2-devel] " chasel.chiu
2019-04-08 5:34 ` Chiu, Chasel
2019-04-04 5:57 ` [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer' Wu, Hao A
2019-04-08 3:56 ` [edk2-devel] " chasel.chiu
2019-04-08 5:35 ` Chiu, Chasel
2019-04-04 5:57 ` [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID Wu, Hao A
2019-04-08 3:58 ` [edk2-devel] " chasel.chiu
2019-04-08 5:35 ` Chiu, Chasel [this message]
2019-04-05 1:20 ` [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg Kubacki, Michael A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3EFB470A303B4AB093197B6777CCEC502B7C58@PGSMSX111.gar.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox