Re: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

["Chiu, Chasel" <chasel.chiu@intel.com>]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg:
> Remove unused PCD 'PcdUseHpetTimer'
> 
> For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of
> them are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is
> not being used.
> 
> This commit will remove the above PCD within KabylakeSiliconPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec              | 3 +--
>  Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> index 92b6d492ee..cca1a2e60d 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> @@ -1,7 +1,7 @@
>  ## @file
>  # Component description file for the Silicon Reference Code.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -592,7 +592,6 @@ [PcdsFeatureFlag]
>  gSiPkgTokenSpaceGuid.PcdSerialGpioEnable
> |FALSE|BOOLEAN|0xF0000003
>  gSiPkgTokenSpaceGuid.PcdAtaEnable
> |FALSE|BOOLEAN|0xF0000004
>  gSiPkgTokenSpaceGuid.PcdSiCsmEnable
> |FALSE|BOOLEAN|0xF0000005
> -gSiPkgTokenSpaceGuid.PcdUseHpetTimer
> |FALSE|BOOLEAN|0xF0000006
>  gSiPkgTokenSpaceGuid.PcdSgEnable                     |TRUE
> |BOOLEAN|0xF0000008
>  gSiPkgTokenSpaceGuid.PcdAcpiEnable                   |TRUE
> |BOOLEAN|0xF0000009
>  gSiPkgTokenSpaceGuid.PcdSourceDebugEnable
> |FALSE|BOOLEAN|0xF000000B
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> index 7189ce6396..cbb2a8bec4 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> +++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Component description file for the SkyLake SiPkg DSC file.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -19,7 +19,6 @@ [PcdsFeatureFlag]
>  gSiPkgTokenSpaceGuid.PcdSerialGpioEnable             |FALSE
>  gSiPkgTokenSpaceGuid.PcdAtaEnable                    |FALSE
>  gSiPkgTokenSpaceGuid.PcdSiCsmEnable                  |FALSE
> -gSiPkgTokenSpaceGuid.PcdUseHpetTimer                 |FALSE
>  gSiPkgTokenSpaceGuid.PcdSgEnable                     |TRUE
>  gSiPkgTokenSpaceGuid.PcdAcpiEnable                   |FALSE
>  gSiPkgTokenSpaceGuid.PcdSourceDebugEnable            |FALSE
> --
> 2.12.0.windows.1