From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: chasel.chiu@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Sun, 07 Apr 2019 22:35:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 22:35:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,324,1549958400"; d="scan'208";a="159633226" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga004.fm.intel.com with ESMTP; 07 Apr 2019 22:35:17 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by PGSMSX107.gar.corp.intel.com ([169.254.7.67]) with mapi id 14.03.0415.000; Mon, 8 Apr 2019 13:35:16 +0800 From: "Chiu, Chasel" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer' Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer' Thread-Index: AQHU6qth6X29d5J3MkW/z5oIIZRoJKYxxE/g Date: Mon, 8 Apr 2019 05:35:15 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502B7C64@PGSMSX111.gar.corp.intel.com> References: <20190404055728.9368-1-hao.a.wu@intel.com> <20190404055728.9368-6-hao.a.wu@intel.com> In-Reply-To: <20190404055728.9368-6-hao.a.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzM4YjQ1YzEtNGVjZC00ZTY1LTgzMmItYWU2MTJkNGVjNmIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZWp6NHZFQ1hCQkdpSGpsVW5wSXpYQVc2Y09Ta1hDWXhqTWt2QU1aVzVlSHhRSmQ4NmF1Y3RkNVwvbWtkZ2h0V2gifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, April 4, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Chiu, Chasel ; > Kubacki, Michael A > Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSilicon= Pkg: > Remove unused PCD 'PcdUseHpetTimer' >=20 > For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of > them are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' = is > not being used. >=20 > This commit will remove the above PCD within KabylakeSiliconPkg. >=20 > Cc: Chasel Chiu > Cc: Michael A Kubacki > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 3 +-- > Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > index 92b6d492ee..cca1a2e60d 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > @@ -1,7 +1,7 @@ > ## @file > # Component description file for the Silicon Reference Code. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # This program and the accompanying materials are licensed and made avai= lable > under # the terms and conditions of the BSD License which accompanies th= is > distribution. > @@ -592,7 +592,6 @@ [PcdsFeatureFlag] > gSiPkgTokenSpaceGuid.PcdSerialGpioEnable > |FALSE|BOOLEAN|0xF0000003 > gSiPkgTokenSpaceGuid.PcdAtaEnable > |FALSE|BOOLEAN|0xF0000004 > gSiPkgTokenSpaceGuid.PcdSiCsmEnable > |FALSE|BOOLEAN|0xF0000005 > -gSiPkgTokenSpaceGuid.PcdUseHpetTimer > |FALSE|BOOLEAN|0xF0000006 > gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE > |BOOLEAN|0xF0000008 > gSiPkgTokenSpaceGuid.PcdAcpiEnable |TRUE > |BOOLEAN|0xF0000009 > gSiPkgTokenSpaceGuid.PcdSourceDebugEnable > |FALSE|BOOLEAN|0xF000000B > diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > index 7189ce6396..cbb2a8bec4 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > +++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc > @@ -1,7 +1,7 @@ > ## @file > # Component description file for the SkyLake SiPkg DSC file. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # This program and the accompanying materials are licensed and made avai= lable > under # the terms and conditions of the BSD License which accompanies th= is > distribution. > @@ -19,7 +19,6 @@ [PcdsFeatureFlag] > gSiPkgTokenSpaceGuid.PcdSerialGpioEnable |FALSE > gSiPkgTokenSpaceGuid.PcdAtaEnable |FALSE > gSiPkgTokenSpaceGuid.PcdSiCsmEnable |FALSE > -gSiPkgTokenSpaceGuid.PcdUseHpetTimer |FALSE > gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE > gSiPkgTokenSpaceGuid.PcdAcpiEnable |FALSE > gSiPkgTokenSpaceGuid.PcdSourceDebugEnable |FALSE > -- > 2.12.0.windows.1