From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Mon, 15 Apr 2019 02:03:22 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 02:03:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,353,1549958400"; d="scan'208";a="142812631" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by orsmga003.jf.intel.com with ESMTP; 15 Apr 2019 02:03:20 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by PGSMSX106.gar.corp.intel.com ([169.254.9.45]) with mapi id 14.03.0415.000; Mon, 15 Apr 2019 17:03:19 +0800 From: "Chiu, Chasel" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem Thread-Index: AQHU8zh2VPiuw6CuXUeczS1aNVjO9aY87MpQ Date: Mon, 15 Apr 2019 09:03:18 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502EA0EC@PGSMSX111.gar.corp.intel.com> References: <20190415030739.14328-1-zhichao.gao@intel.com> <20190415030739.14328-2-zhichao.gao@intel.com> In-Reply-To: <20190415030739.14328-2-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQ1NzhmYmEtNjM1NC00ODU3LTljYzktNDBkMTQ2MTNjOWZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSU1aK2krZHVxUWtSNjc1S3hEV3grekhcLzFLamlaejhha1JTZEtSNVNDazlIdHBjS0xhUEJaXC9vbW5oMmJMbnJYIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please see below comments inline. > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms/devel-MinPlatform][PATCH 1/5] > KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 >=20 > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this interface may cause link error, if some drivers use this = new API and > link to this library instance. > Make the ResetPlatformSpecific's parameters same with the interface in Ed= k2 > repo. > Notes: > This library API only provide a basic function of reset. If the consumers= want full > functions, they should use the instance in the MdeModulePkg and make sure= the > depex driver is dispatched. >=20 > Cc: Chasel Chiu > Cc: Michael A Kubacki > Signed-off-by: Zhichao Gao > --- > .../BaseResetSystemLib/BaseResetSystemLib.c | 47 +++++++++++++++++-- > 1 file changed, 44 insertions(+), 3 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseResetSystemLib/BaseRes= et > SystemLib.c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseResetSystemLib/BaseRes= e > tSystemLib.c > index ec1a69e4de..0d5c27401d 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseResetSystemLib/BaseRes= et > SystemLib.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/BaseResetSystemLib/Ba > +++ seResetSystemLib.c > @@ -1,7 +1,7 @@ > /** @file > System reset library services. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made availa= ble > under the terms and conditions of the BSD License that accompanies this > distribution. > The full text of the license may be found at @@ -108,7 +108,6 @@ > ResetShutdown ( > /** > Calling this function causes the system to enter a power state for pla= tform > specific. >=20 > - @param[in] ResetStatus The status code for the reset. > @param[in] DataSize The size of ResetData in bytes. > @param[in] ResetData Optional element used to introduce a > platform specific reset. > The exact type of the reset is defined= by the > EFI_GUID that follows @@ -118,7 +117,6 @@ ResetShutdown ( VOID EFIAPI > ResetPlatformSpecific ( > - IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > IN VOID *ResetData OPTIONAL > ) > @@ -142,6 +140,49 @@ EnterS3WithImmediateWake ( > ASSERT (FALSE); > } >=20 > +/** > + The ResetSystem function resets the entire platform. > + > + @param[in] ResetType The type of reset to perform. > + @param[in] ResetStatus The status code for the reset. > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWar= m, > or EfiResetShutdown > + the data buffer starts with a Null-terminate= d string, > optionally > + followed by additional binary data. The stri= ng is a > description > + that the caller may use to further indicate = the reason for > the > + system reset. > +**/ > +VOID > +EFIAPI > +ResetSystem ( > + IN EFI_RESET_TYPE ResetType, > + IN EFI_STATUS ResetStatus, > + IN UINTN DataSize, > + IN VOID *ResetData OPTIONAL > + ) > +{ > + switch (ResetType) { > + case EfiResetWarm: > + ResetWarm (); > + break; > + > + case EfiResetCold: > + ResetCold (); > + break; > + > + case EfiResetShutdown: > + ResetShutdown (); > + return ; > + > + case EfiResetPlatformSpecific: > + ResetPlatformSpecific (DataSize, ResetData); > + return; > + > + default: > + return ; > + } > +} > + Where we consuming this new "ResetSystem ()" in Kabylake MinPlatform? Same question for changes in Pei and Dxe library instances. Thanks! Chasel > /** > The library constructuor. >=20 > -- > 2.21.0.windows.1