From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: chasel.chiu@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Mon, 15 Apr 2019 18:55:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 18:55:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,355,1549958400"; d="scan'208";a="151181071" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga002.jf.intel.com with ESMTP; 15 Apr 2019 18:55:31 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by PGSMSX102.gar.corp.intel.com ([169.254.6.226]) with mapi id 14.03.0415.000; Tue, 16 Apr 2019 09:55:30 +0800 From: "Chiu, Chasel" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH 4/5] KabylakeSiliconPkg/PeiResetSystemLib: Add a new API ResetSystem Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH 4/5] KabylakeSiliconPkg/PeiResetSystemLib: Add a new API ResetSystem Thread-Index: AQHU8zh6Uigyv++Uhk+cYateJMXW1KY+CHQA Date: Tue, 16 Apr 2019 01:55:29 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502EB95F@PGSMSX111.gar.corp.intel.com> References: <20190415030739.14328-1-zhichao.gao@intel.com> <20190415030739.14328-6-zhichao.gao@intel.com> In-Reply-To: <20190415030739.14328-6-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWYzYzRmNmYtMWE2My00OWVkLTg5MDItMGY5MTI4ZmM5YzgwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMUsycDErdGFHVzNMcisrVnpTNEExMG5URUFDcThua1BuOERvbEJmUnhxSUt5UVJsMWNoMWxzbFBSdTNNTDBLYyJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Gao, Liming > Subject: [edk2-platforms/devel-MinPlatform][PATCH 4/5] > KabylakeSiliconPkg/PeiResetSystemLib: Add a new API ResetSystem >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 >=20 > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this interface may cause link error, if some drivers use this = new API and > link to this library instance. > Make the ResetPlatformSpecific's parameters same with the interface in Ed= k2 > repo. > Also change the caller and declaration at the same time. > Notes: > This library API only provide a basic function of reset. If the consumers= want full > functions, they should use the instance in the MdeModulePkg and make sure= the > depex driver is dispatched. >=20 > Cc: Chasel Chiu > Cc: Michael A Kubacki > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > .../Pch/Library/PeiPchResetLib/PchReset.c | 7 ++- > .../PeiResetSystemLib/PeiResetSystemLib.c | 47 +++++++++++++++++-- > 2 files changed, 47 insertions(+), 7 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PchReset.c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PchReset.c > index 79f3f779dc..1a30bf31f6 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PchRese= t.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PchRes > +++ et.c > @@ -1,7 +1,7 @@ > /** @file > PCH RESET PEIM DRIVER. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made availa= ble > under the terms and conditions of the BSD License that accompanies this > distribution. > The full text of the license may be found at @@ -27,7 +27,6 @@ WITHOUT > WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > VOID > EFIAPI > ResetPlatformSpecific ( > - IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > IN VOID *ResetData OPTIONAL > ); > @@ -67,7 +66,7 @@ ResetSystem ( > return; >=20 > case EfiResetPlatformSpecific: > - ResetPlatformSpecific (ResetStatus, DataSize, ResetData); > + ResetPlatformSpecific (DataSize, ResetData); > return; >=20 > default: > @@ -115,7 +114,7 @@ Reset ( > case PchGlobalReset: > CopyMem (&ResetData.Guid, &gPchGlobalResetGuid, sizeof (EFI_GUID))= ; > StrCpyS (ResetData.Description, > PCH_RESET_DATA_STRING_MAX_LENGTH, > PCH_PLATFORM_SPECIFIC_RESET_STRING); > - ResetPlatformSpecific (EFI_SUCCESS, sizeof (PCH_RESET_DATA), > &ResetData); > + ResetPlatformSpecific (sizeof (PCH_RESET_DATA), &ResetData); > break; >=20 > default: > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiReset= Sys > temLib.c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiReset= Sys > temLib.c > index 6a017a40a7..92ce6af5cc 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiReset= Sys > temLib.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/Pei > +++ ResetSystemLib.c > @@ -1,7 +1,7 @@ > /** @file > System reset library services. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made availa= ble > under the terms and conditions of the BSD License that accompanies this > distribution. > The full text of the license may be found at @@ -239,7 +239,6 @@ > PeiPchGlobalReset ( > /** > Calling this function causes the system to enter a power state for pla= tform > specific. >=20 > - @param[in] ResetStatus The status code for the reset. > @param[in] DataSize The size of ResetData in bytes. > @param[in] ResetData Optional element used to introduce a > platform specific reset. > The exact type of the reset is defined= by the > EFI_GUID that follows @@ -249,7 +248,6 @@ PeiPchGlobalReset ( VOID > EFIAPI ResetPlatformSpecific ( > - IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > IN VOID *ResetData OPTIONAL > ) > @@ -284,3 +282,46 @@ EnterS3WithImmediateWake ( > ASSERT (FALSE); > } >=20 > +/** > + The ResetSystem function resets the entire platform. > + > + @param[in] ResetType The type of reset to perform. > + @param[in] ResetStatus The status code for the reset. > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWar= m, > or EfiResetShutdown > + the data buffer starts with a Null-terminate= d string, > optionally > + followed by additional binary data. The stri= ng is a > description > + that the caller may use to further indicate = the reason for > the > + system reset. > +**/ > +VOID > +EFIAPI > +ResetSystem ( > + IN EFI_RESET_TYPE ResetType, > + IN EFI_STATUS ResetStatus, > + IN UINTN DataSize, > + IN VOID *ResetData OPTIONAL > + ) > +{ > + switch (ResetType) { > + case EfiResetWarm: > + ResetWarm (); > + break; > + > + case EfiResetCold: > + ResetCold (); > + break; > + > + case EfiResetShutdown: > + ResetShutdown (); > + return ; > + > + case EfiResetPlatformSpecific: > + ResetPlatformSpecific (DataSize, ResetData); > + return; > + > + default: > + return ; > + } > +} > + > -- > 2.21.0.windows.1