From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Tue, 23 Apr 2019 22:19:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2019 22:19:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,388,1549958400"; d="scan'208";a="167378007" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2019 22:19:51 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by PGSMSX102.gar.corp.intel.com ([169.254.6.226]) with mapi id 14.03.0415.000; Wed, 24 Apr 2019 13:19:50 +0800 From: "Chiu, Chasel" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Desimone, Nathaniel L" , "Zeng, Star" , "Gao, Liming" , "Bi, Dandan" Subject: Re: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions Thread-Topic: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions Thread-Index: AQHU+lp+DRmvXGFPd0ywbxJaR6kyRaZKxcIw Date: Wed, 24 Apr 2019 05:19:50 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502F4036@PGSMSX111.gar.corp.intel.com> References: <20190424045827.19348-1-zhichao.gao@intel.com> <20190424045827.19348-7-zhichao.gao@intel.com> In-Reply-To: <20190424045827.19348-7-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmEyMWYyYzMtNTVjZi00N2RkLWExMjItYzhiZDdkNjAzYTdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYzg1MlJaczFUN2dCSklCOXVMbXQxQ0J3ZzVkV3l4dWZsa0hadDdJbkF0NWd4OXVcLzlmdkloQ2xiQTY2OEkrNEYifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, April 24, 2019 12:58 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Gao, Liming ; Bi, Dandan > > Subject: [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease > the name collisions >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1740 >=20 > Add a 'static' descriptor to the global variables that only used in a sin= gle file to > minimize the name collisions. > This is only for the varable named 'mExitBootServicesEvent'. >=20 > Cc: Laszlo Ersek > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Liming Gao > Cc: Dandan Bi > Signed-off-by: Zhichao Gao > --- > IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > index fe344a5327..459acc694b 100644 > --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c > @@ -39,7 +39,7 @@ extern EFI_GUID gAddPerfRecordProtocolGuid; extern > EFI_GUID gFspHobGuid; extern EFI_GUID gFspApiPerformanceGuid; >=20 > -EFI_EVENT mExitBootServicesEvent =3D NULL; > +static EFI_EVENT mExitBootServicesEvent =3D NULL; >=20 > /** > Relocate this image under 4G memory. > -- > 2.21.0.windows.1