* [edk2-platforms/devel-MinPlatform][PATCH v1 0/2] Remove dead code
@ 2019-04-25 1:08 Kubacki, Michael A
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: " Kubacki, Michael A
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: " Kubacki, Michael A
0 siblings, 2 replies; 6+ messages in thread
From: Kubacki, Michael A @ 2019-04-25 1:08 UTC (permalink / raw)
To: devel; +Cc: Nate DeSimone, Chasel Chiu, Michael D Kinney, Ankit Sinha
These patchset removes code that will not be used in these packages.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Michael Kubacki (2):
KabylakeOpenBoardPkg/AcpiTables: Remove dead code
ClevoOpenBoardPkg/AcpiTables: Remove dead code
.../Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 8 --------
.../KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 12 ++----------
2 files changed, 2 insertions(+), 18 deletions(-)
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code
2019-04-25 1:08 [edk2-platforms/devel-MinPlatform][PATCH v1 0/2] Remove dead code Kubacki, Michael A
@ 2019-04-25 1:08 ` Kubacki, Michael A
2019-04-25 1:17 ` Chiu, Chasel
2019-04-25 18:13 ` Nate DeSimone
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: " Kubacki, Michael A
1 sibling, 2 replies; 6+ messages in thread
From: Kubacki, Michael A @ 2019-04-25 1:08 UTC (permalink / raw)
To: devel; +Cc: Nate DeSimone, Chasel Chiu, Michael D Kinney
Removes ASL code not referenced in the package.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
.../KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
index 56c27f3a63..d20e35f12e 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
@@ -1,7 +1,7 @@
/** @file
Thunderbolt ACPI methods
-Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available under
the terms and conditions of the BSD License that accompanies this distribution.
The full text of the license may be found at
@@ -106,14 +106,6 @@ External(\_SB.PCI0.RP24.PON, MethodObj)
External(\_SB.PCI0.PEG0.PG00._ON, MethodObj)
External(\_SB.PCI0.PEG1.PG01._ON, MethodObj)
External(\_SB.PCI0.PEG2.PG02._ON, MethodObj)
-//
-// SA:RestrictedBegin
-//
-External(\_SB.PCI0.LKEN, MethodObj)
-External(\_SB.PCI0.LKDS, MethodObj)
-//
-// SA:RestrictedEnd
-//
Name(TRDO, 0) // 1 during TBT RTD3 _ON
Name(TRD3, 0) // 1 during TBT RTD3 _OFF
@@ -612,7 +604,7 @@ Scope(\_GPE)
} Else {
Return (OSUP(Local0, DTBT_CONTROLLER))
}
- } Else
+ } Else
{
ADBG("Dev Present")
Return (0)
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: Remove dead code
2019-04-25 1:08 [edk2-platforms/devel-MinPlatform][PATCH v1 0/2] Remove dead code Kubacki, Michael A
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: " Kubacki, Michael A
@ 2019-04-25 1:08 ` Kubacki, Michael A
2019-04-25 18:13 ` Nate DeSimone
1 sibling, 1 reply; 6+ messages in thread
From: Kubacki, Michael A @ 2019-04-25 1:08 UTC (permalink / raw)
To: devel; +Cc: Nate DeSimone, Ankit Sinha, Michael D Kinney
Removes ASL code not referenced in the package.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 8 --------
1 file changed, 8 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl b/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
index c8226a5549..47a97628a5 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
+++ b/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
@@ -105,14 +105,6 @@ External(\_SB.PCI0.RP24.PON, MethodObj)
External(\_SB.PCI0.PEG0.PG00._ON, MethodObj)
External(\_SB.PCI0.PEG1.PG01._ON, MethodObj)
External(\_SB.PCI0.PEG2.PG02._ON, MethodObj)
-//
-// SA:RestrictedBegin
-//
-External(\_SB.PCI0.LKEN, MethodObj)
-External(\_SB.PCI0.LKDS, MethodObj)
-//
-// SA:RestrictedEnd
-//
Name(TRDO, 0) // 1 during TBT RTD3 _ON
Name(TRD3, 0) // 1 during TBT RTD3 _OFF
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: " Kubacki, Michael A
@ 2019-04-25 1:17 ` Chiu, Chasel
2019-04-25 18:13 ` Nate DeSimone
1 sibling, 0 replies; 6+ messages in thread
From: Chiu, Chasel @ 2019-04-25 1:17 UTC (permalink / raw)
To: Kubacki, Michael A, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Kinney, Michael D
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Kubacki, Michael A
> Sent: Thursday, April 25, 2019 9:09 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2]
> KabylakeOpenBoardPkg/AcpiTables: Remove dead code
>
> Removes ASL code not referenced in the package.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
> .../KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 12
> ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
> b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
> index 56c27f3a63..d20e35f12e 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.as
> +++ l
> @@ -1,7 +1,7 @@
> /** @file
> Thunderbolt ACPI methods
>
> -Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials are licensed and made available
> under the terms and conditions of the BSD License that accompanies this
> distribution.
> The full text of the license may be found at @@ -106,14 +106,6 @@
> External(\_SB.PCI0.RP24.PON, MethodObj)
> External(\_SB.PCI0.PEG0.PG00._ON, MethodObj)
> External(\_SB.PCI0.PEG1.PG01._ON, MethodObj)
> External(\_SB.PCI0.PEG2.PG02._ON, MethodObj) -// -// SA:RestrictedBegin -//
> -External(\_SB.PCI0.LKEN, MethodObj) -External(\_SB.PCI0.LKDS, MethodObj)
> -// -// SA:RestrictedEnd -//
>
> Name(TRDO, 0) // 1 during TBT RTD3 _ON
> Name(TRD3, 0) // 1 during TBT RTD3 _OFF @@ -612,7 +604,7 @@
> Scope(\_GPE)
> } Else {
> Return (OSUP(Local0, DTBT_CONTROLLER))
> }
> - } Else
> + } Else
> {
> ADBG("Dev Present")
> Return (0)
> --
> 2.16.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: " Kubacki, Michael A
2019-04-25 1:17 ` Chiu, Chasel
@ 2019-04-25 18:13 ` Nate DeSimone
1 sibling, 0 replies; 6+ messages in thread
From: Nate DeSimone @ 2019-04-25 18:13 UTC (permalink / raw)
To: Kubacki, Michael A, devel@edk2.groups.io; +Cc: Chiu, Chasel, Kinney, Michael D
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Kubacki, Michael A
Sent: Wednesday, April 24, 2019 6:09 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code
Removes ASL code not referenced in the package.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
.../KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
index 56c27f3a63..d20e35f12e 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.as
+++ l
@@ -1,7 +1,7 @@
/** @file
Thunderbolt ACPI methods
-Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License that accompanies this distribution.
The full text of the license may be found at @@ -106,14 +106,6 @@ External(\_SB.PCI0.RP24.PON, MethodObj) External(\_SB.PCI0.PEG0.PG00._ON, MethodObj) External(\_SB.PCI0.PEG1.PG01._ON, MethodObj) External(\_SB.PCI0.PEG2.PG02._ON, MethodObj) -// -// SA:RestrictedBegin -// -External(\_SB.PCI0.LKEN, MethodObj) -External(\_SB.PCI0.LKDS, MethodObj) -// -// SA:RestrictedEnd -//
Name(TRDO, 0) // 1 during TBT RTD3 _ON
Name(TRD3, 0) // 1 during TBT RTD3 _OFF @@ -612,7 +604,7 @@ Scope(\_GPE)
} Else {
Return (OSUP(Local0, DTBT_CONTROLLER))
}
- } Else
+ } Else
{
ADBG("Dev Present")
Return (0)
--
2.16.2.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: Remove dead code
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: " Kubacki, Michael A
@ 2019-04-25 18:13 ` Nate DeSimone
0 siblings, 0 replies; 6+ messages in thread
From: Nate DeSimone @ 2019-04-25 18:13 UTC (permalink / raw)
To: Kubacki, Michael A, devel@edk2.groups.io; +Cc: Sinha, Ankit, Kinney, Michael D
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Kubacki, Michael A
Sent: Wednesday, April 24, 2019 6:09 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: Remove dead code
Removes ASL code not referenced in the package.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 8 --------
1 file changed, 8 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl b/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
index c8226a5549..47a97628a5 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
+++ b/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
@@ -105,14 +105,6 @@ External(\_SB.PCI0.RP24.PON, MethodObj) External(\_SB.PCI0.PEG0.PG00._ON, MethodObj) External(\_SB.PCI0.PEG1.PG01._ON, MethodObj) External(\_SB.PCI0.PEG2.PG02._ON, MethodObj) -// -// SA:RestrictedBegin -// -External(\_SB.PCI0.LKEN, MethodObj) -External(\_SB.PCI0.LKDS, MethodObj) -// -// SA:RestrictedEnd -//
Name(TRDO, 0) // 1 during TBT RTD3 _ON
Name(TRD3, 0) // 1 during TBT RTD3 _OFF
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-25 18:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-25 1:08 [edk2-platforms/devel-MinPlatform][PATCH v1 0/2] Remove dead code Kubacki, Michael A
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: " Kubacki, Michael A
2019-04-25 1:17 ` Chiu, Chasel
2019-04-25 18:13 ` Nate DeSimone
2019-04-25 1:08 ` [edk2-platforms/devel-MinPlatform][PATCH v1 2/2] ClevoOpenBoardPkg/AcpiTables: " Kubacki, Michael A
2019-04-25 18:13 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox