From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by groups.io with SMTP; Wed, 24 Apr 2019 18:17:04 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 18:17:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,391,1549958400"; 
   d="scan'208";a="137208937"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
  by orsmga008.jf.intel.com with ESMTP; 24 Apr 2019 18:17:03 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by
 PGSMSX101.gar.corp.intel.com ([169.254.1.108]) with mapi id 14.03.0415.000;
 Thu, 25 Apr 2019 09:17:01 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Kubacki, Michael A" <michael.a.kubacki@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>, "Kinney,
 Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2] KabylakeOpenBoardPkg/AcpiTables: Remove dead code
Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2]
  KabylakeOpenBoardPkg/AcpiTables: Remove dead code
Thread-Index: AQHU+wOmv4PblntAHUKRi91IEfOViKZMEvcQ
Date: Thu, 25 Apr 2019 01:17:01 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502F4ECC@PGSMSX111.gar.corp.intel.com>
References: <20190425010855.21596-1-michael.a.kubacki@intel.com>
 <20190425010855.21596-2-michael.a.kubacki@intel.com>
In-Reply-To: <20190425010855.21596-2-michael.a.kubacki@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGY3OTBhMTItMWIyYy00MjIxLWJhMzktNTU1NDc5MTJiNmMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRE43dXA2TmJmRnBmRFJKcTJiWjY5Y2kzZlFMWjJtVmkybUZ2R2I5b2dyQ1ZVOVlNVlZPYWMwRDNPa0QzRlhGVCJ9
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.205]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kubacki, Michael A
> Sent: Thursday, April 25, 2019 9:09 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/2]
> KabylakeOpenBoardPkg/AcpiTables: Remove dead code
>=20
> Removes ASL code not referenced in the package.
>=20
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  .../KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl     | 12
> ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>=20
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
> b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
> index 56c27f3a63..d20e35f12e 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.as
> +++ l
> @@ -1,7 +1,7 @@
>  /** @file
>   Thunderbolt ACPI methods
>=20
> -Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials are licensed and made availa=
ble
> under  the terms and conditions of the BSD License that accompanies this
> distribution.
>  The full text of the license may be found at @@ -106,14 +106,6 @@
> External(\_SB.PCI0.RP24.PON, MethodObj)
> External(\_SB.PCI0.PEG0.PG00._ON, MethodObj)
> External(\_SB.PCI0.PEG1.PG01._ON, MethodObj)
> External(\_SB.PCI0.PEG2.PG02._ON, MethodObj) -// -// SA:RestrictedBegin -=
//
> -External(\_SB.PCI0.LKEN, MethodObj) -External(\_SB.PCI0.LKDS, MethodObj)
> -// -// SA:RestrictedEnd -//
>=20
>  Name(TRDO, 0) // 1 during TBT RTD3 _ON
>  Name(TRD3, 0) // 1 during TBT RTD3 _OFF @@ -612,7 +604,7 @@
> Scope(\_GPE)
>        } Else {
>          Return (OSUP(Local0, DTBT_CONTROLLER))
>        }
> -    } Else
> +    } Else
>      {
>        ADBG("Dev Present")
>        Return (0)
> --
> 2.16.2.windows.1