From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by groups.io with SMTP; Thu, 25 Apr 2019 18:37:14 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
  by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 18:37:14 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,395,1549958400"; 
   d="scan'208";a="165178268"
Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82])
  by fmsmga004.fm.intel.com with ESMTP; 25 Apr 2019 18:37:12 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by
 PGSMSX103.gar.corp.intel.com ([169.254.2.111]) with mapi id 14.03.0415.000;
 Fri, 26 Apr 2019 09:36:11 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: Laszlo Ersek <lersek@redhat.com>, "Kinney, Michael D"
	<michael.d.kinney@intel.com>, "Gao, Liming" <liming.gao@intel.com>, "Bi,
 Dandan" <dandan.bi@intel.com>, "Desimone, Nathaniel L"
	<nathaniel.l.desimone@intel.com>
Subject: Re: [PATCH V3 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make global variable static
Thread-Topic: [PATCH V3 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make
 global variable static
Thread-Index: AQHU+8wbeXmiUGU09kCr9vTUfnaZ+aZNqMvw
Date: Fri, 26 Apr 2019 01:36:11 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC502F5F9C@PGSMSX111.gar.corp.intel.com>
References: <20190426010404.20624-1-zhichao.gao@intel.com>
 <20190426010404.20624-7-zhichao.gao@intel.com>
In-Reply-To: <20190426010404.20624-7-zhichao.gao@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmE1NGE1NzItZGYyZC00OTk0LWIzYTYtZjUwMDhiZmEyMzM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNlNPYWgyVTNJaDdJRkNIRlwvdVFEcDZLQmRXWUk3RW10ZENUVU1RVWhpREM3cmVoc083RSt5RUkzMlViM09pV3gifQ==
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.206]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Friday, April 26, 2019 9:04 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: [PATCH V3 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: make
> global variable static
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1740
>=20
> Add a 'static' storage-class specifier to the global variables that only =
used in a
> single file to minimize the name collisions.
> This is only for the variable named 'mExitBootServicesEvent'.
>=20
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git
> a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c
> b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c
> index fe344a5327..0af0ec778c 100644
> --- a/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c
> +++ b/IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.c
> @@ -1,7 +1,7 @@
>  /** @file
>    This driver will register two callbacks to call fsp's notifies.
>=20
> -  Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2014 - 2019, Intel Corporation. All rights
> + reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
>  **/
> @@ -39,7 +39,7 @@ extern EFI_GUID gAddPerfRecordProtocolGuid;  extern
> EFI_GUID gFspHobGuid;  extern EFI_GUID gFspApiPerformanceGuid;
>=20
> -EFI_EVENT mExitBootServicesEvent     =3D NULL;
> +static EFI_EVENT mExitBootServicesEvent     =3D NULL;
>=20
>  /**
>    Relocate this image under 4G memory.
> --
> 2.21.0.windows.1