* [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot
@ 2019-05-09 3:33 Gao, Zhichao
2019-05-09 3:37 ` Yao, Jiewen
2019-05-09 4:59 ` Chiu, Chasel
0 siblings, 2 replies; 3+ messages in thread
From: Gao, Zhichao @ 2019-05-09 3:33 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Chasel Chiu, Ray Ni, Rangasai V Chaganty
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1547
V2:
Abandon V1.
Do global invalidation of context-cache and IOTLB at
ExitBootServices.
V1:
Only doing IOTLB invalidation would cause a BSOD
'DRIVER_VERIFIER_DMA_VIOLATION' while changing the second
level page entry's attributes. So always do the global
invalidation of context-cache and IOTLB.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
.../Feature/VTd/IntelVTdDxe/DmaProtection.c | 13 +++++++-
.../Feature/VTd/IntelVTdDxe/DmaProtection.h | 32 ++++++++++++++++++-
2 files changed, 43 insertions(+), 2 deletions(-)
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
index f221e45938..956ebb2d3d 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
@@ -1,6 +1,6 @@
/** @file
- Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -581,9 +581,20 @@ OnExitBootServices (
IN VOID *Context
)
{
+ UINTN VtdIndex;
+
DEBUG ((DEBUG_INFO, "Vtd OnExitBootServices\n"));
DumpVtdRegsAll ();
+ DEBUG ((DEBUG_INFO, "Invalidate all\n"));
+ for (VtdIndex = 0; VtdIndex < mVtdUnitNumber; VtdIndex++) {
+ FlushWriteBuffer (VtdIndex);
+
+ InvalidateContextCache (VtdIndex);
+
+ InvalidateIOTLB (VtdIndex);
+ }
+
if ((PcdGet8(PcdVTdPolicyPropertyMask) & BIT1) == 0) {
DisableDmar ();
DumpVtdRegsAll ();
diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
index 72426d23c3..a3331db8f7 100644
--- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
+++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
@@ -1,6 +1,6 @@
/** @file
- Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -168,6 +168,36 @@ DisableDmar (
VOID
);
+/**
+ Flush VTd engine write buffer.
+
+ @param[in] VtdIndex The index used to identify a VTd engine.
+**/
+VOID
+FlushWriteBuffer (
+ IN UINTN VtdIndex
+ );
+
+/**
+ Invalidate VTd context cache.
+
+ @param[in] VtdIndex The index used to identify a VTd engine.
+**/
+EFI_STATUS
+InvalidateContextCache (
+ IN UINTN VtdIndex
+ );
+
+/**
+ Invalidate VTd IOTLB.
+
+ @param[in] VtdIndex The index used to identify a VTd engine.
+**/
+EFI_STATUS
+InvalidateIOTLB (
+ IN UINTN VtdIndex
+ );
+
/**
Invalid VTd global IOTLB.
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot
2019-05-09 3:33 [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot Gao, Zhichao
@ 2019-05-09 3:37 ` Yao, Jiewen
2019-05-09 4:59 ` Chiu, Chasel
1 sibling, 0 replies; 3+ messages in thread
From: Yao, Jiewen @ 2019-05-09 3:37 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io
Cc: Chiu, Chasel, Ni, Ray, Chaganty, Rangasai V
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Wednesday, May 8, 2019 8:34 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation
> before boot
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1547
>
> V2:
> Abandon V1.
> Do global invalidation of context-cache and IOTLB at
> ExitBootServices.
>
> V1:
> Only doing IOTLB invalidation would cause a BSOD
> 'DRIVER_VERIFIER_DMA_VIOLATION' while changing the second
> level page entry's attributes. So always do the global
> invalidation of context-cache and IOTLB.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Feature/VTd/IntelVTdDxe/DmaProtection.c | 13 +++++++-
> .../Feature/VTd/IntelVTdDxe/DmaProtection.h | 32
> ++++++++++++++++++-
> 2 files changed, 43 insertions(+), 2 deletions(-)
>
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> index f221e45938..956ebb2d3d 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> @@ -1,6 +1,6 @@
> /** @file
>
> - Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -581,9 +581,20 @@ OnExitBootServices (
> IN VOID *Context
> )
> {
> + UINTN VtdIndex;
> +
> DEBUG ((DEBUG_INFO, "Vtd OnExitBootServices\n"));
> DumpVtdRegsAll ();
>
> + DEBUG ((DEBUG_INFO, "Invalidate all\n"));
> + for (VtdIndex = 0; VtdIndex < mVtdUnitNumber; VtdIndex++) {
> + FlushWriteBuffer (VtdIndex);
> +
> + InvalidateContextCache (VtdIndex);
> +
> + InvalidateIOTLB (VtdIndex);
> + }
> +
> if ((PcdGet8(PcdVTdPolicyPropertyMask) & BIT1) == 0) {
> DisableDmar ();
> DumpVtdRegsAll ();
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> index 72426d23c3..a3331db8f7 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> @@ -1,6 +1,6 @@
> /** @file
>
> - Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -168,6 +168,36 @@ DisableDmar (
> VOID
> );
>
> +/**
> + Flush VTd engine write buffer.
> +
> + @param[in] VtdIndex The index used to identify a VTd
> engine.
> +**/
> +VOID
> +FlushWriteBuffer (
> + IN UINTN VtdIndex
> + );
> +
> +/**
> + Invalidate VTd context cache.
> +
> + @param[in] VtdIndex The index used to identify a VTd
> engine.
> +**/
> +EFI_STATUS
> +InvalidateContextCache (
> + IN UINTN VtdIndex
> + );
> +
> +/**
> + Invalidate VTd IOTLB.
> +
> + @param[in] VtdIndex The index used to identify a VTd
> engine.
> +**/
> +EFI_STATUS
> +InvalidateIOTLB (
> + IN UINTN VtdIndex
> + );
> +
> /**
> Invalid VTd global IOTLB.
>
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot
2019-05-09 3:33 [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot Gao, Zhichao
2019-05-09 3:37 ` Yao, Jiewen
@ 2019-05-09 4:59 ` Chiu, Chasel
1 sibling, 0 replies; 3+ messages in thread
From: Chiu, Chasel @ 2019-05-09 4:59 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io
Cc: Yao, Jiewen, Ni, Ray, Chaganty, Rangasai V
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Thursday, May 9, 2019 11:34 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before
> boot
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1547
>
> V2:
> Abandon V1.
> Do global invalidation of context-cache and IOTLB at ExitBootServices.
>
> V1:
> Only doing IOTLB invalidation would cause a BSOD
> 'DRIVER_VERIFIER_DMA_VIOLATION' while changing the second level page
> entry's attributes. So always do the global invalidation of context-cache and
> IOTLB.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> .../Feature/VTd/IntelVTdDxe/DmaProtection.c | 13 +++++++-
> .../Feature/VTd/IntelVTdDxe/DmaProtection.h | 32 ++++++++++++++++++-
> 2 files changed, 43 insertions(+), 2 deletions(-)
>
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> index f221e45938..956ebb2d3d 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.c
> @@ -1,6 +1,6 @@
> /** @file
>
> - Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2017 - 2019, Intel Corporation. All rights
> + reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -581,9 +581,20 @@ OnExitBootServices (
> IN VOID *Context
> )
> {
> + UINTN VtdIndex;
> +
> DEBUG ((DEBUG_INFO, "Vtd OnExitBootServices\n"));
> DumpVtdRegsAll ();
>
> + DEBUG ((DEBUG_INFO, "Invalidate all\n")); for (VtdIndex = 0;
> + VtdIndex < mVtdUnitNumber; VtdIndex++) {
> + FlushWriteBuffer (VtdIndex);
> +
> + InvalidateContextCache (VtdIndex);
> +
> + InvalidateIOTLB (VtdIndex);
> + }
> +
> if ((PcdGet8(PcdVTdPolicyPropertyMask) & BIT1) == 0) {
> DisableDmar ();
> DumpVtdRegsAll ();
> diff --git a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> index 72426d23c3..a3331db8f7 100644
> --- a/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> +++ b/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/DmaProtection.h
> @@ -1,6 +1,6 @@
> /** @file
>
> - Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2017 - 2019, Intel Corporation. All rights
> + reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -168,6 +168,36 @@ DisableDmar (
> VOID
> );
>
> +/**
> + Flush VTd engine write buffer.
> +
> + @param[in] VtdIndex The index used to identify a VTd engine.
> +**/
> +VOID
> +FlushWriteBuffer (
> + IN UINTN VtdIndex
> + );
> +
> +/**
> + Invalidate VTd context cache.
> +
> + @param[in] VtdIndex The index used to identify a VTd engine.
> +**/
> +EFI_STATUS
> +InvalidateContextCache (
> + IN UINTN VtdIndex
> + );
> +
> +/**
> + Invalidate VTd IOTLB.
> +
> + @param[in] VtdIndex The index used to identify a VTd engine.
> +**/
> +EFI_STATUS
> +InvalidateIOTLB (
> + IN UINTN VtdIndex
> + );
> +
> /**
> Invalid VTd global IOTLB.
>
> --
> 2.21.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-09 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-09 3:33 [PATCH V2] IntelSiliconPkg/IntelVTdDxe: Do global invalidation before boot Gao, Zhichao
2019-05-09 3:37 ` Yao, Jiewen
2019-05-09 4:59 ` Chiu, Chasel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox