From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 09 May 2019 22:43:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 22:43:31 -0700 X-ExtLoop1: 1 Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga003.jf.intel.com with ESMTP; 09 May 2019 22:43:31 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.74]) by KMSMSX152.gar.corp.intel.com ([169.254.11.16]) with mapi id 14.03.0415.000; Fri, 10 May 2019 13:43:30 +0800 From: "Chiu, Chasel" To: "Shi, Steven" , "devel@edk2.groups.io" CC: "Lu, Shifei A" , "Gao, Liming" , "Bi, Dandan" , "Kubacki, Michael A" Subject: Re: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to support Binary Cache Thread-Topic: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to support Binary Cache Thread-Index: AQHVBhZhINb4G59ib0Gg4BtnPw0m4aZj2k3A Date: Fri, 10 May 2019 05:43:28 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5030B7D1@PGSMSX111.gar.corp.intel.com> References: <20190509032119.2084-1-steven.shi@intel.com> <20190509032119.2084-3-steven.shi@intel.com> In-Reply-To: <20190509032119.2084-3-steven.shi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTg2MmQ5YWMtMTI5OS00OTM1LTk2NWEtZWNlOTRjMGYyY2ZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVWR3QTUwa3pZMW5TVllJMDRvQ1kyODlUK01uemFCWGZ6OGVDRGFieXhuSGgzV1h3ekp1R2F4XC9Ic2t4d2JxbkEifQ== x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Shi, Steven > Sent: Thursday, May 9, 2019 11:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Lu, Shifei A ; > Gao, Liming ; Bi, Dandan ; > Kubacki, Michael A > Subject: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to > support Binary Cache >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1785 >=20 > Extend the options in the Purley build batch file to support Binary Cache= produce > and consume switch. > --- > .../PurleyOpenBoardPkg/BoardMtOlympus/bld.bat | 18 > ++++++++++++++++-- > .../BoardMtOlympus/prebuild.bat | 4 ++-- > 2 files changed, 18 insertions(+), 4 deletions(-) >=20 > diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > index a66d19e66e..eda749af36 100644 > --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/bld.bat > @@ -16,6 +16,11 @@ REM Run setlocal to take a snapshot of the environment > variables. endlocal is c setlocal set SCRIPT_ERROR=3D0 >=20 > +@if not defined BINARY_CACHE_PATH ( > + echo Info: BINARY_CACHE_PATH is empty, use BinCache as default > + SET BINARY_CACHE_PATH=3DBinCache > +) > + > REM ---- Do NOT use :: for comments Inside of code blocks() ---- >=20 > ::************************************************************** > ******** > @@ -34,6 +39,15 @@ if /I "%1"=3D=3D"clean" ( > goto :EOF > ) >=20 > +if /I "%1"=3D=3D"cache-produce" ( > + set BINARY_CACHE_CMD_LINE=3D --hash > +--binary-destination=3D%BINARY_CACHE_PATH% > +) > + > +if /I "%1"=3D=3D"cache-consume" ( > + set BINARY_CACHE_CMD_LINE=3D --hash > --binary-source=3D%BINARY_CACHE_PATH% > +) > + > + > shift > GOTO :parseCmdLine >=20 > @@ -92,8 +106,8 @@ echo Build Start > echo. > echo -------------------------------------------------------------------= - > echo. > -echo build %BUILD_CMD_LINE% --log=3D%BUILD_LOG% > %BUILD_REPORT_FLAGS% -call build %BUILD_CMD_LINE% > --log=3D%BUILD_LOG% %BUILD_REPORT_FLAGS% > +echo build %BUILD_CMD_LINE% --log=3D%BUILD_LOG% > %BUILD_REPORT_FLAGS% > +%BINARY_CACHE_CMD_LINE% call build %BUILD_CMD_LINE% > --log=3D%BUILD_LOG% > +%BUILD_REPORT_FLAGS% %BINARY_CACHE_CMD_LINE% > echo -------------------------------------------------------------------= - > echo. > echo Build End > diff --git > a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > index 81a9634d51..880e6417ac 100644 > --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat > @@ -188,8 +188,8 @@ set PRE_BUILD_CMD_LINE=3D%BUILD_CMD_LINE% -D > MAX_SOCKET=3D%MAX_SOCKET% set > PRE_BUILD_LOG=3D%WORKSPACE%\Build\prebuild.log > set PRE_BUILD_REPORT=3D%WORKSPACE%\Build\preBuildReport.txt >=20 > -echo build %PRE_BUILD_CMD_LINE% -m > %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% > --log=3D%PRE_BUILD_LOG% -call build %PRE_BUILD_CMD_LINE% -m > %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% > --log=3D%PRE_BUILD_LOG% > +echo build %PRE_BUILD_CMD_LINE% -m > +%BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y %PRE_BUILD_REPORT% > +--log=3D%PRE_BUILD_LOG% %BINARY_CACHE_CMD_LINE% call build > +%PRE_BUILD_CMD_LINE% -m %BOARD_PKG%\Acpi\BoardAcpiDxe\Dsdt.inf -y > +%PRE_BUILD_REPORT% --log=3D%PRE_BUILD_LOG% > %BINARY_CACHE_CMD_LINE% > if %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL% >=20 > @REM PSYS =3D=3D FIX0 > -- > 2.17.1.windows.2