From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: chasel.chiu@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Mon, 20 May 2019 19:19:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 19:19:19 -0700 X-ExtLoop1: 1 Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by orsmga002.jf.intel.com with ESMTP; 20 May 2019 19:19:18 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.3]) by KMSMSX154.gar.corp.intel.com ([169.254.12.39]) with mapi id 14.03.0415.000; Tue, 21 May 2019 10:19:17 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Agyeman, Prince" CC: "Kubacki, Michael A" , "Kinney, Michael D" , "Desimone, Nathaniel L" , "Gao, Liming" , "Sinha, Ankit" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI Thread-Index: AQHVC0SpU0Bcaoh2OUmGlyMCHq9nv6Z04H8g Date: Tue, 21 May 2019 02:19:16 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50323197@PGSMSX111.gar.corp.intel.com> References: <08db7c1beb0a707429a9c4c9aed8f5489663c08a.1557779977.git.prince.agyeman@intel.com> In-Reply-To: <08db7c1beb0a707429a9c4c9aed8f5489663c08a.1557779977.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTA4ZTZmNmYtNmY3ZC00ODJiLTgwNjQtMmI0Y2ZhZTNkZGJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWVwvODg3elpQRFVmRTVvZmZ5bWRXTTFSeDRIYkk4eEFXSUlHN1k0d0RYOHV2a09uN2hTM1wvZmtOa3JMNGFVRjhWIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Thursday, May 16, 2019 1:36 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Kubacki, Michael A > ; Kinney, Michael D > ; Desimone, Nathaniel L > ; Gao, Liming ; Si= nha, > Ankit > Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] KabylakeSiliconPkg: C= asting > functions to EFIAPI >=20 > From: Prince Agyeman >=20 > This fixes the calling convension issues in gcc >=20 > Gcc build was tested on Ubuntu 16.04.5 LTS with gcc version 5.4.0, nasm = version > 2.11.08 >=20 > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Ankit Sinha >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h | 11 +++--= ------ > .../Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c | 11 > +++-------- > .../KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h | 12 > ++++-------- > .../KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.c | 12 > ++++-------- > 4 files changed, 14 insertions(+), 32 deletions(-) >=20 > diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm= .h > b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h > index 58ef567..666340e 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h > @@ -1,14 +1,8 @@ > /** @file > Header file for PCH Init SMM Handler >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
-This p= rogram > and the accompanying materials are licensed and made available under -th= e > terms and conditions of the BSD License that accompanies this distributi= on. > -The full text of the license may be found at > -http://opensource.org/licenses/bsd-license.php. > - > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS > OR IMPLIED. > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ >=20 > @@ -211,6 +205,7 @@ PchPcieLinkEqHandlerFunction ( >=20 > **/ > VOID > +EFIAPI > PchPcieIoTrapSmiCallback ( > IN EFI_HANDLE DispatchHandle, > IN EFI_SMM_IO_TRAP_CONTEXT *CallbackContext, > diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm= .c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c > index b4234f6..847fbfb 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c > @@ -1,14 +1,8 @@ > /** @file > PCH Pcie SMM Driver Entry >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
-This p= rogram > and the accompanying materials are licensed and made available under -th= e > terms and conditions of the BSD License that accompanies this distributi= on. > -The full text of the license may be found at > -http://opensource.org/licenses/bsd-license.php. > - > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS > OR IMPLIED. > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > #include "PchInitSmm.h" > @@ -244,6 +238,7 @@ PchPciePmIoTrapSmiCallback ( >=20 > **/ > VOID > +EFIAPI > PchPcieIoTrapSmiCallback ( > IN EFI_HANDLE DispatchHandle, > IN EFI_SMM_IO_TRAP_CONTEXT *CallbackContext, > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h > b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h > index 3eebdc1..a9f0664 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h > +++ > b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h > @@ -1,14 +1,8 @@ > /** @file > Prototypes and defines for the PCH SMM Dispatcher. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
-This p= rogram > and the accompanying materials are licensed and made available under -th= e > terms and conditions of the BSD License that accompanies this distributi= on. > -The full text of the license may be found at > -http://opensource.org/licenses/bsd-license.php. > - > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS > OR IMPLIED. > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > #ifndef PCH_SMM_H > @@ -516,6 +510,7 @@ typedef struct { > registered and the SMI source has bee= n enabled. > **/ > EFI_STATUS > +EFIAPI > PchSmmCoreRegister ( > IN PCH_SMM_GENERIC_PROTOCOL *This, > IN EFI_SMM_HANDLER_ENTRY_POINT2 DispatchFunctio= n, > @@ -536,6 +531,7 @@ PchSmmCoreRegister ( > @retval EFI_INVALID_PARAMETER Handle is invalid. > **/ > EFI_STATUS > +EFIAPI > PchSmmCoreUnRegister ( > IN PCH_SMM_GENERIC_PROTOCOL *This, > IN EFI_HANDLE *DispatchHandle > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore. > c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore. > c > index 77f0561..cb3bfba 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore. > c > +++ > b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCo > +++ re.c > @@ -2,14 +2,8 @@ > This driver is responsible for the registration of child drivers > and the abstraction of the PCH SMI sources. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
-This p= rogram > and the accompanying materials are licensed and made available under -th= e > terms and conditions of the BSD License that accompanies this distributi= on. > -The full text of the license may be found at > -http://opensource.org/licenses/bsd-license.php. > - > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS > OR IMPLIED. > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > #include "PchSmm.h" > @@ -331,6 +325,7 @@ SmiInputValueDuplicateCheck ( > registered and the SMI source has bee= n enabled. > **/ > EFI_STATUS > +EFIAPI > PchSmmCoreRegister ( > IN PCH_SMM_GENERIC_PROTOCOL *This, > IN EFI_SMM_HANDLER_ENTRY_POINT2 DispatchFunctio= n, > @@ -602,6 +597,7 @@ Error: > @retval EFI_INVALID_PARAMETER Handle is invalid. > **/ > EFI_STATUS > +EFIAPI > PchSmmCoreUnRegister ( > IN PCH_SMM_GENERIC_PROTOCOL *This, > IN EFI_HANDLE *DispatchHandle > -- > 2.7.4 >=20 >=20 >=20