From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Sinha, Ankit" <ankit.sinha@intel.com>
Subject: Re: [edk2-platforms] [PATCH v2 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI
Date: Thu, 23 May 2019 00:18:57 +0000 [thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC503253F2@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <3163a336bdf97eda8871de804654b11943a8d8bb.1558406058.git.prince.agyeman@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Agyeman, Prince
> Sent: Tuesday, May 21, 2019 11:08 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>; Sinha,
> Ankit <ankit.sinha@intel.com>
> Subject: [edk2-platforms] [PATCH v2 2/5] KabylakeSiliconPkg: Casting functions
> to EFIAPI
>
> From: Prince Agyeman <prince.agyeman@intel.com>
>
> This fixes the calling convension issues in gcc
>
> Gcc build was tested on Ubuntu 16.04.5 LTS with gcc version 5.4.0, nasm version
> 2.11.08
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
>
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
> Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h | 3
> ++-
> Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c | 3
> ++-
> Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h |
> 4 +++-
> .../Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.c |
> 4 +++-
> 4 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> index 44f151c..666340e 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchInitSmm.h
> @@ -1,7 +1,7 @@
> /** @file
> Header file for PCH Init SMM Handler
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -205,6 +205,7 @@ PchPcieLinkEqHandlerFunction (
>
> **/
> VOID
> +EFIAPI
> PchPcieIoTrapSmiCallback (
> IN EFI_HANDLE DispatchHandle,
> IN EFI_SMM_IO_TRAP_CONTEXT *CallbackContext,
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> index aed33bb..847fbfb 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchInit/Smm/PchPcieSmm.c
> @@ -1,7 +1,7 @@
> /** @file
> PCH Pcie SMM Driver Entry
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -238,6 +238,7 @@ PchPciePmIoTrapSmiCallback (
>
> **/
> VOID
> +EFIAPI
> PchPcieIoTrapSmiCallback (
> IN EFI_HANDLE DispatchHandle,
> IN EFI_SMM_IO_TRAP_CONTEXT *CallbackContext,
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> index 508832e..a9f0664 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> +++
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmm.h
> @@ -1,7 +1,7 @@
> /** @file
> Prototypes and defines for the PCH SMM Dispatcher.
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -510,6 +510,7 @@ typedef struct {
> registered and the SMI source has been enabled.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_SMM_HANDLER_ENTRY_POINT2 DispatchFunction,
> @@ -530,6 +531,7 @@ PchSmmCoreRegister (
> @retval EFI_INVALID_PARAMETER Handle is invalid.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreUnRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_HANDLE *DispatchHandle
> diff --git
> a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.
> c
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.
> c
> index 0c494bf..cb3bfba 100644
> ---
> a/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCore.
> c
> +++
> b/Silicon/Intel/KabylakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmmCo
> +++ re.c
> @@ -2,7 +2,7 @@
> This driver is responsible for the registration of child drivers
> and the abstraction of the PCH SMI sources.
>
> -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -325,6 +325,7 @@ SmiInputValueDuplicateCheck (
> registered and the SMI source has been enabled.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_SMM_HANDLER_ENTRY_POINT2 DispatchFunction,
> @@ -596,6 +597,7 @@ Error:
> @retval EFI_INVALID_PARAMETER Handle is invalid.
> **/
> EFI_STATUS
> +EFIAPI
> PchSmmCoreUnRegister (
> IN PCH_SMM_GENERIC_PROTOCOL *This,
> IN EFI_HANDLE *DispatchHandle
> --
> 2.7.4
next prev parent reply other threads:[~2019-05-23 0:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 3:08 [edk2-platforms] [PATCH v2 0/5] Added GCC5 build support Agyeman, Prince
2019-05-21 3:08 ` [edk2-platforms] [PATCH v2 1/5] MinPlatformPkg: " Agyeman, Prince
2019-05-22 19:08 ` Kubacki, Michael A
2019-05-22 19:11 ` Nate DeSimone
2019-05-23 0:15 ` Chiu, Chasel
2019-05-21 3:08 ` [edk2-platforms] [PATCH v2 2/5] KabylakeSiliconPkg: Casting functions to EFIAPI Agyeman, Prince
2019-05-22 19:08 ` [edk2-devel] " Kubacki, Michael A
2019-05-22 19:11 ` Nate DeSimone
2019-05-23 0:18 ` Chiu, Chasel [this message]
2019-05-21 3:08 ` [edk2-platforms] [PATCH v2 3/5] KabylakeOpenBoardPkg: Added GCC5 build support Agyeman, Prince
2019-05-22 19:11 ` [edk2-devel] " Nate DeSimone
2019-05-23 0:19 ` Chiu, Chasel
2019-05-21 3:08 ` [edk2-platforms] [PATCH v2 4/5] ClevoOpenBoardPkg: " Agyeman, Prince
2019-05-22 19:11 ` [edk2-devel] " Nate DeSimone
2019-05-21 3:08 ` [edk2-platforms] [PATCH v2 5/5] Intel/Readme.md: Updated readme with linux build instructions Agyeman, Prince
2019-05-21 3:20 ` Chiu, Chasel
2019-05-22 19:06 ` [edk2-devel] " Kubacki, Michael A
2019-05-22 19:12 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C3EFB470A303B4AB093197B6777CCEC503253F2@PGSMSX111.gar.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox