From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 22 May 2019 17:19:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 17:19:31 -0700 X-ExtLoop1: 1 Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga005.jf.intel.com with ESMTP; 22 May 2019 17:19:29 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.3]) by PGSMSX104.gar.corp.intel.com ([169.254.3.63]) with mapi id 14.03.0415.000; Thu, 23 May 2019 08:19:29 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v2 3/5] KabylakeOpenBoardPkg: Added GCC5 build support Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v2 3/5] KabylakeOpenBoardPkg: Added GCC5 build support Thread-Index: AQHVD4J00CG9p42K5kiEyiJ5K3p7zaZ321KQ Date: Thu, 23 May 2019 00:19:28 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50325402@PGSMSX111.gar.corp.intel.com> References: <7cb79f83c7f91aef7397d060183158dd366dd667.1558406058.git.prince.agyeman@intel.com> In-Reply-To: <7cb79f83c7f91aef7397d060183158dd366dd667.1558406058.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDg5ODhmMzctOTBlNi00OWI4LTliYmMtZjY0Mjc5NmJmYTg4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZzA2NFFET1U0cGdNaUFwTkpMTFBQYWZJZmhBaCtuN2tZY01IbmNaTUljV1k3KzlLNTRaNWFhRko3cEE4ZUVJVSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Tuesday, May 21, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Agyeman, Prince > > Subject: [edk2-devel] [edk2-platforms] [PATCH v2 3/5] KabylakeOpenBoardP= kg: > Added GCC5 build support >=20 > From: Prince Agyeman >=20 > Fixed: > * Include file paths in dec > * Gcc build options >=20 > Gcc build was tested on Ubuntu 16.04.5 LTS with gcc version 5.4.0, nasm = version > 2.11.08 >=20 > Signed-off-by: Prince Agyeman > --- > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgBuildOption.dsc | > 4 +++- > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec | 6 > +++--- > 2 files changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgBuildO > ption.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgBuild > Option.dsc > index 04c5786..8e885cc 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgBuildO > ption.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgBuild > +++ Option.dsc > @@ -1,7 +1,7 @@ > ## @file > # platform build option configuration file. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -102,6 +102,7 @@ > DEFINE DSC_PLTPKG_FEATURE_BUILD_OPTIONS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $( # For IA32 Specific Build Flag = # > GCC: *_*_IA32_PP_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > +GCC: *_*_IA32_CC_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > -D PI_SPECIFICATION_VERSION=3D0x00010015 -DASF_PEI -Wno-unused > -Wl,--allow-multiple-definition > MSFT: *_*_IA32_ASM_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > MSFT: *_*_IA32_CC_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > $(OPTIMIZE_DISABLE_OPTIONS) -D PI_SPECIFICATION_VERSION=3D0x00010015 > -DASF_PEI > MSFT: *_*_IA32_VFRPP_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $(OPTIMIZE_DISABLE_OPTIONS) > @@ -124,6 +125,7 @@ MSFT: *_*_IA32_ASLCC_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $(OPTIMIZE_D > # For X64 Specific Build Flag > # > GCC: *_*_X64_PP_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > +GCC: *_*_X64_CC_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > -D PI_SPECIFICATION_VERSION=3D0x00010015 -Wno-unused > -Wl,--allow-multiple-definition > MSFT: *_*_X64_ASM_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > MSFT: *_*_X64_CC_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > $(OPTIMIZE_DISABLE_OPTIONS) -D PI_SPECIFICATION_VERSION=3D0x00010015 > MSFT: *_*_X64_VFRPP_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $(OPTIMIZE_DISABLE_OPTIONS) > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > index e326598..68977d0 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -5,7 +5,7 @@ > # INF files to generate AutoGen.c and AutoGen.h files # for the build > infrastructure. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -20,8 +20,8 @@ > PACKAGE_GUID =3D 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E >=20 > [Includes] > Include > -KabylakeRvp3\Include > -Features\Tbt\Include > +KabylakeRvp3/Include > +Features/Tbt/Include >=20 > [Guids] >=20 > -- > 2.7.4 >=20 >=20 >=20