From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Mon, 10 Jun 2019 18:26:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 18:26:05 -0700 X-ExtLoop1: 1 Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga007.jf.intel.com with ESMTP; 10 Jun 2019 18:26:03 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.51]) by KMSMSX152.gar.corp.intel.com ([169.254.11.195]) with mapi id 14.03.0415.000; Tue, 11 Jun 2019 09:26:02 +0800 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. Thread-Topic: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. Thread-Index: AQHVGm/S4B77E6WTrUiD/Mn2antO4aaN4HMAgAfTvFA= Date: Tue, 11 Jun 2019 01:26:02 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5034287F@PGSMSX111.gar.corp.intel.com> References: <20190604005233.12312-1-chasel.chiu@intel.com> <20190604005233.12312-2-chasel.chiu@intel.com> <02A34F284D1DA44BB705E61F7180EF0AAEBD5E6D@ORSMSX114.amr.corp.intel.com> In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AAEBD5E6D@ORSMSX114.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDEyZDhiNjgtOTkxYS00ZTVlLTg4Y2EtMzhmM2UxNTI1NGFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRXBmUzd3T0l0eUo1djY4akNidWNYOHlOZ3ZwN0cxUVpDOTBSVzEwUzJQQk9hWVMwcGY1TnorYlozK0tZMVdyMyJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agreed. Bugzilla filed for enhancement: https://bugzilla.tianocore.org/show_bug.cgi= ?id=3D1892 Thanks! Chasel > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, June 6, 2019 5:54 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Gao, Liming > > Subject: RE: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP= 2.1. >=20 > The FSP specification allows FSP-S to contain an arbitrary number of Firm= ware > Volumes. Your attached patch makes the assumption that it only contains o= ne. > I'm OK if you decide to commit this as-is for now since it is better than= nothing, > but I expect a Bugzilla to be filed to fix the 1 FV assumption. >=20 > Reviewed-by: Nate DeSimone >=20 > -----Original Message----- > From: Chiu, Chasel > Sent: Monday, June 3, 2019 5:53 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1= . >=20 > From: "Chasel, Chiu" >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1873 >=20 > In dispatch mode FSP-S contains DXE drivers so needs to BuildFvHob for DX= E > dispatcher to dispatch this FV. >=20 > Test: FSP API mode still boots successfully without impact. >=20 > Cc: Michael Kubacki > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Chasel Chiu > --- >=20 > Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProce > ssLib/FspWrapperHobProcessLib.c | 19 ++++++++++++++++--- >=20 > Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProce > ssLib/PeiFspWrapperHobProcessLib.inf | 5 ++++- > 2 files changed, 20 insertions(+), 4 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/FspWrapperHobProcessLib.c > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/FspWrapperHobProcessLib.c > index e8df06dfb7..7ee4d3a31c 100644 > --- > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/FspWrapperHobProcessLib.c > +++ > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP > +++ rocessLib/FspWrapperHobProcessLib.c > @@ -1,7 +1,7 @@ > /** @file > Provide FSP wrapper hob process related function. >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -653,8 +653,21 @@ PostFspsHobProcess ( { > EFI_STATUS Status; >=20 > - ProcessFspHobList (FspHobList); > - > + if (PcdGet8 (PcdFspModeSelection) =3D=3D 1) { > + // > + // Only in FSP API mode the wrapper has to build hobs basing on FSP = output > data. > + // > + ASSERT (FspHobList !=3D NULL); > + ProcessFspHobList (FspHobList); > + } else { > + // > + // Only in FSP Dispatch mode, FSP-S should be reported to DXE dispat= cher. > + // > + BuildFvHob ( > + (EFI_PHYSICAL_ADDRESS) (UINTN) PcdGet32 (PcdFlashFvFspSBase), > + PcdGet32 (PcdFlashFvFspSSize) > + ); > + } > CheckFspGraphicsDeviceInfoHob (); > DEBUG_CODE_BEGIN (); > DumpFspSmbiosMemoryInfoHob (); > diff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/PeiFspWrapperHobProcessLib.inf > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/PeiFspWrapperHobProcessLib.inf > index a76e3195d6..64f3302959 100644 > --- > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobPro > cessLib/PeiFspWrapperHobProcessLib.inf > +++ > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobP > +++ rocessLib/PeiFspWrapperHobProcessLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Provide FSP wrapper hob process related function. > # > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -65,6 +65,9 @@ > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength > gMinPlatformPkgTokenSpaceGuid.PcdFspCpuPeiApWakeupBufferAddr > + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection > + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase > + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize >=20 > [Guids] > gFspReservedMemoryResourceHobGuid ## CONSUMES ## > HOB > -- > 2.13.3.windows.1