From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Sun, 16 Jun 2019 20:41:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jun 2019 20:41:17 -0700 X-ExtLoop1: 1 Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga007.jf.intel.com with ESMTP; 16 Jun 2019 20:41:16 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.124]) by PGSMSX102.gar.corp.intel.com ([169.254.6.48]) with mapi id 14.03.0439.000; Mon, 17 Jun 2019 11:41:15 +0800 From: "Chiu, Chasel" To: "Zeng, Star" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. Thread-Index: AQHVIpdyuUQxGlZOAE68pyVMi671waaeRAiggADUzeCAAB69UA== Date: Mon, 17 Jun 2019 03:41:15 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50355FAA@PGSMSX111.gar.corp.intel.com> References: <20190614095621.5824-1-chasel.chiu@intel.com> <15A8AFDD4EE2EEDF.4443@groups.io> <0C09AFA07DD0434D9E2A0C6AEB0483104032F9B9@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483104032F9B9@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGZlMzNmOGYtM2FhNC00MTg0LWIzMzktMzc2MTlmYTJlZjhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicDZWUFFCTHRVZmhLdzFsNDR2WFpDbElDeXorc2FGcTNMK1FwWUszdjdzVGZ4b09IUkxPSFhnamNvYXU1cXJVQyJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Star, Since FspmArchConfigPpi.h also having Ppi postfix, we would like to align = this for TemPRamExitPpi.h in IntelFsp2Pkg. Thanks! Chasel > -----Original Message----- > From: Zeng, Star > Sent: Monday, June 17, 2019 9:51 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. >=20 > And the 'Ppi' postfix seems not needed in the file name. >=20 > Thanks, > Star >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Zeng, Star > > Sent: Sunday, June 16, 2019 9:11 PM > > To: Chiu, Chasel ; devel@edk2.groups.io > > Cc: Desimone, Nathaniel L ; Zeng, Star > > > > Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. > > > > Hi Chasel, > > > > Two minor feedbacks. > > > > 1. The spec defines the return status below, should we follow it? > > > > EFI_SUCCESS FSP execution environment was initialized successfully. > > EFI_INVALID_PARAMETER Input parameters are invalid. > > EFI_UNSUPPORTED The FSP calling conditions were not met. > > EFI_DEVICE_ERROR Temporary memory exit. > > > > > > 2. The gFspTempRamExitPpiGuid should be added into IntelFsp2Pkg.dec, > > right? > > > > > > Thanks, > > Star > > > > > -----Original Message----- > > > From: Chiu, Chasel > > > Sent: Friday, June 14, 2019 5:56 PM > > > To: devel@edk2.groups.io > > > Cc: Desimone, Nathaniel L ; Zeng, > > > Star > > > Subject: [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1883 > > > > > > Add header file for FSP_TEMP_RAM_EXIT_PPI which is defined by FSP > > > 2.1 spec. > > > > > > Test: Build successfully. > > > > > > Cc: Nate DeSimone > > > Cc: Star Zeng > > > Signed-off-by: Chasel Chiu > > > --- > > > IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h | 50 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 50 insertions(+) > > > > > > diff --git a/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > > > b/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > > > new file mode 100644 > > > index 0000000000..9e728a5d4d > > > --- /dev/null > > > +++ b/IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h > > > @@ -0,0 +1,50 @@ > > > +/** @file > > > + This file defines the Silicon Temp Ram Exit PPI which implements > > > +the > > > + required programming steps for disabling temporary memory. > > > + > > > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent > > > + > > > +**/ > > > + > > > +#ifndef _FSP_TEMP_RAM_EXIT_PPI_H_ > > > +#define _FSP_TEMP_RAM_EXIT_PPI_H_ > > > + > > > +/// > > > +/// Global ID for the FSP_TEMP_RAM_EXIT_PPI. > > > +/// > > > +#define FSP_TEMP_RAM_EXIT_GUID \ > > > + { \ > > > + 0xbc1cfbdb, 0x7e50, 0x42be, { 0xb4, 0x87, 0x22, 0xe0, 0xa9, > > > +0x0c, 0xb0, > > > 0x52 } \ > > > + } > > > + > > > +// > > > +// Forward declaration for the FSP_TEMP_RAM_EXIT_PPI. > > > +// > > > +typedef struct _FSP_TEMP_RAM_EXIT_PPI FSP_TEMP_RAM_EXIT_PPI; > > > + > > > +/** > > > + Silicon function for disabling temporary memory. > > > + @param[in] TempRamExitParamPtr - Pointer to the TempRamExit > > > parameters structure. > > > + This structure is normally defin= ed in the > Integration > > > + Guide. If it is not defined in t= he Integration > Guide, > > > + pass NULL. > > > + @retval EFI_SUCCESS - Execution was completed successf= ully. > > > + @retval Status - Error status reported by sub-fun= ctions if > > > implemented. > > > +**/ > > > +typedef > > > +EFI_STATUS > > > +(EFIAPI *FSP_TEMP_RAM_EXIT) ( > > > + IN VOID *TempRamExitParamPtr > > > + ); > > > + > > > +/// > > > +/// This PPI provides function to disable temporary memory. > > > +/// > > > +struct _FSP_TEMP_RAM_EXIT_PPI { > > > + FSP_TEMP_RAM_EXIT TempRamExit; > > > +}; > > > + > > > +extern EFI_GUID gFspTempRamExitPpiGuid; > > > + > > > +#endif // _FSP_TEMP_RAM_EXIT_PPI_H_ > > > -- > > > 2.13.3.windows.1 > > > > > >=20