[PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

[PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

[Ni, Ray]

Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 Maintainers.txt | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 788b46202c..eb41dba7b1 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -130,18 +130,6 @@ M: Chasel Chiu <chasel.chiu@intel.com>
 R: Nate DeSimone <nathaniel.l.desimone@intel.com>
 R: Star Zeng <star.zeng@intel.com>
 
-IntelFspPkg
-W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
-M: Chasel Chiu <chasel.chiu@intel.com>
-R: Nate DeSimone <nathaniel.l.desimone@intel.com>
-R: Star Zeng <star.zeng@intel.com>
-
-IntelFspWrapperPkg
-W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
-M: Chasel Chiu <chasel.chiu@intel.com>
-R: Nate DeSimone <nathaniel.l.desimone@intel.com>
-R: Star Zeng <star.zeng@intel.com>
-
 MdeModulePkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
 M: Jian J Wang <jian.j.wang@intel.com>
-- 
2.21.0.windows.1

Re: [edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Wednesday, July 10, 2019 4:05 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif
> Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH] Maintainers.txt: Remove maintainer info for
> IntelFsp[Wrapper]Pkg
> 
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  Maintainers.txt | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt index 788b46202c..eb41dba7b1
> 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -130,18 +130,6 @@ M: Chasel Chiu <chasel.chiu@intel.com>
>  R: Nate DeSimone <nathaniel.l.desimone@intel.com>
>  R: Star Zeng <star.zeng@intel.com>
> 
> -IntelFspPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
> -M: Chasel Chiu <chasel.chiu@intel.com>
> -R: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -R: Star Zeng <star.zeng@intel.com>
> -
> -IntelFspWrapperPkg
> -W:
> https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
> -M: Chasel Chiu <chasel.chiu@intel.com>
> -R: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -R: Star Zeng <star.zeng@intel.com>
> -
>  MdeModulePkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>  M: Jian J Wang <jian.j.wang@intel.com>
> --
> 2.21.0.windows.1
> 
> 
> 

Re: [PATCH] Maintainers.txt: Remove maintainer info for IntelFsp[Wrapper]Pkg

[Laszlo Ersek]

On 07/10/19 10:05, Ray Ni wrote:
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  Maintainers.txt | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 788b46202c..eb41dba7b1 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -130,18 +130,6 @@ M: Chasel Chiu <chasel.chiu@intel.com>
>  R: Nate DeSimone <nathaniel.l.desimone@intel.com>
>  R: Star Zeng <star.zeng@intel.com>
>  
> -IntelFspPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
> -M: Chasel Chiu <chasel.chiu@intel.com>
> -R: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -R: Star Zeng <star.zeng@intel.com>
> -
> -IntelFspWrapperPkg
> -W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
> -M: Chasel Chiu <chasel.chiu@intel.com>
> -R: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -R: Star Zeng <star.zeng@intel.com>
> -
>  MdeModulePkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
>  M: Jian J Wang <jian.j.wang@intel.com>
> 

The patch itself looks OK to me, but I dislike empty commit message
bodies. Please say at least something like the following:

"We removed IntelFspPkg and IntelFspWrapperPkg for
<https://bugzilla.tianocore.org/show_bug.cgi?id=1819>; now remove the
dangling maintainer/reviewer assignments too".

With that update (no need to repost):

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo