From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Mon, 15 Jul 2019 17:10:09 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2019 17:10:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,494,1557212400"; 
   d="scan'208";a="167486484"
Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87])
  by fmsmga008.fm.intel.com with ESMTP; 15 Jul 2019 17:10:07 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by
 KMSMSX152.gar.corp.intel.com ([169.254.11.92]) with mapi id 14.03.0439.000;
 Tue, 16 Jul 2019 08:10:07 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Gao, Liming" <liming.gao@intel.com>, "Sinha, Ankit"
	<ankit.sinha@intel.com>, "Kubacki, Michael A" <michael.a.kubacki@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [PATCH] ClevoOpenBoardPkg: Added NVMe boot support
Thread-Topic: [PATCH] ClevoOpenBoardPkg: Added NVMe boot support
Thread-Index: AQHVO1wYZj8ZOdzZI0GpCphoH2XVi6bMXthg
Date: Tue, 16 Jul 2019 00:10:06 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5042AE6F@PGSMSX111.gar.corp.intel.com>
References: <33ebf010841802bbe397fe22bace742a1d84a710.1563229322.git.prince.agyeman@intel.com>
In-Reply-To: <33ebf010841802bbe397fe22bace742a1d84a710.1563229322.git.prince.agyeman@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWNlOGFjMGYtZWVhNy00YjIzLWIyNTItNzg0YjdkODk2NTRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia0RaZ1NiRzdFcEFNQWl5K1I3d3hNdTNxN0xxU1c2QnU4MDE3VFN0MGdHRnlKSDRSTTRyVmVEOVwvTjVsWStUXC8wIn0=
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.205]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Agyeman, Prince
> Sent: Tuesday, July 16, 2019 6:24 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Sinha, Ankit <ankit.sinha@intel.c=
om>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] ClevoOpenBoardPkg: Added NVMe boot support
>=20
> Added NVMe dxe driver to enable N1xxWU
> platforms boot from NVMe
>=20
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
>=20
> Signed-off-by: Agyeman <prince.agyeman@intel.com>
> ---
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc | 1 +
> Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 1 +
>  2 files changed, 2 insertions(+)
>=20
> diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc
> index f9deece846..5ba1a82f1c 100644
> --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc
> +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc
> @@ -274,6 +274,7 @@
>    MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
>    MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
>=20
> MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.i
> nf
> +  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
>=20
>    #
>    # Shell
> diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> index 7d76257671..da498ad379 100644
> --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> @@ -330,6 +330,7 @@ INF
> MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
>  INF  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
>  INF  MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
>  INF
> MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.i
> nf
> +INF  MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
>=20
>  INF  ShellPkg/Application/Shell/Shell.inf
>=20
> --
> 2.19.1.windows.1