Re: [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support

["Chiu, Chasel" <chasel.chiu@intel.com>]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Agyeman, Prince
> Sent: Friday, July 26, 2019 11:40 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Agyeman, Prince <prince.agyeman@intel.com>
> Subject: [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support
> 
> Added vbt and configured gpio to enable
> 
> N1xxxW display.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> 
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c               | 2 +-
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf        | 2 +-
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg        | 2 +-
>  Platform/Intel/build_bios.py                                    | 1 +
>  4 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxWU
> GpioTable.c
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxWU
> GpioTable.c
> index 08a20673f0..d055fda8c3 100644
> ---
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxWU
> GpioTable.c
> +++
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> +++ UGpioTable.c
> @@ -100,7 +100,7 @@ GPIO_INIT_CONFIG mGpioTableN1xxWU[] =
>    {GPIO_SKL_LP_GPP_D5,  {GpioPadModeNative1, GpioHostOwnGpio,
> GpioDirNone,  GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//ISH_I2C0_SDA
>    {GPIO_SKL_LP_GPP_D6,  {GpioPadModeNative1, GpioHostOwnGpio,
> GpioDirNone,  GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//ISH_I2C0_SCL
>    {GPIO_SKL_LP_GPP_D7,  {GpioPadModeNative1, GpioHostOwnGpio,
> GpioDirNone,  GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//ISH_I2C1_SDA
> -  {GPIO_SKL_LP_GPP_D8,  {GpioPadModeNative1, GpioHostOwnGpio,
> GpioDirNone,  GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//ISH_I2C1_SCL
> +  {GPIO_SKL_LP_GPP_D8,  {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirOut,   GpioOutHigh,    GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//ISH_I2C1_SCL/SB_BLON
>    {GPIO_SKL_LP_GPP_D9,  {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirIn,    GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//HOME_BTN
>    {GPIO_SKL_LP_GPP_D10, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirIn,    GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//SCREEN_LOCK_PCH
>    {GPIO_SKL_LP_GPP_D11, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirIn,    GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepReset,
> GpioTermNone}},//VOL_UP_PCH
> diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> index da498ad379..9ebc81e933 100644
> --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> @@ -267,7 +267,7 @@ INF
> $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMe
> m.in
> 
>  !if gSiPkgTokenSpaceGuid.PcdPeiDisplayEnable == TRUE  FILE FREEFORM =
> 4ad46122-ffeb-4a52-bfb0-518cfca02db0 {
> -  SECTION RAW = $(PLATFORM_FSP_BIN_PACKAGE)/SampleCode/Vbt/Vbt.bin
> +  SECTION RAW = N1xxWU/Gop/Vbt.bin
>    SECTION UI  = "Vbt"
>  }
>  FILE FREEFORM = 7BB28B99-61BB-11D5-9A5D-0090273FC14D { diff --git
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg
> index a423c8b497..3edc2b14e8 100644
> --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg
> +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg
> @@ -7,7 +7,7 @@
> 
> 
>  [CONFIG]
> -WORKSPACE_PLATFORM_BIN = WORKSPACE_PLATFORM_BIN
> +WORKSPACE_PLATFORM_BIN =
> +edk2-non-osi/Platform/Intel/ClevoOpenBoardBinPkg
>  EDK_SETUP_OPTION =
>  openssl_path =
>  PLATFORM_BOARD_PACKAGE = ClevoOpenBoardPkg diff --git
> a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index
> c01b953d16..beba4acebe 100644
> --- a/Platform/Intel/build_bios.py
> +++ b/Platform/Intel/build_bios.py
> @@ -120,6 +120,7 @@ def pre_build(build_config, build_type="DEBUG",
> silent=False, toolchain=None):
>      config["PACKAGES_PATH"] += os.pathsep + \
>          os.path.join(config["WORKSPACE"], "edk2")
>      config["PACKAGES_PATH"] += os.pathsep +
> os.path.join(config["WORKSPACE"])
> +    config["PACKAGES_PATH"] += os.pathsep +
> + config["WORKSPACE_PLATFORM_BIN"]
>      config["EDK_TOOLS_PATH"] = os.path.join(config["WORKSPACE"],
>                                              config["EDK_TOOLS_PATH"])
>      config["BASE_TOOLS_PATH"] = config["EDK_TOOLS_PATH"]
> --
> 2.19.1.windows.1