From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Sun, 28 Jul 2019 17:47:01 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jul 2019 17:47:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,320,1559545200"; d="scan'208";a="162018258" Received: from kmsmsx156.gar.corp.intel.com ([172.21.138.133]) by orsmga007.jf.intel.com with ESMTP; 28 Jul 2019 17:46:59 -0700 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by KMSMSX156.gar.corp.intel.com (172.21.138.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 08:46:58 +0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by PGSMSX109.gar.corp.intel.com ([169.254.14.91]) with mapi id 14.03.0439.000; Mon, 29 Jul 2019 08:46:58 +0800 From: "Chiu, Chasel" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Sinha, Ankit" , "Desimone, Nathaniel L" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support Thread-Topic: [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support Thread-Index: AQHVQ8hpCyLzEJNgWE64HhQfRlz+cKbgxk9w Date: Mon, 29 Jul 2019 00:46:57 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5043A3C0@PGSMSX111.gar.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDk2MDVhZDAtMGM5Ni00MDA3LTgxNGQtODg5NjYxOWJiODg1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSnZtQVBOZ24yUjVTNVZLTFNyNmxjYkQ5eFZlUjNzZ3lueFA5K3Vzbm15NXROWmpzTXRaTWsweXBFKzRrc0pMWCJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Return-Path: chasel.chiu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Agyeman, Prince > Sent: Friday, July 26, 2019 11:40 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sinha, Ankit ; > Desimone, Nathaniel L ; Kubacki, Michael = A > ; Chiu, Chasel ; > Agyeman, Prince > Subject: [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support >=20 > Added vbt and configured gpio to enable >=20 > N1xxxW display. >=20 > Cc: Liming Gao > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Michael Kubacki > Cc: Chasel Chiu >=20 > Signed-off-by: Prince Agyeman > --- > .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c | 2 +- > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 2 +- > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg | 2 +- > Platform/Intel/build_bios.py | 1 + > 4 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git > a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxWU > GpioTable.c > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxWU > GpioTable.c > index 08a20673f0..d055fda8c3 100644 > --- > a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxWU > GpioTable.c > +++ > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW > +++ UGpioTable.c > @@ -100,7 +100,7 @@ GPIO_INIT_CONFIG mGpioTableN1xxWU[] =3D > {GPIO_SKL_LP_GPP_D5, {GpioPadModeNative1, GpioHostOwnGpio, > GpioDirNone, GpioOutDefault, GpioIntDis, GpioHostDeepReset, > GpioTermNone}},//ISH_I2C0_SDA > {GPIO_SKL_LP_GPP_D6, {GpioPadModeNative1, GpioHostOwnGpio, > GpioDirNone, GpioOutDefault, GpioIntDis, GpioHostDeepReset, > GpioTermNone}},//ISH_I2C0_SCL > {GPIO_SKL_LP_GPP_D7, {GpioPadModeNative1, GpioHostOwnGpio, > GpioDirNone, GpioOutDefault, GpioIntDis, GpioHostDeepReset, > GpioTermNone}},//ISH_I2C1_SDA > - {GPIO_SKL_LP_GPP_D8, {GpioPadModeNative1, GpioHostOwnGpio, > GpioDirNone, GpioOutDefault, GpioIntDis, GpioHostDeepReset, > GpioTermNone}},//ISH_I2C1_SCL > + {GPIO_SKL_LP_GPP_D8, {GpioPadModeGpio, GpioHostOwnGpio, > GpioDirOut, GpioOutHigh, GpioIntDis, GpioHostDeepReset, > GpioTermNone}},//ISH_I2C1_SCL/SB_BLON > {GPIO_SKL_LP_GPP_D9, {GpioPadModeGpio, GpioHostOwnGpio, > GpioDirIn, GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepRese= t, > GpioTermNone}},//HOME_BTN > {GPIO_SKL_LP_GPP_D10, {GpioPadModeGpio, GpioHostOwnGpio, > GpioDirIn, GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepRese= t, > GpioTermNone}},//SCREEN_LOCK_PCH > {GPIO_SKL_LP_GPP_D11, {GpioPadModeGpio, GpioHostOwnGpio, > GpioDirIn, GpioOutDefault, GpioIntLevel | GpioIntDis, GpioHostDeepRese= t, > GpioTermNone}},//VOL_UP_PCH > diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf > index da498ad379..9ebc81e933 100644 > --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf > +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf > @@ -267,7 +267,7 @@ INF > $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMe > m.in >=20 > !if gSiPkgTokenSpaceGuid.PcdPeiDisplayEnable =3D=3D TRUE FILE FREEFORM = =3D > 4ad46122-ffeb-4a52-bfb0-518cfca02db0 { > - SECTION RAW =3D $(PLATFORM_FSP_BIN_PACKAGE)/SampleCode/Vbt/Vbt.bin > + SECTION RAW =3D N1xxWU/Gop/Vbt.bin > SECTION UI =3D "Vbt" > } > FILE FREEFORM =3D 7BB28B99-61BB-11D5-9A5D-0090273FC14D { diff --git > a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg > index a423c8b497..3edc2b14e8 100644 > --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg > +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/build_config.cfg > @@ -7,7 +7,7 @@ >=20 >=20 > [CONFIG] > -WORKSPACE_PLATFORM_BIN =3D WORKSPACE_PLATFORM_BIN > +WORKSPACE_PLATFORM_BIN =3D > +edk2-non-osi/Platform/Intel/ClevoOpenBoardBinPkg > EDK_SETUP_OPTION =3D > openssl_path =3D > PLATFORM_BOARD_PACKAGE =3D ClevoOpenBoardPkg diff --git > a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index > c01b953d16..beba4acebe 100644 > --- a/Platform/Intel/build_bios.py > +++ b/Platform/Intel/build_bios.py > @@ -120,6 +120,7 @@ def pre_build(build_config, build_type=3D"DEBUG", > silent=3DFalse, toolchain=3DNone): > config["PACKAGES_PATH"] +=3D os.pathsep + \ > os.path.join(config["WORKSPACE"], "edk2") > config["PACKAGES_PATH"] +=3D os.pathsep + > os.path.join(config["WORKSPACE"]) > + config["PACKAGES_PATH"] +=3D os.pathsep + > + config["WORKSPACE_PLATFORM_BIN"] > config["EDK_TOOLS_PATH"] =3D os.path.join(config["WORKSPACE"], > config["EDK_TOOLS_PATH"]) > config["BASE_TOOLS_PATH"] =3D config["EDK_TOOLS_PATH"] > -- > 2.19.1.windows.1