From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: chasel.chiu@intel.com) Received: from mga18.intel.com (mga18.intel.com []) by groups.io with SMTP; Mon, 29 Jul 2019 20:49:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 20:49:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,325,1559545200"; d="scan'208";a="195662626" Received: from pgsmsx114.gar.corp.intel.com ([10.108.55.203]) by fmsmga004.fm.intel.com with ESMTP; 29 Jul 2019 20:49:19 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by pgsmsx114.gar.corp.intel.com ([169.254.4.144]) with mapi id 14.03.0439.000; Tue, 30 Jul 2019 11:49:12 +0800 From: "Chiu, Chasel" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD Thread-Topic: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD Thread-Index: AQHVRf3jfJKKO6sbYkOmBgv0fdlMuqbihkvwgAAAobA= Date: Tue, 30 Jul 2019 03:49:11 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC504418B9@PGSMSX111.gar.corp.intel.com> References: <20190729110715.2312-1-chasel.chiu@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F93@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4C4F93@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGJjNmEyMTUtZjIzMy00YTQ3LTliNmItNjc1NWUxYzc2NzgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK3RWWXY4NGM4ODROXC80N3N2OVNRaVFpbGxrK0RCOWlZeEFJSkNtNzVpZjlkdlwvS2llU3habzVWdmI1U242TW8xIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, we will remove them later after confirming no impact to all platforms. Regards, Chasel > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, July 30, 2019 11:46 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Sinha, Ankit > ; Desimone, Nathaniel L > > Subject: RE: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD >=20 > Chasel: > This is a good enhancement. With this change, can > RebaseAndPatchFspBinBaseAddress.py and PatchFspBinFvsBaseAddress.py be > removed? >=20 > Thanks > Liming > > -----Original Message----- > > From: Chiu, Chasel > > Sent: Monday, July 29, 2019 7:07 PM > > To: devel@edk2.groups.io > > Cc: Kubacki, Michael A ; Sinha, Ankit > > ; Desimone, Nathaniel L > > ; Gao, Liming > > Subject: [PATCH 0/4] Auto configure Fsp*BaseAddress PCD > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1863 > > > > PcdFsp*BaseAddress now will be updated in FDF basing on flash map. > > DSC will only define types of those PCDs and always having 0 as > > default. > > New script added to only rebase FSP binary without patching DSC file. > > > > Test: interanl platform booted with this patch. > > > > Cc: Michael Kubacki > > Cc: Ankit Sinha > > Cc: Nate DeSimone > > Cc: Liming Gao > > Signed-off-by: Chasel Chiu > > > > Chasel Chiu (4): > > MinPlatformPkg: Auto configure Fsp*BaseAddress PCD > > Platform/Intel: Auto configure Fsp*BaseAddress PCD > > KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD > > > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf > | 3 +++ > > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc > | 12 +++++++++--- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > | 3 +++ > > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc > | 12 +++++++++--- > > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py | > 96 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++ > > Platform/Intel/build_bios.py |= 7 ++----- > > 6 files changed, 122 insertions(+), 11 deletions(-) create mode > > 100644 > > Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py > > > > -- > > 2.13.3.windows.1