public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
Date: Thu, 8 Aug 2019 06:58:32 +0000	[thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50457EC3@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <20190808062456.6116-4-shenglei.zhang@intel.com>


Please extend copyright to 2019 of this file.
With above change Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, August 8, 2019 2:25 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF
> file
> 
> SecFsp.h is used but missing inf file, which will cause generating warning
> message.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> index 3de09b5b4921..86d3d31d3269 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> @@ -22,6 +22,7 @@ [Defines]
> 
>  [Sources]
>    SecFspApiChk.c
> +  SecFsp.h
> 
>  [Sources.IA32]
>    Ia32/Stack.nasm
> --
> 2.18.0.windows.1


  reply	other threads:[~2019-08-08  6:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08  6:24 [PATCH 0/3] Fix warning message issues Zhang, Shenglei
2019-08-08  6:24 ` [PATCH 1/3] MdeModulePkg: Add missing header files in INF files Zhang, Shenglei
2019-08-12  1:59   ` [edk2-devel] " Wu, Hao A
2019-08-12  5:19     ` Zhang, Shenglei
2019-08-08  6:24 ` [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF Zhang, Shenglei
2019-08-08  8:58   ` [edk2-devel] " Gao, Zhichao
2019-08-08 14:51     ` Carsey, Jaben
2019-08-08  6:24 ` [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Zhang, Shenglei
2019-08-08  6:58   ` Chiu, Chasel [this message]
2019-08-08 14:56     ` Zeng, Star
2019-08-08 20:47       ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3EFB470A303B4AB093197B6777CCEC50457EC3@PGSMSX111.gar.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox