public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kubacki, Michael A" <michael.a.kubacki@intel.com>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] MinPlatformPkg: Fix duplicate GUID
Date: Thu, 8 Aug 2019 14:02:37 +0000	[thread overview]
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC50458643@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <20190806203351.24460-1-michael.a.kubacki@intel.com>

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Kubacki, Michael A
> Sent: Wednesday, August 7, 2019 4:34 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] MinPlatformPkg: Fix
> duplicate GUID
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1983
> 
> PeiLib.inf and TestPointCheckLibNull.inf currently have the same GUID.
> This patch assigns a unique GUID to each library INF file.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.inf             | 6 +++---
>  .../Test/Library/TestPointCheckLibNull/TestPointCheckLibNull.inf    | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.inf
> b/Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.inf
> index 86b1628c9f..7e740172a0 100644
> --- a/Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.inf
> +++ b/Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  # Component information file for Board Init Test Library  # -# Copyright (c)
> 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -10,7 +10,7 @@
> [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = PeiLib
> -  FILE_GUID                      = 657A478B-16B9-4B6D-9C41-BEF86197BDF4
> +  FILE_GUID                      = F19AA754-CE24-448D-B755-1F939B00C25D
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = PeiLib
> @@ -26,6 +26,6 @@
> 
>  [Sources]
>    PeiLib.c
> -
> +
>  [Ppis]
>    gEfiPeiReadOnlyVariable2PpiGuid               ## CONSUMES
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLibNull/TestPo
> intCheckLibNull.inf
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLibNull/TestPo
> intCheckLibNull.inf
> index bead6ba35b..0a59f02779 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLibNull/TestPo
> intCheckLibNull.inf
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLibNull/T
> +++ estPointCheckLibNull.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  # Component information file for Board Init Test Library  # -# Copyright (c)
> 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -10,7 +10,7 @@
> [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = TestPointCheckLibNull
> -  FILE_GUID                      = 657A478B-16B9-4B6D-9C41-BEF86197BDF4
> +  FILE_GUID                      = A50DAF74-4EC0-46CD-A1ED-C885D4E97F2B
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = TestPointCheckLib
> --
> 2.16.2.windows.1
> 
> 
> 


      parent reply	other threads:[~2019-08-08 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 20:33 [edk2-platforms][PATCH V1 1/1] MinPlatformPkg: Fix duplicate GUID Kubacki, Michael A
2019-08-07  0:49 ` [edk2-devel] " Liming Gao
2019-08-08 14:02 ` Chiu, Chasel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C3EFB470A303B4AB093197B6777CCEC50458643@PGSMSX111.gar.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox