From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by groups.io with SMTP; Sun, 11 Aug 2019 19:08:57 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 19:08:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,375,1559545200"; 
   d="scan'208";a="375084385"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
  by fmsmga005.fm.intel.com with ESMTP; 11 Aug 2019 19:08:56 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by
 KMSMSX151.gar.corp.intel.com ([169.254.10.91]) with mapi id 14.03.0439.000;
 Mon, 12 Aug 2019 10:07:32 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Desimone, Nathaniel L"
	<nathaniel.l.desimone@intel.com>
CC: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH]
 Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Thread-Index: AQHVTkv9Gy3lORdAaUSA3iZuCICuDqb2yLqg
Date: Mon, 12 Aug 2019 02:07:32 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5045B1D3@PGSMSX111.gar.corp.intel.com>
References: <20190809004653.39088-1-nathaniel.l.desimone@intel.com>
In-Reply-To: <20190809004653.39088-1-nathaniel.l.desimone@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzViNzRhMjgtMjNmYi00MWMwLWE3YTgtNTg4Y2RkZDIwNjM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSWlPNFhZczVReWh3aytteXNDNjJGampsamdldmsxVFZwU0JmRHMwK2NJZzk5OEpqMkZoVUNTb1NpXC9uQ09nbHEifQ==
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.205]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Nate DeSimone
> Sent: Friday, August 9, 2019 8:47 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH]
> Platform/Intel/KabylakeOpenBoardPkg: Fix build.
>=20
> The build for KabylakeOpenBoardPkg is presently broken due to
> WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in
> KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>=20
> Setting this macro to an empty string resolves the issue.
>=20
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> index bf89ea399c..ab1a9a61c2 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> @@ -7,7 +7,7 @@
>=20
>=20
>  [CONFIG]
> -WORKSPACE_PLATFORM_BIN =3D WORKSPACE_PLATFORM_BIN
> +WORKSPACE_PLATFORM_BIN =3D
>  EDK_SETUP_OPTION =3D
>  openssl_path =3D
>  PLATFORM_BOARD_PACKAGE =3D KabylakeOpenBoardPkg
> --
> 2.17.1.windows.2
>=20
>=20
>=20