From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: chasel.chiu@intel.com)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by groups.io with SMTP; Sun, 11 Aug 2019 23:26:57 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga001.jf.intel.com ([10.7.209.18])
  by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2019 23:26:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,376,1559545200"; 
   d="scan'208";a="259688661"
Received: from pgsmsx114.gar.corp.intel.com ([10.108.55.203])
  by orsmga001.jf.intel.com with ESMTP; 11 Aug 2019 23:26:56 -0700
Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by
 pgsmsx114.gar.corp.intel.com ([169.254.4.144]) with mapi id 14.03.0439.000;
 Mon, 12 Aug 2019 14:26:47 +0800
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>, "Zeng, Star"
	<star.zeng@intel.com>
Subject: Re: [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file
Thread-Topic: [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header
 file in INF file
Thread-Index: AQHVUNZlQcz9vn5jT0WmLdTK0xnvqab3DBPg
Date: Mon, 12 Aug 2019 06:26:46 +0000
Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5045B625@PGSMSX111.gar.corp.intel.com>
References: <20190812062243.14472-1-shenglei.zhang@intel.com>
 <20190812062243.14472-4-shenglei.zhang@intel.com>
In-Reply-To: <20190812062243.14472-4-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWM0OTIzMjAtODlhNC00NDM5LTg5ZjQtODVjYWY1MjE2N2Y1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ1BGTmZ6SjVQYTYxQnJxQzYzdXhNdTFzWUJtNHA0N2MxWGw4OHJ6WldLK3hETFFoQTIyeWl3cDdwTmV4S0xkWSJ9
x-ctpclassification: CTP_NT
x-originating-ip: [172.30.20.206]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, August 12, 2019 2:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v2 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file =
in
> INF file
>=20
> SecFsp.h is used but missing inf file, which will cause generating warnin=
g
> message.
>=20
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> Reviewed-by: Star Zeng <star.zeng@intel.com>
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> index 3de09b5b4921..17924b118c83 100644
> --- a/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +++ b/IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Sec Core for FSP
>  #
> -#  Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR=
>
> +#  Copyright (c) 2016 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -22,6 +22,7 @@
> [Defines]
>=20
>  [Sources]
>    SecFspApiChk.c
> +  SecFsp.h
>=20
>  [Sources.IA32]
>    Ia32/Stack.nasm
> --
> 2.18.0.windows.1