From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Mon, 12 Aug 2019 00:45:24 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 00:45:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,376,1559545200"; d="scan'208,217";a="177405385" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga007.fm.intel.com with ESMTP; 12 Aug 2019 00:45:23 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by PGSMSX103.gar.corp.intel.com ([169.254.2.247]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 15:45:22 +0800 From: "Chiu, Chasel" To: "rfc@edk2.groups.io" CC: "Gao, Liming" , "Feng, Bob C" , "devel@edk2.groups.io" Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Topic: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Index: AdVQ4WroZfB3mdj6SpKK06WHGB09pw== Date: Mon, 12 Aug 2019 07:45:22 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5045B801@PGSMSX111.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmE0MjY3ODktZjQyNS00OGRiLTk0N2MtYmYyM2Q1ZDdkNzQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid3ZzSDdHYVhBenRoVDRaVWhoS0NSaVFaUVZ5dGo2ZzQ3OExzaFBrU0F6aytjQmpkVDRnb2RuNW5jQVNPNXFWTSJ9 x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_3C3EFB470A303B4AB093197B6777CCEC5045B801PGSMSX111garcor_" --_000_3C3EFB470A303B4AB093197B6777CCEC5045B801PGSMSX111garcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello, I would like to add below simple script to 201908 stable tag, review was se= nt on August 8th: A script that can return UTC date and time in ascii format which is conveni= ent for patching build time information in any binary. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2067 Patch: https://edk2.groups.io/g/devel/topic/32797962#45177 Thanks! Chasel --_000_3C3EFB470A303B4AB093197B6777CCEC5045B801PGSMSX111garcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

 

Hello,

 

I would like to add below simpl= e script to 201908 stable tag, review was sent on August 8th:

A script that can return UTC date and time in a= scii format which is convenient for patching build time information in any = binary.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2067=

Patch: https://edk= 2.groups.io/g/devel/topic/32797962#45177

 

Thanks!

Chasel

 

--_000_3C3EFB470A303B4AB093197B6777CCEC5045B801PGSMSX111garcor_-- From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 13 Aug 2019 06:42:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 06:42:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,381,1559545200"; d="scan'208,217";a="375602033" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 13 Aug 2019 06:42:27 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 13 Aug 2019 06:42:27 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 13 Aug 2019 06:42:26 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000; Tue, 13 Aug 2019 21:42:24 +0800 From: "Liming Gao" To: "Chiu, Chasel" , "rfc@edk2.groups.io" CC: "Feng, Bob C" , "devel@edk2.groups.io" , "Cetola, Stephano" , "leif.lindholm@linaro.org" , "Laszlo Ersek (lersek@redhat.com)" , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Topic: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Index: AdVQ4WroZfB3mdj6SpKK06WHGB09pwA+07uQ Date: Tue, 13 Aug 2019 13:42:23 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02AD@SHSMSX104.ccr.corp.intel.com> References: <3C3EFB470A303B4AB093197B6777CCEC5045B801@PGSMSX111.gar.corp.intel.com> In-Reply-To: <3C3EFB470A303B4AB093197B6777CCEC5045B801@PGSMSX111.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmE0MjY3ODktZjQyNS00OGRiLTk0N2MtYmYyM2Q1ZDdkNzQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid3ZzSDdHYVhBenRoVDRaVWhoS0NSaVFaUVZ5dGo2ZzQ3OExzaFBrU0F6aytjQmpkVDRnb2RuNW5jQVNPNXFWTSJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02ADSHSMSX104ccrcor_" --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02ADSHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This is a small helper script. I am OK to add it for edk2-stable201908 stab= le tag. Thanks Liming From: Chiu, Chasel Sent: Monday, August 12, 2019 3:45 PM To: rfc@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ;= devel@edk2.groups.io Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-st= able201908 stable tag. Hello, I would like to add below simple script to 201908 stable tag, review was se= nt on August 8th: A script that can return UTC date and time in ascii format which is conveni= ent for patching build time information in any binary. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2067 Patch: https://edk2.groups.io/g/devel/topic/32797962#45177 Thanks! Chasel --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02ADSHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

This is a small helper script. I am OK to add it for edk2-stable2= 01908 stable tag.

 

Thanks

Liming

From: Chiu, Chasel
Sent: Monday, August 12, 2019 3:45 PM
To: rfc@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.= feng@intel.com>; devel@edk2.groups.io
Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for = edk2-stable201908 stable tag.

 

 

Hello,

 

I would like to add below simple script to 201908 stable tag, review = was sent on August 8th:

A script t= hat can return UTC date and time in ascii format which is convenient for pa= tching build time information in any binary.

REF: https://b= ugzilla.tianocore.org/show_bug.cgi?id=3D2067

Patch: https://edk= 2.groups.io/g/devel/topic/32797962#45177

 

Thanks!

Chasel

 

--_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02ADSHSMSX104ccrcor_-- From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=hyXrTKrS; spf=pass (domain: linaro.org, ip: 209.85.128.46, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by groups.io with SMTP; Tue, 13 Aug 2019 11:30:03 -0700 Received: by mail-wm1-f46.google.com with SMTP id v19so2287011wmj.5 for ; Tue, 13 Aug 2019 11:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fOwGxMkvKkI37f/ugI8MxM0gyMzrmPZ5EGa3q5RefEo=; b=hyXrTKrS46RPOCNCxCEWoLJMPIHy/l1gAOrOyO4QDXWU/iy/hgqWXsvliExIwyatbU p8bzwJXEJzhkbbQWYIIBETqO9lNbvQwrwPK96NcHCjvX4wKNL7d/BPNWFzio+sFWL93T Icq1Zo49jfab3nB/FeO5+gD5y4+IsRQbzgRcOXMz0EWJ77qQYIebAuU5gNI3/Jtl6On6 NsdtlqD7BdooTi9NEju4xbgxVblbxmbas6ykHdafGTOyOxeZraSv+YTYL6wkcp7YqpKR gg9TAtKOGkIzT4xUBlGCaZBaX4hV/Ogqacon/I+4udgKhrDFaOhrjK6cMH1EMNj9rS6L VsJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fOwGxMkvKkI37f/ugI8MxM0gyMzrmPZ5EGa3q5RefEo=; b=XuDxtWI9K/BQh23KHWQvrKS9PjuuN03cyh9+w9dASG7LcvOF4IoAYkidM4k5XyZo/I 4pJBuQlzCTrPkk6qdT98SE2KL+OAW5Mha/jk7yiUckb96hJYI//TLsvTSTgqJ7bPkJPC JmHf6TCxVbkuq35WQOciDEFvbVcQF1eXjj+uRpGFkTE3xfLtagy94Zr+KnVz7NjG2eu5 stHxdU+PsKyAVKgTAzBWwI6kvhj5MWF0ddDccbplP2bQxR4o3cz7JzA56o1/3qIUnh2q XgnlkuBDKDeHYZVkACEMAX63XO4GksB1PTIi8T2K4O/INUJ3807M3Yzkn+E7AzdUzJzr RH2A== X-Gm-Message-State: APjAAAXpJtQ2+Ez0d1JFkTcmWpfKn1Q6Am56MaJ0cT2MiFEMx+X31QO/ cMVVCAZmpw38UQ3GFLL49p8B2g== X-Google-Smtp-Source: APXvYqz/0WdQmQaaSZARf6GxB3cjFGmAlCV1cQ72oY+/v+IMkERtSAp11wsX1hlYVC0irS2wyuw6zQ== X-Received: by 2002:a7b:c85a:: with SMTP id c26mr4447562wml.77.1565721001391; Tue, 13 Aug 2019 11:30:01 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p10sm2585976wma.8.2019.08.13.11.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2019 11:30:00 -0700 (PDT) Date: Tue, 13 Aug 2019 19:29:58 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: "Chiu, Chasel" , "rfc@edk2.groups.io" , "Feng, Bob C" , "devel@edk2.groups.io" , "Cetola, Stephano" , "Laszlo Ersek (lersek@redhat.com)" , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Message-ID: <20190813182958.GE29255@bivouac.eciton.net> References: <3C3EFB470A303B4AB093197B6777CCEC5045B801@PGSMSX111.gar.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02AD@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02AD@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I am not fundamentally opposed to merging a simple script that does not affect other code in the tree. *But* the fact that we have multiple occurrences of this this time around *is* a bit of a concern for me. Yes, they won't affect the workings of anything else as part of the release. But they will not have had any chance to be actually used by others. For this particular script, I am also not very keen on the implementation. It manually parses the command line and prints usage instead of using argparse. And it contains the sys.exit(Main()) antipattern, which does not play well with Python3 asynchronous i/o (and hence is a bad habit to get into). Since this script is truly trivial, I am OK for it to be included *if* it is rewritten using argparse and not calling sys.exit. Best Regards, Leif On Tue, Aug 13, 2019 at 01:42:23PM +0000, Gao, Liming wrote: > This is a small helper script. I am OK to add it for edk2-stable201908 stable tag. > > Thanks > Liming > From: Chiu, Chasel > Sent: Monday, August 12, 2019 3:45 PM > To: rfc@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io > Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. > > > Hello, > > I would like to add below simple script to 201908 stable tag, review was sent on August 8th: > > A script that can return UTC date and time in ascii format which is convenient for patching build time information in any binary. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067 > Patch: https://edk2.groups.io/g/devel/topic/32797962#45177 > > Thanks! > Chasel > From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 13 Aug 2019 21:10:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 21:10:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,383,1559545200"; d="scan'208";a="170605161" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga008.jf.intel.com with ESMTP; 13 Aug 2019 21:10:49 -0700 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.22]) by PGSMSX105.gar.corp.intel.com ([169.254.4.133]) with mapi id 14.03.0439.000; Wed, 14 Aug 2019 12:10:48 +0800 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" , "Gao, Liming" CC: "rfc@edk2.groups.io" , "Feng, Bob C" , "Cetola, Stephano" , "Laszlo Ersek (lersek@redhat.com)" , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Topic: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag. Thread-Index: AdVQ4WroZfB3mdj6SpKK06WHGB09pwA+07uQ///KqAD//tkX4A== Date: Wed, 14 Aug 2019 04:10:48 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC5045D885@PGSMSX111.gar.corp.intel.com> References: <3C3EFB470A303B4AB093197B6777CCEC5045B801@PGSMSX111.gar.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D02AD@SHSMSX104.ccr.corp.intel.com> <20190813182958.GE29255@bivouac.eciton.net> In-Reply-To: <20190813182958.GE29255@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTgyZWIyODYtOGMzNi00N2RkLTk3NzctN2Y4ZmUwZmFkMWY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTnd4WUNNT2tyVHBPV3ZoTEJTN01sSXJoSmFqTjFcL3h4XC9IVlFJZ3FYdWMrZk9ZTlppeWdCWUFKSDVaK0xvVVNvIn0= x-ctpclassification: CTP_NT x-originating-ip: [172.30.20.206] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, Thanks for the valuable feedbacks and suggestions. I will re-write script and re-send code review. Regards, Chasel > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Le= if > Lindholm > Sent: Wednesday, August 14, 2019 2:30 AM > To: Gao, Liming > Cc: Chiu, Chasel ; rfc@edk2.groups.io; Feng, Bob = C > ; devel@edk2.groups.io; Cetola, Stephano > ; Laszlo Ersek (lersek@redhat.com) > ; afish@apple.com; Kinney, Michael D > > Subject: Re: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add > GetUtcDateTime.py for edk2-stable201908 stable tag. >=20 > I am not fundamentally opposed to merging a simple script that does not = affect > other code in the tree. >=20 > *But* the fact that we have multiple occurrences of this this time aroun= d *is* > a bit of a concern for me. Yes, they won't affect the workings of anythi= ng else > as part of the release. But they will not have had any chance to be actu= ally used > by others. >=20 > For this particular script, I am also not very keen on the implementatio= n. It > manually parses the command line and prints usage instead of using argpa= rse. > And it contains the sys.exit(Main()) antipattern, which does not play we= ll with > Python3 asynchronous i/o (and hence is a bad habit to get into). >=20 > Since this script is truly trivial, I am OK for it to be included *if* i= t is rewritten > using argparse and not calling sys.exit. >=20 > Best Regards, >=20 > Leif >=20 > On Tue, Aug 13, 2019 at 01:42:23PM +0000, Gao, Liming wrote: > > This is a small helper script. I am OK to add it for edk2-stable201908= stable > tag. > > > > Thanks > > Liming > > From: Chiu, Chasel > > Sent: Monday, August 12, 2019 3:45 PM > > To: rfc@edk2.groups.io > > Cc: Gao, Liming ; Feng, Bob C > > ; devel@edk2.groups.io > > Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for > edk2-stable201908 stable tag. > > > > > > Hello, > > > > I would like to add below simple script to 201908 stable tag, review w= as sent > on August 8th: > > > > A script that can return UTC date and time in ascii format which is co= nvenient > for patching build time information in any binary. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2067 > > Patch: https://edk2.groups.io/g/devel/topic/32797962#45177 > > > > Thanks! > > Chasel > > >=20 >=20