Re: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for edk2-stable201908 stable tag.

["Chiu, Chasel" <chasel.chiu@intel.com>]

Hi Leif,

Thanks for the valuable feedbacks and suggestions.
I will re-write script and re-send code review.

Regards,
Chasel


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Wednesday, August 14, 2019 2:30 AM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; rfc@edk2.groups.io; Feng, Bob C
> <bob.c.feng@intel.com>; devel@edk2.groups.io; Cetola, Stephano
> <stephano.cetola@intel.com>; Laszlo Ersek (lersek@redhat.com)
> <lersek@redhat.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [RFC] BZ 2067 BaseTools/Scripts: Add
> GetUtcDateTime.py for edk2-stable201908 stable tag.
> 
> I am not fundamentally opposed to merging a simple script that does not affect
> other code in the tree.
> 
> *But* the fact that we have multiple occurrences of this this time around *is*
> a bit of a concern for me. Yes, they won't affect the workings of anything else
> as part of the release. But they will not have had any chance to be actually used
> by others.
> 
> For this particular script, I am also not very keen on the implementation. It
> manually parses the command line and prints usage instead of using argparse.
> And it contains the sys.exit(Main()) antipattern, which does not play well with
> Python3 asynchronous i/o (and hence is a bad habit to get into).
> 
> Since this script is truly trivial, I am OK for it to be included *if* it is rewritten
> using argparse and not calling sys.exit.
> 
> Best Regards,
> 
> Leif
> 
> On Tue, Aug 13, 2019 at 01:42:23PM +0000, Gao, Liming wrote:
> > This is a small helper script. I am OK to add it for edk2-stable201908 stable
> tag.
> >
> > Thanks
> > Liming
> > From: Chiu, Chasel
> > Sent: Monday, August 12, 2019 3:45 PM
> > To: rfc@edk2.groups.io
> > Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C
> > <bob.c.feng@intel.com>; devel@edk2.groups.io
> > Subject: [RFC] BZ 2067 BaseTools/Scripts: Add GetUtcDateTime.py for
> edk2-stable201908 stable tag.
> >
> >
> > Hello,
> >
> > I would like to add below simple script to 201908 stable tag, review was sent
> on August 8th:
> >
> > A script that can return UTC date and time in ascii format which is convenient
> for patching build time information in any binary.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2067
> > Patch: https://edk2.groups.io/g/devel/topic/32797962#45177
> >
> > Thanks!
> > Chasel
> >
> 
>